From 089a39e859b2917ad38872f3ffa2360060222790 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Wed, 19 Oct 2016 13:50:17 +0000 Subject: [PATCH] Don't copy replacements in for-range loop. NFC. llvm-svn: 284589 --- clang-tools-extra/include-fixer/tool/ClangIncludeFixer.cpp | 2 +- clang/lib/Format/TokenAnalyzer.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/include-fixer/tool/ClangIncludeFixer.cpp b/clang-tools-extra/include-fixer/tool/ClangIncludeFixer.cpp index ed1ab20..969ac377 100644 --- a/clang-tools-extra/include-fixer/tool/ClangIncludeFixer.cpp +++ b/clang-tools-extra/include-fixer/tool/ClangIncludeFixer.cpp @@ -416,7 +416,7 @@ int includeFixerMain(int argc, const char **argv) { // Write replacements to disk. Rewriter Rewrites(SM, LangOptions()); - for (const auto Replacement : FixerReplacements) { + for (const auto &Replacement : FixerReplacements) { if (!tooling::applyAllReplacements(Replacement, Rewrites)) { llvm::errs() << "Failed to apply replacements.\n"; return 1; diff --git a/clang/lib/Format/TokenAnalyzer.cpp b/clang/lib/Format/TokenAnalyzer.cpp index d3122ca..f2e4e8e 100644 --- a/clang/lib/Format/TokenAnalyzer.cpp +++ b/clang/lib/Format/TokenAnalyzer.cpp @@ -120,7 +120,7 @@ tooling::Replacements TokenAnalyzer::process() { for (unsigned i = 0, e = AnnotatedLines.size(); i != e; ++i) { delete AnnotatedLines[i]; } - for (auto R : RunResult) { + for (const auto &R : RunResult) { auto Err = Result.add(R); // FIXME: better error handling here. For now, simply return an empty // Replacements to indicate failure. -- 2.7.4