From 0857df38bd3cbff4c30cb1bc4366afacd3cc973d Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Thu, 1 Nov 2018 22:56:15 +0000 Subject: [PATCH] [IR] remove fake binop query for fneg We want to remove this fneg API because it would silently fail if we add an actual fneg instruction to IR (as proposed in D53877 ). We have a newer 'match' API that makes checking for these patterns simpler. It also works with vectors that may include undef elements in constants. If any out-of-tree users need updating, they can model their code changes on this commit: https://reviews.llvm.org/rL345295 llvm-svn: 345904 --- llvm/include/llvm/IR/InstrTypes.h | 7 ------- llvm/lib/IR/Instructions.cpp | 19 ------------------- 2 files changed, 26 deletions(-) diff --git a/llvm/include/llvm/IR/InstrTypes.h b/llvm/include/llvm/IR/InstrTypes.h index 4487768..ec782fa 100644 --- a/llvm/include/llvm/IR/InstrTypes.h +++ b/llvm/include/llvm/IR/InstrTypes.h @@ -308,13 +308,6 @@ public: static BinaryOperator *CreateNot(Value *Op, const Twine &Name, BasicBlock *InsertAtEnd); - /// Check if the given Value is an FNeg instruction. - static bool isFNeg(const Value *V, bool IgnoreZeroSign=false); - - /// Helper functions to extract the unary argument of an FNeg. - static const Value *getFNegArgument(const Value *BinOp); - static Value *getFNegArgument( Value *BinOp); - BinaryOps getOpcode() const { return static_cast(Instruction::getOpcode()); } diff --git a/llvm/lib/IR/Instructions.cpp b/llvm/lib/IR/Instructions.cpp index d927065..3b8d8d0 100644 --- a/llvm/lib/IR/Instructions.cpp +++ b/llvm/lib/IR/Instructions.cpp @@ -2109,25 +2109,6 @@ BinaryOperator *BinaryOperator::CreateNot(Value *Op, const Twine &Name, Op->getType(), Name, InsertAtEnd); } -bool BinaryOperator::isFNeg(const Value *V, bool IgnoreZeroSign) { - if (const BinaryOperator *Bop = dyn_cast(V)) - if (Bop->getOpcode() == Instruction::FSub) - if (Constant *C = dyn_cast(Bop->getOperand(0))) { - if (!IgnoreZeroSign) - IgnoreZeroSign = cast(V)->hasNoSignedZeros(); - return !IgnoreZeroSign ? C->isNegativeZeroValue() : C->isZeroValue(); - } - return false; -} - -Value *BinaryOperator::getFNegArgument(Value *BinOp) { - return cast(BinOp)->getOperand(1); -} - -const Value *BinaryOperator::getFNegArgument(const Value *BinOp) { - return getFNegArgument(const_cast(BinOp)); -} - // Exchange the two operands to this instruction. This instruction is safe to // use on any binary instruction and does not modify the semantics of the // instruction. If the instruction is order-dependent (SetLT f.e.), the opcode -- 2.7.4