From 0821f6f06f34146053356bf944d01aff086bb312 Mon Sep 17 00:00:00 2001 From: chrisnas Date: Sun, 2 Sep 2018 19:17:31 +0200 Subject: [PATCH] Add modules to the heap only dump in order to have: (#19761) + types in with sos.dumpheap -stat instead of UNKNOWN + complete stack with sos.dumpstack On a dual core machine, full=11GB, withheap=226MB, withheap(+patch)=269MB --- src/debug/createdump/crashinfo.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/debug/createdump/crashinfo.cpp b/src/debug/createdump/crashinfo.cpp index 8064691..6de6b94 100644 --- a/src/debug/createdump/crashinfo.cpp +++ b/src/debug/createdump/crashinfo.cpp @@ -197,6 +197,10 @@ CrashInfo::GatherCrashInfo(MINIDUMP_TYPE minidumpType) // Add all the heap (read/write) memory regions (m_otherMappings contains the heaps) else if (minidumpType & MiniDumpWithPrivateReadWriteMemory) { + for (const MemoryRegion& region : m_moduleMappings) + { + InsertMemoryBackedRegion(region); + } for (const MemoryRegion& region : m_otherMappings) { if (region.Permissions() == (PF_R | PF_W)) -- 2.7.4