From 08140dba0f539842d4836afb56fe43a33d8ba045 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 19 Apr 2020 17:02:32 -0600 Subject: [PATCH] travis: Correct error checking when building boards At present if buildman reports an error, the travis build still succeeds. This is because the travis script does not stop when it sees errors; nor does it automatically return the exit code. Also the current error checking never triggers since 'ret' is not set. Fix this by setting 'ret' correctly. Signed-off-by: Simon Glass Reported-by: Michal Simek Acked-by: Michal Simek --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index de96b0e..82e3b91 100644 --- a/.travis.yml +++ b/.travis.yml @@ -217,7 +217,8 @@ script: # # Build a selection of boards if TEST_PY_BD is empty - if [[ "${BUILDMAN}" != "" ]]; then - tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE}; + ret=0 + tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?; if [[ $ret -ne 0 ]]; then tools/buildman/buildman -seP ${BUILDMAN}; exit $ret; -- 2.7.4