From 080a61c21b5e2164c842cc73e33e1f4f3b41805a Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Sun, 9 Feb 2014 07:24:41 +0000 Subject: [PATCH] Clarify comment. Remove braces from single-statement block. llvm-svn: 201040 --- clang/lib/Sema/SemaDecl.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index dd059bb..b42b502 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -6979,11 +6979,11 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC, if (!NewFD->isInvalidDecl() && !NewFD->hasAttr() && Ret && Ret->hasAttr()) { const CXXMethodDecl *MD = dyn_cast(NewFD); - // Attach the attribute to the new decl. Don't apply the attribute if it - // returns an instance of the class (e.g. assignment operators). - if (!MD || MD->getParent() != Ret) { + // Attach WarnUnusedResult to functions returning types with that attribute. + // Don't apply the attribute to that type's own non-static member functions + // (to avoid warning on things like assignment operators) + if (!MD || MD->getParent() != Ret) NewFD->addAttr(WarnUnusedResultAttr::CreateImplicit(Context)); - } } if (getLangOpts().OpenCL) { -- 2.7.4