From 08063f85a7eadb1e54d0a03e0307bf15319513e8 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Wed, 5 Aug 2020 19:01:17 -0700 Subject: [PATCH] "|" used when "||" was meant in SBTarget::FindFunctions --- lldb/source/API/SBTarget.cpp | 2 +- lldb/test/API/python_api/target/TestTargetAPI.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lldb/source/API/SBTarget.cpp b/lldb/source/API/SBTarget.cpp index 04540a2..34cab62 100644 --- a/lldb/source/API/SBTarget.cpp +++ b/lldb/source/API/SBTarget.cpp @@ -1791,7 +1791,7 @@ lldb::SBSymbolContextList SBTarget::FindFunctions(const char *name, (const char *, uint32_t), name, name_type_mask); lldb::SBSymbolContextList sb_sc_list; - if (!name | !name[0]) + if (!name || !name[0]) return LLDB_RECORD_RESULT(sb_sc_list); TargetSP target_sp(GetSP()); diff --git a/lldb/test/API/python_api/target/TestTargetAPI.py b/lldb/test/API/python_api/target/TestTargetAPI.py index 5bdbf90..7db5388 100644 --- a/lldb/test/API/python_api/target/TestTargetAPI.py +++ b/lldb/test/API/python_api/target/TestTargetAPI.py @@ -283,6 +283,10 @@ class TargetAPITestCase(TestBase): target = self.dbg.CreateTarget(exe) self.assertTrue(target, VALID_TARGET) + # Try it with a null name: + list = target.FindFunctions(None, lldb.eFunctionNameTypeAuto) + self.assertTrue(list.GetSize() == 0) + list = target.FindFunctions('c', lldb.eFunctionNameTypeAuto) self.assertTrue(list.GetSize() == 1) -- 2.7.4