From 07efe6f129956d0cce0fb167d08b5f8af25d0c95 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 20 Apr 2022 09:45:51 -0400 Subject: [PATCH] zink: only reject non-blittable resource creation if it has no other binds the idea here is that if a resource is intended to be used solely as a rendertarget and can't be blitted to or drawn to, then resource creation should fail but if the resource might be e.g., a texture, then it can probably hit the subdata path and be fine Fixes: 37ac8647fca ("zink: reject resource creation if format features don't match attachment") Reviewed-by: Dave Airlie Part-of: --- src/gallium/drivers/zink/zink_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/zink/zink_resource.c b/src/gallium/drivers/zink/zink_resource.c index 442a471..0bb1d1c 100644 --- a/src/gallium/drivers/zink/zink_resource.c +++ b/src/gallium/drivers/zink/zink_resource.c @@ -258,7 +258,7 @@ get_image_usage_for_feats(struct zink_screen *screen, VkFormatFeatureFlags feats usage |= VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT; if ((bind & (PIPE_BIND_LINEAR | PIPE_BIND_SHARED)) != (PIPE_BIND_LINEAR | PIPE_BIND_SHARED)) usage |= VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT; - } else if (templ->nr_samples || !(feats & VK_FORMAT_FEATURE_BLIT_DST_BIT)) + } else if (templ->nr_samples || (bind == PIPE_BIND_RENDER_TARGET && !(feats & VK_FORMAT_FEATURE_BLIT_DST_BIT))) /* this can't be populated, so we can't do it */ return 0; } -- 2.7.4