From 07b264d1f02f4ee3a8db30f2a146c455cdccb751 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Sat, 1 Jan 2022 02:01:41 +0000 Subject: [PATCH] Pass the LLVMTypeConverter by reference in UnrankedMemRefBuilder (NFC) This is a fairly large structure (952B according to Coverity), it was already passed by reference in most places but not consistently. --- mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h | 2 +- mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h b/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h index 8f755d5..26c9df2 100644 --- a/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h +++ b/mlir/include/mlir/Conversion/LLVMCommon/MemRefBuilder.h @@ -219,7 +219,7 @@ public: LLVM::LLVMPointerType elemPtrPtrType); /// Builds IR extracting the size[index] from the descriptor. static Value size(OpBuilder &builder, Location loc, - LLVMTypeConverter typeConverter, Value sizeBasePtr, + LLVMTypeConverter &typeConverter, Value sizeBasePtr, Value index); /// Builds IR inserting the size[index] into the descriptor. static void setSize(OpBuilder &builder, Location loc, diff --git a/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp b/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp index edb43b3..4f78461 100644 --- a/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp +++ b/mlir/lib/Conversion/LLVMCommon/MemRefBuilder.cpp @@ -478,7 +478,7 @@ Value UnrankedMemRefDescriptor::sizeBasePtr( } Value UnrankedMemRefDescriptor::size(OpBuilder &builder, Location loc, - LLVMTypeConverter typeConverter, + LLVMTypeConverter &typeConverter, Value sizeBasePtr, Value index) { Type indexPtrTy = LLVM::LLVMPointerType::get(typeConverter.getIndexType()); Value sizeStoreGep = builder.create(loc, indexPtrTy, sizeBasePtr, -- 2.7.4