From 07983a629ed899ea097826a07363a79a5233dd96 Mon Sep 17 00:00:00 2001 From: Sylwester Nawrocki Date: Thu, 12 Apr 2018 15:57:17 +0200 Subject: [PATCH] spi: spi-s3c64xx: Do not ignore timeout errors in polling I/O mode Currently timeout errors in polling I/O mode transfer are silently ignored. Fix it by returning an error when we time out waiting on the RX FIFO level to reach the transfer length. Change-Id: I39d663204880bb5a9c4d092c020912055078416c Signed-off-by: Sylwester Nawrocki --- drivers/spi/spi-s3c64xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index b8c4a92..57ce730 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -512,6 +512,8 @@ static int wait_for_pio(struct s3c64xx_spi_driver_data *sdd, status = readl(regs + S3C64XX_SPI_STATUS); } while (RX_FIFO_LVL(status, sdd) < xfer->len && --val); + if (!val) + return -EIO; /* If it was only Tx */ if (!xfer->rx_buf) { -- 2.7.4