From 07819ee2186388852cc24d8618bbb49d5241ae53 Mon Sep 17 00:00:00 2001 From: Ramachandra Sudarshan N Date: Tue, 27 Dec 2011 20:24:06 +0530 Subject: [PATCH] [PORT FROM R2] mid_pmu: fix klockwork issues BZ: 18375 This patch fixes following klockwork issues: function 'strncpy' may incorrectly check buffer boundaries and may overflow buffer 'valcp' of fixed size (5) linux-2.6/arch/x86/platform/mfld/pmu.c:491 | set_extended_cstate_mode() function 'strncpy' may incorrectly check buffer boundaries and may overflow buffer 'valcp' of fixed size (4) linux-2.6/arch/x86/platform/mfld/pmu.c:578 | set_pmu_driver_status() Change-Id: Icead563c02b57b122a676c490e8cf134928595a3 Orig-Change-Id: I41a62d195a5155fafde5320fe014bd0bf123514c Signed-off-by: Sudarshan Ramachandra Reviewed-on: http://android.intel.com:8080/30277 Reviewed-by: Martin, LoicX Reviewed-by: Mansoor, Illyas Tested-by: Martin, LoicX Reviewed-by: buildbot Tested-by: buildbot --- arch/x86/platform/mfld/pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/platform/mfld/pmu.c b/arch/x86/platform/mfld/pmu.c index 45fde47..f0239a5 100755 --- a/arch/x86/platform/mfld/pmu.c +++ b/arch/x86/platform/mfld/pmu.c @@ -489,7 +489,7 @@ static int set_extended_cstate_mode(const char *val, struct kernel_param *kp) char valcp[5]; int cstate_mode; - strncpy(valcp, val, 5); + strncpy(valcp, val, sizeof(valcp) - 1); valcp[4] = '\0'; if (strcmp(valcp, "s0i1") == 0) @@ -576,7 +576,7 @@ static int set_pmu_driver_status(const char *val, struct kernel_param *kp) int status; struct pmu_ss_states cur_pmssc; - strncpy(valcp, val, 4); + strncpy(valcp, val, sizeof(valcp) - 1); valcp[3] = '\0'; if (strncmp(valcp, "off", 3) == 0) { /* disable pmu driver and -- 2.7.4