From 075897292fd94e43175c39218f0f742bee64232f Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 23 Oct 2018 17:20:16 +0000 Subject: [PATCH] [PDB] Fix -Wunused-private-field in DIA llvm-svn: 345054 --- llvm/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h | 6 +----- llvm/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h | 4 +--- llvm/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp | 9 ++++----- llvm/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp | 5 ++--- llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp | 2 +- 5 files changed, 9 insertions(+), 17 deletions(-) diff --git a/llvm/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h b/llvm/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h index e17ba2c..f3b02f0 100644 --- a/llvm/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h +++ b/llvm/include/llvm/DebugInfo/PDB/DIA/DIAEnumFrameData.h @@ -17,12 +17,9 @@ namespace llvm { namespace pdb { -class DIASession; - class DIAEnumFrameData : public IPDBEnumChildren { public: - explicit DIAEnumFrameData(const DIASession &PDBSession, - CComPtr DiaEnumerator); + explicit DIAEnumFrameData(CComPtr DiaEnumerator); uint32_t getChildCount() const override; ChildTypePtr getChildAtIndex(uint32_t Index) const override; @@ -30,7 +27,6 @@ public: void reset() override; private: - const DIASession &Session; CComPtr Enumerator; }; diff --git a/llvm/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h b/llvm/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h index 7564c3b..0ce6cfc 100644 --- a/llvm/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h +++ b/llvm/include/llvm/DebugInfo/PDB/DIA/DIAFrameData.h @@ -20,8 +20,7 @@ class DIASession; class DIAFrameData : public IPDBFrameData { public: - explicit DIAFrameData(const DIASession &PDBSession, - CComPtr DiaFrameData); + explicit DIAFrameData(CComPtr DiaFrameData); uint32_t getAddressOffset() const override; uint32_t getAddressSection() const override; @@ -31,7 +30,6 @@ public: uint64_t getVirtualAddress() const override; private: - const DIASession &Session; CComPtr FrameData; }; diff --git a/llvm/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp b/llvm/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp index 7751448..f873f35 100644 --- a/llvm/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp +++ b/llvm/lib/DebugInfo/PDB/DIA/DIAEnumFrameData.cpp @@ -13,9 +13,8 @@ using namespace llvm::pdb; -DIAEnumFrameData::DIAEnumFrameData(const DIASession &PDBSession, - CComPtr DiaEnumerator) - : Session(PDBSession), Enumerator(DiaEnumerator) {} +DIAEnumFrameData::DIAEnumFrameData(CComPtr DiaEnumerator) + : Enumerator(DiaEnumerator) {} uint32_t DIAEnumFrameData::getChildCount() const { LONG Count = 0; @@ -28,7 +27,7 @@ DIAEnumFrameData::getChildAtIndex(uint32_t Index) const { if (S_OK != Enumerator->Item(Index, &Item)) return nullptr; - return std::unique_ptr(new DIAFrameData(Session, Item)); + return std::unique_ptr(new DIAFrameData(Item)); } std::unique_ptr DIAEnumFrameData::getNext() { @@ -37,7 +36,7 @@ std::unique_ptr DIAEnumFrameData::getNext() { if (S_OK != Enumerator->Next(1, &Item, &NumFetched)) return nullptr; - return std::unique_ptr(new DIAFrameData(Session, Item)); + return std::unique_ptr(new DIAFrameData(Item)); } void DIAEnumFrameData::reset() { Enumerator->Reset(); } diff --git a/llvm/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp b/llvm/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp index b904a2f..533cce7 100644 --- a/llvm/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp +++ b/llvm/lib/DebugInfo/PDB/DIA/DIAFrameData.cpp @@ -13,9 +13,8 @@ using namespace llvm::pdb; -DIAFrameData::DIAFrameData(const DIASession &PDBSession, - CComPtr DiaFrameData) - : Session(PDBSession), FrameData(DiaFrameData) {} +DIAFrameData::DIAFrameData(CComPtr DiaFrameData) + : FrameData(DiaFrameData) {} template ArgType diff --git a/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp b/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp index b89ca9a..bd375e1 100644 --- a/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp +++ b/llvm/lib/DebugInfo/PDB/DIA/DIASession.cpp @@ -428,5 +428,5 @@ DIASession::getFrameData() const { if (!FD) return nullptr; - return llvm::make_unique(*this, FD); + return llvm::make_unique(FD); } -- 2.7.4