From 070fe95d07c78349f0c8f0fa90aeb92d05248483 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 23 Jul 2015 12:41:38 +0930 Subject: [PATCH] Fix ubsan signed integer overflow IMO a fairly useless warning in this case, but technically correct. PR 18708 * i386-dis.c (get64): Avoid signed integer overflow. --- opcodes/ChangeLog | 7 ++++++- opcodes/i386-dis.c | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 6ba1b85..f1ec2b0 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,8 @@ +2015-07-23 Alan Modra + + PR 18708 + * i386-dis.c (get64): Avoid signed integer overflow. + 2015-07-22 Alexander Fomin PR binutils/18631 @@ -82,7 +87,7 @@ 2015-06-19 Peter Bergner - * ppc-dis.h (skip_optional_operands): Use ppc_optional_operand_value. + * ppc-dis.h (skip_optional_operands): Use ppc_optional_operand_value. * ppc-opc.c (FXM4): Add non-zero optional value. (TBR): Likewise. (SXL): Likewise. diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index e768029..a279b56 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -15387,11 +15387,11 @@ get64 (void) a = *codep++ & 0xff; a |= (*codep++ & 0xff) << 8; a |= (*codep++ & 0xff) << 16; - a |= (*codep++ & 0xff) << 24; + a |= (*codep++ & 0xffu) << 24; b = *codep++ & 0xff; b |= (*codep++ & 0xff) << 8; b |= (*codep++ & 0xff) << 16; - b |= (*codep++ & 0xff) << 24; + b |= (*codep++ & 0xffu) << 24; x = a + ((bfd_vma) b << 32); #else abort (); -- 2.7.4