From 06ff46d2d77feba285e672e2da42039c88dc965a Mon Sep 17 00:00:00 2001 From: Slava Gurevich Date: Fri, 5 Aug 2022 21:27:28 -0700 Subject: [PATCH] [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry() Current application of bitwise-OR to a binary mask always results in True, which seems inconsistent with the intent of the statement, a likely typo. Differential Revision: https://reviews.llvm.org/D131312 --- lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp b/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp index b19d8b7..de6d500 100644 --- a/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp +++ b/lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp @@ -63,7 +63,7 @@ static void PrintBTEntry(lldb::addr_t lbound, lldb::addr_t ubound, const lldb::addr_t one_cmpl64 = ~((lldb::addr_t)0); const lldb::addr_t one_cmpl32 = ~((uint32_t)0); - if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) { + if ((lbound == one_cmpl64 || lbound == one_cmpl32) && ubound == 0) { result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value); } else { result.Printf(" lbound = 0x%" PRIu64 ",", lbound); -- 2.7.4