From 06fa67dc0a5f0faaacb085b096521f5a8aeb4da8 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Sun, 20 Mar 2022 09:31:52 +0000 Subject: [PATCH] [X86] Add test add with bit0 extraction and improve comments Based on feedback from D122084 --- llvm/test/CodeGen/X86/add-sub-bool.ll | 32 +++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/llvm/test/CodeGen/X86/add-sub-bool.ll b/llvm/test/CodeGen/X86/add-sub-bool.ll index 803be2c..824726b 100644 --- a/llvm/test/CodeGen/X86/add-sub-bool.ll +++ b/llvm/test/CodeGen/X86/add-sub-bool.ll @@ -3,10 +3,12 @@ ; RUN: llc < %s -mtriple=x86_64-unknown | FileCheck %s --check-prefixes=X64,NOTBM ; RUN: llc < %s -mtriple=x86_64-unknown -mattr=+tbm | FileCheck %s --check-prefixes=X64,TBM -; PR35908 - Fold ADD/SUB and bit tests into ADC/SBB+BT +; PR35908 - Fold ADD/SUB and bit extracts into ADC/SBB+BT ; -; int test_add(int x, int y, int z) { return (bool(z & (1 << 30)) + x + y); } -; int test_sub(int x, int y, int z) { return (bool(z & (1 << 30)) - x - y); } +; int test_add_add(int x, int y, int z) { return ((x + y) + bool(z & (1 << 30))); } +; int test_add_sub(int x, int y, int z) { return ((x - y) + bool(z & (1 << 30))); } +; int test_sub_add(int x, int y, int z) { return ((x + y) - bool(z & (1 << 30))); } +; int test_sub_sub(int x, int y, int z) { return (x - (y - bool(z & (1 << 30)))); } ; ; Constant Bit Indices @@ -84,6 +86,30 @@ define i32 @test_i32_add_add_commute_idx(i32 %x, i32 %y, i32 %z) { ret i32 %add1 } +define i32 @test_i32_add_add_idx0(i32 %x, i32 %y, i32 %z) { +; X86-LABEL: test_i32_add_add_idx0: +; X86: # %bb.0: +; X86-NEXT: movl {{[0-9]+}}(%esp), %eax +; X86-NEXT: movl {{[0-9]+}}(%esp), %ecx +; X86-NEXT: addl {{[0-9]+}}(%esp), %ecx +; X86-NEXT: andl $1, %eax +; X86-NEXT: addl %ecx, %eax +; X86-NEXT: retl +; +; X64-LABEL: test_i32_add_add_idx0: +; X64: # %bb.0: +; X64-NEXT: # kill: def $esi killed $esi def $rsi +; X64-NEXT: # kill: def $edi killed $edi def $rdi +; X64-NEXT: leal (%rdi,%rsi), %eax +; X64-NEXT: andl $1, %edx +; X64-NEXT: addl %edx, %eax +; X64-NEXT: retq + %add = add i32 %y, %x + %mask = and i32 %z, 1 + %add1 = add i32 %mask, %add + ret i32 %add1 +} + define i32 @test_i32_add_sub_idx(i32 %x, i32 %y, i32 %z) { ; X86-LABEL: test_i32_add_sub_idx: ; X86: # %bb.0: -- 2.7.4