From 06b1fa1a21d2cf2210cc881764b18e8de21c7b96 Mon Sep 17 00:00:00 2001 From: Jakob Botsch Nielsen Date: Thu, 23 Aug 2018 23:47:18 +0200 Subject: [PATCH] Make clang happy and fix old comment Commit migrated from https://github.com/dotnet/coreclr/commit/f633cf2f65800d27f308a7e85ca58c7b954cb1a7 --- src/coreclr/src/jit/emitxarch.cpp | 2 ++ src/coreclr/src/jit/morph.cpp | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/coreclr/src/jit/emitxarch.cpp b/src/coreclr/src/jit/emitxarch.cpp index c8af313..b71f914 100644 --- a/src/coreclr/src/jit/emitxarch.cpp +++ b/src/coreclr/src/jit/emitxarch.cpp @@ -3585,6 +3585,8 @@ void emitter::emitInsRMW(instruction ins, emitAttr attr, GenTreeStoreInd* storeI case INS_sar_N: iconVal &= 0x7F; break; + default: + break; } id = emitNewInstrAmdCns(attr, offset, iconVal); diff --git a/src/coreclr/src/jit/morph.cpp b/src/coreclr/src/jit/morph.cpp index f1d5195..8e76c06 100644 --- a/src/coreclr/src/jit/morph.cpp +++ b/src/coreclr/src/jit/morph.cpp @@ -13108,7 +13108,7 @@ DONE_MORPHING_CHILDREN: // The type of the new GT_NEG node cannot just be op1->TypeGet(). // Otherwise we may sign-extend incorrectly in cases where the GT_NEG // node ends up feeding directly a cast, for example in - // GT_CAST(GT_MUL(-1, s_1.ubyte) + // GT_CAST(GT_MUL(-1, s_1.ubyte)) tree->gtOp.gtOp1 = op1 = gtNewOperNode(GT_NEG, genActualType(op1->TypeGet()), op1); fgMorphTreeDone(op1); } -- 2.7.4