From 0685ec767ce641baaf3ac8d5e24b1e68ab1b110b Mon Sep 17 00:00:00 2001 From: James Zern Date: Sat, 3 Mar 2018 12:47:24 -0800 Subject: [PATCH] disable vp9_iht8x8_64_add_neon this causes test vector failures BUG=webm:1403 Change-Id: I7d37a05fbf4641ea352c947053aa4eaeb7f5c318 --- test/dct_test.cc | 4 ++-- test/fdct8x8_test.cc | 4 +++- vp9/common/vp9_rtcd_defs.pl | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/test/dct_test.cc b/test/dct_test.cc index a1440ca..42e22a1 100644 --- a/test/dct_test.cc +++ b/test/dct_test.cc @@ -635,10 +635,10 @@ static const FuncInfo ht_neon_func_info[] = { 2 }, #endif { &vp9_fht4x4_c, &iht_wrapper, 4, 1 }, - { &vp9_fht8x8_c, &iht_wrapper, 8, 1 }, -// TODO(linfengz): reenable this function once test vector failures are +// TODO(linfengz): reenable these functions once test vector failures are // addressed. #if 0 + { &vp9_fht8x8_c, &iht_wrapper, 8, 1 }, { &vp9_fht16x16_c, &iht_wrapper, 16, 1 } #endif }; diff --git a/test/fdct8x8_test.cc b/test/fdct8x8_test.cc index 5021dda..15033db 100644 --- a/test/fdct8x8_test.cc +++ b/test/fdct8x8_test.cc @@ -675,7 +675,9 @@ INSTANTIATE_TEST_CASE_P(NEON, FwdTrans8x8DCT, ::testing::Values(make_tuple(&vpx_fdct8x8_neon, &vpx_idct8x8_64_add_neon, 0, VPX_BITS_8))); -#if !CONFIG_VP9_HIGHBITDEPTH +// TODO(linfengz): reenable these functions once test vector failures are +// addressed. +#if 0 // !CONFIG_VP9_HIGHBITDEPTH INSTANTIATE_TEST_CASE_P( NEON, FwdTrans8x8HT, ::testing::Values( diff --git a/vp9/common/vp9_rtcd_defs.pl b/vp9/common/vp9_rtcd_defs.pl index 5dbe5a6..3e3979b 100644 --- a/vp9/common/vp9_rtcd_defs.pl +++ b/vp9/common/vp9_rtcd_defs.pl @@ -68,7 +68,7 @@ if (vpx_config("CONFIG_EMULATE_HARDWARE") ne "yes") { # Note that there are more specializations appended when # CONFIG_VP9_HIGHBITDEPTH is off. specialize qw/vp9_iht4x4_16_add neon sse2/; - specialize qw/vp9_iht8x8_64_add neon sse2/; + specialize qw/vp9_iht8x8_64_add sse2/; specialize qw/vp9_iht16x16_256_add sse2/; if (vpx_config("CONFIG_VP9_HIGHBITDEPTH") ne "yes") { # Note that these specializations are appended to the above ones. -- 2.7.4