From 0661480029f1f9be9c542893285d9fe68f0f0115 Mon Sep 17 00:00:00 2001 From: Caio Marcelo de Oliveira Filho Date: Fri, 23 Aug 2019 07:57:13 -0700 Subject: [PATCH] compiler/glsl: Fix warning about unused function The helper check_node_type() is only used when DEBUG is set (in the function below), but ASSERTED macro uses NDEBUG. So just guard the helper with #ifdef. If we see more such cases we might consider a ASSERTED-like macro for the DEBUG case. Reviewed-by: Eric Engestrom Reviewed-by: Jason Ekstrand --- src/compiler/glsl/ir_validate.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ir_validate.cpp b/src/compiler/glsl/ir_validate.cpp index 9be4e72..dea98f2 100644 --- a/src/compiler/glsl/ir_validate.cpp +++ b/src/compiler/glsl/ir_validate.cpp @@ -1052,7 +1052,8 @@ ir_validate::validate_ir(ir_instruction *ir, void *data) _mesa_set_add(ir_set, ir); } -ASSERTED static void +#ifdef DEBUG +static void check_node_type(ir_instruction *ir, void *data) { (void) data; @@ -1065,6 +1066,7 @@ check_node_type(ir_instruction *ir, void *data) if (value != NULL) assert(value->type != glsl_type::error_type); } +#endif void validate_ir_tree(exec_list *instructions) -- 2.7.4