From 06523518996c0ee9b1064e45824f10dd36d5ccfe Mon Sep 17 00:00:00 2001 From: Alexander Kanavin Date: Fri, 5 Aug 2011 17:57:14 +0300 Subject: [PATCH] Allow interactive tests and add mention of agents in HACKING --- HACKING | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/HACKING b/HACKING index 369195a..b147968 100644 --- a/HACKING +++ b/HACKING @@ -7,11 +7,12 @@ functionality patterns that are already there. There are patterns for getting and setting oFono properties, calling methods and getting the method call result, setting the errors, and receiving out-of-band signals. Hopefully that should be enough for any remaining APIs which are currently -missing. +missing (some APIs such as SIM toolkit require implementing a d-bus agent for +which there is no example yet). For any new API that is added, there should also be a test case. Again, try to imitate existing test cases. It is not necessary to thoroughly test the functionality; it is enough to go through all properties, methods and signals and check that they work, return sane values and match the actual oFono API. -The tests should be written against Phonesim phone simulator and they should -be able to run without manual intervention. +The tests should be written against Phonesim phone simulator and it's +preferred that they should be able to run without manual intervention. -- 2.7.4