From 0634e2589b1ab56dd275635128b6f38d44e853e4 Mon Sep 17 00:00:00 2001 From: greatim Date: Fri, 11 Nov 2016 15:10:54 +0900 Subject: [PATCH] Fixed SVACE issue Fixed SVACE issue Change-Id: Ia5f7ee4c56ae82702809ff0d69eb229594647a1f Signed-off-by: greatim --- src/default_plugin_appcmd.c | 7 ++++++- src/file_sync_service.c | 3 ++- src/parameter.h | 2 +- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/default_plugin_appcmd.c b/src/default_plugin_appcmd.c index 947a8e5..3fd2f64 100644 --- a/src/default_plugin_appcmd.c +++ b/src/default_plugin_appcmd.c @@ -656,7 +656,12 @@ static void run_appcmd_appinstallpath(appcmd_info* p_info) { static void run_appcmd_with_shell_process(appcmd_info* p_info) { int ret = -1; - if (p_info == NULL || p_info->gen_cmd_func == NULL) { + if (p_info == NULL) { + D("Invalid arguments. p_info is null\n"); + return; + } + + if (p_info->gen_cmd_func == NULL) { D("Invalid arguments.\n"); p_info->exitcode = -1; return; diff --git a/src/file_sync_service.c b/src/file_sync_service.c index ffaf0bc..6c418a5 100644 --- a/src/file_sync_service.c +++ b/src/file_sync_service.c @@ -713,6 +713,8 @@ void file_sync_service(int fd, void *cookie) goto fail; } } + } else { + sdb_close(s[1]); } @@ -723,6 +725,5 @@ fail: D("sync: done\n"); sync_send_label_notify(s[0], name, 0); sdb_close(s[0]); - sdb_close(s[1]); sdb_close(fd); } diff --git a/src/parameter.h b/src/parameter.h index ea15996..5d9276c 100644 --- a/src/parameter.h +++ b/src/parameter.h @@ -79,7 +79,7 @@ static __inline__ void make_string_parameter ( parameter* pstring, const char* f pstring->type = type_string; pstring->v_string.length = strlen ( buf ); pstring->v_string.data = ( char* ) malloc ( pstring->v_string.length + 1 ); - strcpy ( pstring->v_string.data, buf ); + strncpy ( pstring->v_string.data, buf, pstring->v_string.length ); } static __inline__ void release_parameters ( parameters* param ) -- 2.7.4