From 05fd66e00548312b7e167c3e09ea68d4a1391f4f Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 2 May 2019 16:32:27 +0200 Subject: [PATCH] Disable flaky Dns GetHostName tests on OSX (dotnet/corefx#37363) Commit migrated from https://github.com/dotnet/corefx/commit/ef02cf17b5cdb57d5277b158cd3afba047df4d1b --- .../tests/FunctionalTests/GetHostByNameTest.cs | 2 ++ .../System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs index 1ad3089..0e12894 100644 --- a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs +++ b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs @@ -102,6 +102,7 @@ namespace System.Net.NameResolution.Tests Assert.Equal(IPAddress.IPv6Loopback, entry.AddressList[0]); } + [ActiveIssue(37362, TestPlatforms.OSX)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(32797)] public void DnsObsoleteGetHostByName_EmptyString_ReturnsHostName() { @@ -111,6 +112,7 @@ namespace System.Net.NameResolution.Tests Assert.Contains(Dns.GetHostName(), entry.HostName, StringComparison.OrdinalIgnoreCase); } + [ActiveIssue(37362, TestPlatforms.OSX)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(32797)] public void DnsObsoleteBeginEndGetHostByName_EmptyString_ReturnsHostName() { diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs index 8b2a21d..92aa016 100644 --- a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs +++ b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs @@ -20,11 +20,13 @@ namespace System.Net.NameResolution.Tests await TestGetHostEntryAsync(() => Dns.GetHostEntryAsync(localIPAddress)); } + [ActiveIssue(37362, TestPlatforms.OSX)] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(32797)] [InlineData("")] [InlineData(TestSettings.LocalHost)] public Task Dns_GetHostEntry_HostString_Ok(string hostName) => TestGetHostEntryAsync(() => Task.FromResult(Dns.GetHostEntry(hostName))); + [ActiveIssue(37362, TestPlatforms.OSX)] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process))] // [ActiveIssue(32797)] [InlineData("")] [InlineData(TestSettings.LocalHost)] -- 2.7.4