From 05ad541534d4e3d1a05bcf422b9478f77ce6be0d Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Mon, 8 Aug 2016 16:58:16 +0900 Subject: [PATCH] elm dbus menu - handle return value of eldbus_message_iter_arguments_get handle possible error return of eldbus_message_iter_arguments_get() according to coverity CID 1353591. this should fix that. --- src/lib/elementary/elm_dbus_menu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elm_dbus_menu.c b/src/lib/elementary/elm_dbus_menu.c index 31078bf..13fab00 100644 --- a/src/lib/elementary/elm_dbus_menu.c +++ b/src/lib/elementary/elm_dbus_menu.c @@ -401,8 +401,9 @@ _event_handle(Elm_DBus_Menu *dbus_menu, Eldbus_Message_Iter *iter, int *error_id Eldbus_Message_Iter *data; unsigned *timestamp; - eldbus_message_iter_arguments_get(iter, "isvu", &id, &event, &data, - ×tamp); + if (!eldbus_message_iter_arguments_get(iter, "isvu", &id, &event, &data, + ×tamp)) + return EINA_FALSE; i = id; item = eina_hash_find(dbus_menu->elements, &i); if (!item) -- 2.7.4