From 05a9e344ee35f3b5989df5b95c80a2955389cbbb Mon Sep 17 00:00:00 2001 From: georgerim Date: Sat, 26 Oct 2019 14:52:12 +0300 Subject: [PATCH] [YAMLTraits] - Revert a change committed by a mistake in D68983 I've accidentally reverted one of my previous patches. It was not catched by bots because (I guess) they do not build in debug (we have a test case which triggers an assert in MSVS when runs without this change). More info: https://reviews.llvm.org/D68983#inline-624235 Reported by Jordan Rupprecht. --- llvm/include/llvm/Support/YAMLTraits.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/llvm/include/llvm/Support/YAMLTraits.h b/llvm/include/llvm/Support/YAMLTraits.h index 656020e..a3bfa7d 100644 --- a/llvm/include/llvm/Support/YAMLTraits.h +++ b/llvm/include/llvm/Support/YAMLTraits.h @@ -649,7 +649,8 @@ inline bool isBool(StringRef S) { inline QuotingType needsQuotes(StringRef S) { if (S.empty()) return QuotingType::Single; - if (isspace(S.front()) || isspace(S.back())) + if (isspace(static_cast(S.front())) || + isspace(static_cast(S.back()))) return QuotingType::Single; if (isNull(S)) return QuotingType::Single; -- 2.7.4