From 052b0a1caf2cc1768de81c368e7f3371e77e8e71 Mon Sep 17 00:00:00 2001 From: Lubosz Sarnecki Date: Mon, 20 Jul 2015 14:24:22 -0400 Subject: [PATCH] glimagesinkbin: Add allocation query for GstVideoOverlayComposition Adds an GST_VIDEO_OVERLAY_COMPOSITION_META_API_TYPE query to glupload and glimagesink. Detects the query from the downstream elements, so it is executed only when downstream supports the overlay API. This makes pipelines with textoverlay ! glupload ! gldownload ! xvimagesink possible. Uses allocation meta struct for passing the window size upstream. https://bugzilla.gnome.org/show_bug.cgi?id=745107 --- ext/gl/gstglimagesink.c | 13 +++++++++++++ ext/gl/gstgluploadelement.c | 19 +++++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/ext/gl/gstglimagesink.c b/ext/gl/gstglimagesink.c index 4120a89..bb1ee18 100644 --- a/ext/gl/gstglimagesink.c +++ b/ext/gl/gstglimagesink.c @@ -1519,6 +1519,7 @@ gst_glimage_sink_propose_allocation (GstBaseSink * bsink, GstQuery * query) GstCaps *caps; guint size; gboolean need_pool; + GstStructure *allocation_meta = NULL; if (!_ensure_gl_setup (glimage_sink)) return FALSE; @@ -1557,6 +1558,18 @@ gst_glimage_sink_propose_allocation (GstBaseSink * bsink, GstQuery * query) if (glimage_sink->context->gl_vtable->FenceSync) gst_query_add_allocation_meta (query, GST_GL_SYNC_META_API_TYPE, 0); + if (glimage_sink->window_width != 0 && glimage_sink->window_height != 0) { + allocation_meta = + gst_structure_new ("GstVideoOverlayCompositionMeta", + "width", G_TYPE_UINT, glimage_sink->window_width, + "height", G_TYPE_UINT, glimage_sink->window_height, NULL); + GST_DEBUG ("sending alloc query with size %dx%d", + glimage_sink->window_width, glimage_sink->window_height); + } + + gst_query_add_allocation_meta (query, + GST_VIDEO_OVERLAY_COMPOSITION_META_API_TYPE, allocation_meta); + return TRUE; /* ERRORS */ diff --git a/ext/gl/gstgluploadelement.c b/ext/gl/gstgluploadelement.c index 368c2c9..6ed3f1c 100644 --- a/ext/gl/gstgluploadelement.c +++ b/ext/gl/gstgluploadelement.c @@ -143,11 +143,30 @@ static gboolean _gst_gl_upload_element_propose_allocation (GstBaseTransform * bt, GstQuery * decide_query, GstQuery * query) { + guint alloc_index; + gboolean alloc_has_overlay_meta; GstGLUploadElement *upload = GST_GL_UPLOAD_ELEMENT (bt); if (!upload->upload) return FALSE; + alloc_has_overlay_meta = + gst_query_find_allocation_meta (decide_query, + GST_VIDEO_OVERLAY_COMPOSITION_META_API_TYPE, &alloc_index); + + if (alloc_has_overlay_meta) { + const GstStructure *params; + GST_DEBUG ("adding allocation meta in upload for textoverlay"); + + /* read window size from decide_query */ + gst_query_parse_nth_allocation_meta (decide_query, alloc_index, ¶ms); + + if (params) + gst_query_add_allocation_meta (query, + GST_VIDEO_OVERLAY_COMPOSITION_META_API_TYPE, params); + + } + gst_gl_upload_propose_allocation (upload->upload, decide_query, query); return TRUE; -- 2.7.4