From 0521ffd950c05c7b37a23e601c678a74f22c7a13 Mon Sep 17 00:00:00 2001 From: Jiyong Min Date: Wed, 23 Nov 2016 13:12:02 +0900 Subject: [PATCH] Fix bug reported by static analyzer - non-terminated C string by memcpy Change-Id: Ie7a1235aba20872373ee3257c3541b191e8bd53e Signed-off-by: Jiyong Min --- packaging/capi-media-controller.spec | 2 +- src/media_controller_util.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packaging/capi-media-controller.spec b/packaging/capi-media-controller.spec index 2f4f3ac..dcbdc05 100755 --- a/packaging/capi-media-controller.spec +++ b/packaging/capi-media-controller.spec @@ -1,6 +1,6 @@ Name: capi-media-controller Summary: A media controller library in Tizen Native API -Version: 0.1.28 +Version: 0.1.29 Release: 1 Group: Multimedia/API License: Apache-2.0 diff --git a/src/media_controller_util.c b/src/media_controller_util.c index 55310ff..fd72fc0 100755 --- a/src/media_controller_util.c +++ b/src/media_controller_util.c @@ -30,8 +30,9 @@ static void _mc_util_check_valid_name(const char *name, char **new_name) memset(old_word, 0, MAX_NAME_LENGTH); memset(new_word, 0, MAX_NAME_LENGTH); - if (strlen(name) > MAX_NAME_LENGTH) - memcpy(old_word, name, MAX_NAME_LENGTH); + /* It should have terminated C string, old-word should be limited to MAX_NAME_LENGTH - 1 */ + if (strlen(name) > MAX_NAME_LENGTH - 1) + memcpy(old_word, name, MAX_NAME_LENGTH - 1); else memcpy(old_word, name, strlen(name)); -- 2.7.4