From 051ad89c9c1639e0cc839ec6caf8f52dc94c0fdf Mon Sep 17 00:00:00 2001 From: =?utf8?q?Ville=20Syrj=C3=A4l=C3=A4?= Date: Wed, 21 Dec 2011 02:01:31 +0200 Subject: [PATCH] staging: mrst: Fix error handling in psbfb_create MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The two goto labels for unwinding on error were inverted. Swap them around. Fixes a smatch error: drivers/staging/mrst/drv/psb_fb.c:421 psbfb_create(82) error: we previously assumed 'fb' could be null (see line 368) (smatch) Signed-off-by: Ville Syrjälä Signed-off-by: Artem Bityutskiy --- drivers/staging/mrst/drv/psb_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mrst/drv/psb_fb.c b/drivers/staging/mrst/drv/psb_fb.c index 34185b1..5f14dfbb 100644 --- a/drivers/staging/mrst/drv/psb_fb.c +++ b/drivers/staging/mrst/drv/psb_fb.c @@ -417,9 +417,9 @@ static int psbfb_create(struct psb_fbdev * fbdev, struct drm_fb_helper_surface_s mutex_unlock(&dev->struct_mutex); return 0; -out_err0: - fb->funcs->destroy(fb); out_err1: + fb->funcs->destroy(fb); +out_err0: mutex_unlock(&dev->struct_mutex); return ret; } -- 2.7.4