From 049c366378284d7aa29142572e5d669b410b9193 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Sun, 26 Sep 2021 10:18:28 -0400 Subject: [PATCH] radeonsi: don't set DX10_DIAMOND_TEST_ENA for better performance Acked-by: Pierre-Eric Pelloux-Prayer Part-of: --- src/gallium/drivers/radeonsi/ci/traces-radeonsi.yml | 2 +- src/gallium/drivers/radeonsi/si_state.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/ci/traces-radeonsi.yml b/src/gallium/drivers/radeonsi/ci/traces-radeonsi.yml index bab64cd..b2e46f3 100644 --- a/src/gallium/drivers/radeonsi/ci/traces-radeonsi.yml +++ b/src/gallium/drivers/radeonsi/ci/traces-radeonsi.yml @@ -193,7 +193,7 @@ traces: - path: gputest/plot3d.trace expectations: - device: gl-radeonsi-stoney - checksum: 203c0c186a8eab5fbb8753ec25848b53 + checksum: a62be186a3e0a33ecbd520edd3873eb1 - path: gputest/tessmark.trace expectations: - device: gl-radeonsi-stoney diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 35b64de3..2f179e91 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/gallium/drivers/radeonsi/si_state.c @@ -3588,14 +3588,15 @@ static void si_emit_msaa_config(struct si_context *sctx) } } - /* Required by OpenGL line rasterization. + /* The DX10 diamond test is optional in GL and decreases line rasterization + * performance, so don't use it. * * TODO: We should also enable perpendicular endcaps for AA lines, * but that requires implementing line stippling in the pixel * shader. SC can only do line stippling with axis-aligned * endcaps. */ - unsigned sc_line_cntl = S_028BDC_DX10_DIAMOND_TEST_ENA(1); + unsigned sc_line_cntl = 0; unsigned sc_aa_config = 0; if (coverage_samples > 1) { -- 2.7.4