From 048e7f264b9e5e4d0d6e2df5c5337fe17eafd48e Mon Sep 17 00:00:00 2001 From: Ondrej Holy Date: Tue, 5 Sep 2017 08:58:37 +0200 Subject: [PATCH] orders: Fix ORDER_TYPE_GDIPLUS_END check Commit 6fd03ab introduced security checks for orders, but ORDER_TYPE_GDIPLUS_END check fails in case of success and vice versa. Let's add the missing question mark. https://github.com/FreeRDP/FreeRDP/issues/4117 --- libfreerdp/core/orders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libfreerdp/core/orders.c b/libfreerdp/core/orders.c index 2ee97e6..6c92ce5 100644 --- a/libfreerdp/core/orders.c +++ b/libfreerdp/core/orders.c @@ -3451,7 +3451,7 @@ static BOOL update_recv_altsec_order(rdpUpdate* update, wStream* s, break; case ORDER_TYPE_GDIPLUS_END: - if (update_read_draw_gdiplus_end_order(s, &(altsec->draw_gdiplus_end))) + if (!update_read_draw_gdiplus_end_order(s, &(altsec->draw_gdiplus_end))) { WLog_ERR(TAG, "ORDER_TYPE_GDIPLUS_END - update_read_draw_gdiplus_end_order() failed"); -- 2.7.4