From 0479e6b3999e41bb553cb2ae397630319e9b80dc Mon Sep 17 00:00:00 2001 From: WonYoung Choi Date: Tue, 8 Dec 2015 21:50:44 +0900 Subject: [PATCH] Fix using initCustomEvent() of CustomEvent CustomEvent.initCustomEvent() function is used with 3 arguments, fourth being optional. In chromium m47 IDL for CustomEvent.initCustomEvent() was changed, and now it requires all four arguments to be present. Calls with 3 arguments fail, and no event is received in a web application. --- extensions/internal/widget/widget_api.js | 2 +- runtime/browser/web_application.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/extensions/internal/widget/widget_api.js b/extensions/internal/widget/widget_api.js index 6fd7b69..6a5b7a6 100755 --- a/extensions/internal/widget/widget_api.js +++ b/extensions/internal/widget/widget_api.js @@ -16,7 +16,7 @@ var dispatchStorageEvent = function(key, oldValue, newValue) { var evt = document.createEvent("CustomEvent"); - evt.initCustomEvent("storage", true, true); + evt.initCustomEvent("storage", true, true, null); evt.key = key; evt.oldValue = oldValue; evt.newValue = newValue; diff --git a/runtime/browser/web_application.cc b/runtime/browser/web_application.cc index 6be84b1..9a82ade 100755 --- a/runtime/browser/web_application.cc +++ b/runtime/browser/web_application.cc @@ -63,7 +63,7 @@ const char* kPortKey = "port"; const char* kAppControlEventScript = "(function(){" "var __event = document.createEvent(\"CustomEvent\");\n" - "__event.initCustomEvent(\"appcontrol\", true, true);\n" + "__event.initCustomEvent(\"appcontrol\", true, true, null);\n" "document.dispatchEvent(__event);\n" "\n" "for (var i=0; i < window.frames.length; i++)\n" @@ -72,7 +72,7 @@ const char* kAppControlEventScript = const char* kBackKeyEventScript = "(function(){" "var __event = document.createEvent(\"CustomEvent\");\n" - "__event.initCustomEvent(\"tizenhwkey\", true, true);\n" + "__event.initCustomEvent(\"tizenhwkey\", true, true, null);\n" "__event.keyName = \"back\";\n" "document.dispatchEvent(__event);\n" "\n" @@ -82,7 +82,7 @@ const char* kBackKeyEventScript = const char* kMenuKeyEventScript = "(function(){" "var __event = document.createEvent(\"CustomEvent\");\n" - "__event.initCustomEvent(\"tizenhwkey\", true, true);\n" + "__event.initCustomEvent(\"tizenhwkey\", true, true, null);\n" "__event.keyName = \"menu\";\n" "document.dispatchEvent(__event);\n" "\n" -- 2.7.4