From 0446e35a14cf63233b2b4c1fcfa0f787bbf282d5 Mon Sep 17 00:00:00 2001 From: =?utf8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Tue, 16 Aug 2022 14:45:46 +0200 Subject: [PATCH] va: gst_va_create_raw_caps_from_config() may return NULL. This patch verifies if the function returns NULL in the caller. Part-of: --- subprojects/gst-plugins-bad/sys/va/gstvadecoder.c | 4 ++++ subprojects/gst-plugins-bad/sys/va/gstvaencoder.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c b/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c index 8948dd3..2917759 100644 --- a/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c +++ b/subprojects/gst-plugins-bad/sys/va/gstvadecoder.c @@ -415,6 +415,10 @@ gst_va_decoder_get_srcpad_caps (GstVaDecoder * self) if (gst_va_decoder_is_open (self)) { srcpad_caps = gst_va_create_raw_caps_from_config (self->display, self->config); + if (!srcpad_caps) { + GST_WARNING_OBJECT (self, "Invalid configuration caps"); + return NULL; + } gst_caps_replace (&self->srcpad_caps, srcpad_caps); gst_caps_unref (srcpad_caps); diff --git a/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c b/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c index 19d96c1..e5b7afe 100644 --- a/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c +++ b/subprojects/gst-plugins-bad/sys/va/gstvaencoder.c @@ -898,6 +898,10 @@ gst_va_encoder_get_sinkpad_caps (GstVaEncoder * self) if (gst_va_encoder_is_open (self)) { sinkpad_caps = gst_va_create_raw_caps_from_config (self->display, self->config); + if (!sinkpad_caps) { + GST_WARNING_OBJECT (self, "Invalid configuration caps"); + return NULL; + } gst_caps_replace (&self->sinkpad_caps, sinkpad_caps); gst_caps_unref (sinkpad_caps); -- 2.7.4