From 03e985f2372c6361535b844cd75d4e26b568af9d Mon Sep 17 00:00:00 2001 From: huiyueun <35286162+huiyueun@users.noreply.github.com> Date: Thu, 2 May 2019 14:41:08 +0900 Subject: [PATCH] [NUI] Fix build warnings (#806) * [NUI] Fix build warnings Signed-off-by: huiyu.eun * Update View.cs * Update View.cs * Update ToggleButton.cs --- .../src/internal/XamlBinding/NavigationPage.cs | 5 ----- .../internal/XamlBinding/RotationTypeConverter.cs | 14 +++++++------- src/Tizen.NUI/src/public/BaseComponents/View.cs | 1 + .../src/public/UIComponents/ToggleButton.cs | 1 + 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/Tizen.NUI/src/internal/XamlBinding/NavigationPage.cs b/src/Tizen.NUI/src/internal/XamlBinding/NavigationPage.cs index eef0cb8fc..d72def2a6 100755 --- a/src/Tizen.NUI/src/internal/XamlBinding/NavigationPage.cs +++ b/src/Tizen.NUI/src/internal/XamlBinding/NavigationPage.cs @@ -241,11 +241,6 @@ namespace Tizen.NUI /// public event EventHandler Popped; - /// - /// Event that is raised when the last nonroot element is popped from this NavigationPage element. - /// - public event EventHandler PoppedToRoot; - /// /// Pops all but the root Page off the navigation stack. /// diff --git a/src/Tizen.NUI/src/internal/XamlBinding/RotationTypeConverter.cs b/src/Tizen.NUI/src/internal/XamlBinding/RotationTypeConverter.cs index 4f48d72c6..9aa845452 100755 --- a/src/Tizen.NUI/src/internal/XamlBinding/RotationTypeConverter.cs +++ b/src/Tizen.NUI/src/internal/XamlBinding/RotationTypeConverter.cs @@ -7,10 +7,10 @@ namespace Tizen.NUI.Binding { public override object ConvertFromInvariantString(string value) { - /// public Rotation(Radian radian(float), Vector3 vector3) - /// Default: - /// Oritation="D:23, 0, 0, 1" - /// Oritation="R:23, 0, 0, 1" + // public Rotation(Radian radian(float), Vector3 vector3) + // Default: + // Oritation="D:23, 0, 0, 1" + // Oritation="R:23, 0, 0, 1" if (value != null) { string[] parts = value.Split(','); @@ -25,12 +25,12 @@ namespace Tizen.NUI.Binding string radianOrDegree = head[0].Trim().ToLowerInvariant(); if(radianOrDegree == "d" || radianOrDegree == "degree") { - /// Oritation="D:23, 0, 0, 1" + // Oritation="D:23, 0, 0, 1" radian = new Radian( new Degree( Single.Parse( head[1].Trim(), CultureInfo.InvariantCulture ) ) ); } else if (radianOrDegree == "r" || radianOrDegree == "radian") { - /// Oritation="R:23, 0, 0, 1" + // Oritation="R:23, 0, 0, 1" radian = new Radian( Single.Parse( head[1].Trim(), CultureInfo.InvariantCulture ) ); } else @@ -41,7 +41,7 @@ namespace Tizen.NUI.Binding if (useDefault) { - ///Default: + //Default: radian = new Radian( Single.Parse( parts[0].Trim(), CultureInfo.InvariantCulture ) ); } diff --git a/src/Tizen.NUI/src/public/BaseComponents/View.cs b/src/Tizen.NUI/src/public/BaseComponents/View.cs index 69033cbc2..f93c87ae4 100644 --- a/src/Tizen.NUI/src/public/BaseComponents/View.cs +++ b/src/Tizen.NUI/src/public/BaseComponents/View.cs @@ -227,6 +227,7 @@ namespace Tizen.NUI.BaseComponents return temp; }); + /// Only for XAML property binding. This will be changed as Inhouse API by ACR later. public static readonly BindableProperty FlexProperty = BindableProperty.Create("Flex", typeof(float), typeof(View), default(float), propertyChanged: (bindable, oldValue, newValue) => { var view = (View)bindable; diff --git a/src/Tizen.NUI/src/public/UIComponents/ToggleButton.cs b/src/Tizen.NUI/src/public/UIComponents/ToggleButton.cs index 54dd3a7bc..85f6f6a40 100755 --- a/src/Tizen.NUI/src/public/UIComponents/ToggleButton.cs +++ b/src/Tizen.NUI/src/public/UIComponents/ToggleButton.cs @@ -43,6 +43,7 @@ namespace Tizen.NUI return temp; }); + /// Only for XAML property binding. This will be changed as Inhouse API by ACR later. public static readonly BindableProperty TooltipsProperty = BindableProperty.Create("Tooltips", typeof(PropertyArray), typeof(ToggleButton), new PropertyArray(), propertyChanged: (bindable, oldValue, newValue) => { var toggleButton = (ToggleButton)bindable; -- 2.34.1