From 03a2388b609820fa046924fe64c714528d69e08d Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Thu, 3 Apr 2014 13:20:11 -0300 Subject: [PATCH] basesrc: removing duplicated inner if The inner if replicates the same code of the outer and is useless as flag_segment will always be true. Found by coverity. --- libs/gst/base/gstbasesrc.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/libs/gst/base/gstbasesrc.c b/libs/gst/base/gstbasesrc.c index be12c46..9f2e52c 100644 --- a/libs/gst/base/gstbasesrc.c +++ b/libs/gst/base/gstbasesrc.c @@ -2904,18 +2904,13 @@ pause: } else if (flag_segment) { GstMessage *message; - if (flag_segment) { - message = gst_message_new_segment_done (GST_OBJECT_CAST (src), - format, position); - gst_message_set_seqnum (message, src->priv->seqnum); - gst_element_post_message (GST_ELEMENT_CAST (src), message); - event = gst_event_new_segment_done (format, position); - } else { - event = gst_event_new_eos (); - gst_event_set_seqnum (event, src->priv->seqnum); - } - + message = gst_message_new_segment_done (GST_OBJECT_CAST (src), + format, position); + gst_message_set_seqnum (message, src->priv->seqnum); + gst_element_post_message (GST_ELEMENT_CAST (src), message); + event = gst_event_new_segment_done (format, position); gst_event_set_seqnum (event, src->priv->seqnum); + } else { event = gst_event_new_eos (); gst_event_set_seqnum (event, src->priv->seqnum); -- 2.7.4