From 03541141b97175287f276c44ef7f1818ec655ca7 Mon Sep 17 00:00:00 2001 From: Benedikt Meurer Date: Fri, 28 Aug 2015 12:20:29 +0200 Subject: [PATCH] [test] Properly disable test that doesn't work in GC stress. The magic "print(i)" work-around was no longer work-arounding correctly, so we do the right thing instead now. TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1306843004 . Cr-Commit-Position: refs/heads/master@{#30436} --- test/mjsunit/mjsunit.status | 3 +++ test/mjsunit/regress/regress-crbug-500497.js | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index 8e199946d..8f5382942 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -304,6 +304,9 @@ 'unicodelctest': [PASS, NO_VARIANTS], 'unicodelctest-no-optimization': [PASS, NO_VARIANTS], + # TODO(jkummerow): Doesn't work correctly in GC stress. + 'regress/regress-crbug-500497': [PASS, NO_VARIANTS], + # Too slow for gc stress. 'asm/embenchen/box2d': [SKIP], diff --git a/test/mjsunit/regress/regress-crbug-500497.js b/test/mjsunit/regress/regress-crbug-500497.js index 2d3d40f0f..9117440c2 100644 --- a/test/mjsunit/regress/regress-crbug-500497.js +++ b/test/mjsunit/regress/regress-crbug-500497.js @@ -13,9 +13,6 @@ function Ctor() { } for (var i = 0; i < 120; i++) { - // This print() is important! Without it, in --gc-stress mode, the function - // Ctor is optimized too early. No idea why. - print(i); // Make the "a" property long-lived, while everything else is short-lived. global.push(Ctor().a); (function FillNewSpace() { new Array(10000); })(); -- 2.34.1