From 0337f8ccacc381f0946c4fa90010a4956b8feb4f Mon Sep 17 00:00:00 2001 From: =?utf8?q?=EC=9D=B4=ED=95=9C=EC=A2=85/On-Device=20Lab=28SR=29/Enginee?= =?utf8?q?r/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= Date: Thu, 25 Jul 2019 09:30:17 +0900 Subject: [PATCH] Update ExecutorFactory comments (#5844) Update outdated comments in `ExecutorFactory.cc`. Signed-off-by: Hanjoung Lee --- runtimes/neurun/core/src/compiler/ExecutorFactory.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/runtimes/neurun/core/src/compiler/ExecutorFactory.cc b/runtimes/neurun/core/src/compiler/ExecutorFactory.cc index 0f413b2..6bebfbf 100644 --- a/runtimes/neurun/core/src/compiler/ExecutorFactory.cc +++ b/runtimes/neurun/core/src/compiler/ExecutorFactory.cc @@ -79,7 +79,10 @@ exec::IExecutor *ExecutorFactory::createLinearExecutor(graph::Graph &graph) // because SubTensorAnalyzer assume that insert permutation is already finished // lower: decide backend and insert permutation // fix shapes: prepare codegen to optimization - // finalize: generate tensor using subtensor info, then generate kernels + // generate tensor objects: generate tensor using subtensor info + // generate kernels + // allocate tesor memory + // constant intialization: fill the constants with values // Generated SubTensorInfo is in operand(Object) // for easy pass SubTensorInfo to plan builder and tensor builder linear->accept(SubTensorAnalyzer{graph.operands()}); @@ -143,7 +146,7 @@ exec::IExecutor *ExecutorFactory::createLinearExecutor(graph::Graph &graph) kernel_gen->generate(*element.subgraph, execution_builder.get()); }); - // Allocate Tensor Memory for cl_tensors + // Allocate Tensor Memory for (auto &tensor_builder : tensor_builders) { tensor_builder->allocate(); @@ -239,7 +242,6 @@ exec::IExecutor *ExecutorFactory::createDataflowExecutor(graph::Graph &graph, bo }); } - // TODO Extract this to another file class ExecutionBuilder : public IExecutionBuilder { public: -- 2.7.4