From 0313614f4d513bf773ccd3ef1fcc855645a50888 Mon Sep 17 00:00:00 2001 From: Yan Zhang Date: Wed, 18 Apr 2018 20:09:10 +0000 Subject: [PATCH] add extra acronyms for objc property names Summary: This is to support general acronyms in Objective-C like 2G/3G/4G/... and coordinates X, Y, Z and W. Reviewers: benhamilton Reviewed By: benhamilton Subscribers: klimek, cfe-commits Differential Revision: https://reviews.llvm.org/D45750 llvm-svn: 330286 --- clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp | 5 +++++ clang-tools-extra/test/clang-tidy/objc-property-declaration.m | 2 ++ 2 files changed, 7 insertions(+) diff --git a/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp b/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp index 7a3bbaf..ae9ca01 100644 --- a/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp +++ b/clang-tools-extra/clang-tidy/objc/PropertyDeclarationCheck.cpp @@ -39,6 +39,7 @@ enum NamingStyle { /// /// Keep this list sorted. constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = { + "[2-9]G", "ACL", "API", "ARGB", @@ -93,8 +94,12 @@ constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = { "VOIP", "VPN", "VR", + "W", "WAN", + "X", "XML", + "Y", + "Z", }; /// For now we will only fix 'CamelCase' or 'abc_CamelCase' property to diff --git a/clang-tools-extra/test/clang-tidy/objc-property-declaration.m b/clang-tools-extra/test/clang-tidy/objc-property-declaration.m index 0eb61888..5e52808 100644 --- a/clang-tools-extra/test/clang-tidy/objc-property-declaration.m +++ b/clang-tools-extra/test/clang-tidy/objc-property-declaration.m @@ -17,6 +17,8 @@ @property(strong, nonatomic) NSString *supportURLsCamelCase; @property(strong, nonatomic) NSString *supportURLCamelCase; @property(strong, nonatomic) NSString *VCsPluralToAdd; +@property(assign, nonatomic) int centerX; +@property(assign, nonatomic) int enable2GBackgroundFetch; @end @interface Foo (Bar) -- 2.7.4