From 02dd08a09843497ace363e274e10ca3c5f0cc5c0 Mon Sep 17 00:00:00 2001 From: "caseq@chromium.org" Date: Mon, 16 Apr 2012 17:25:26 +0000 Subject: [PATCH] Web Inspector: timeline. Range selection works incorrect with right click https://bugs.webkit.org/show_bug.cgi?id=83870 Reviewed by Pavel Feldman. - only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup) * inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewWindow.prototype._dragWindow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114272 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 31 ++++++++++++++++++++++ .../inspector/front-end/TimelineOverviewPane.js | 3 +++ 2 files changed, 34 insertions(+) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 2bfea79..ba8a4af 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,34 @@ +2012-04-16 Andrey Kosyakov + + Web Inspector: timeline. Range selection works incorrect with right click + https://bugs.webkit.org/show_bug.cgi?id=83870 + + Reviewed by Pavel Feldman. + + - only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup) + + * inspector/front-end/TimelineOverviewPane.js: + (WebInspector.TimelineOverviewWindow.prototype._dragWindow): + +2012-04-16 Andrey Kosyakov + + Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling + https://bugs.webkit.org/show_bug.cgi?id=83946 + + Reviewed by Pavel Feldman. + + Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables + support for moving overview window with horizontal swype over lower timeline pane, thus removing + an irritating situation when we try to both change overview window and scroll lower timeline pane + upon a single touchpad gesture. Those willing to move timeline window now would need to position + mouse over overview. + + * inspector/front-end/TimelineOverviewPane.js: + (WebInspector.TimelineOverviewWindow.prototype._onMouseWheel): + (WebInspector.TimelineOverviewWindow.prototype._zoom): + * inspector/front-end/TimelinePanel.js: + (WebInspector.TimelinePanel): + 2012-04-16 Yury Semikhatsky Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot* diff --git a/Source/WebCore/inspector/front-end/TimelineOverviewPane.js b/Source/WebCore/inspector/front-end/TimelineOverviewPane.js index 77a2d49..2573026 100644 --- a/Source/WebCore/inspector/front-end/TimelineOverviewPane.js +++ b/Source/WebCore/inspector/front-end/TimelineOverviewPane.js @@ -464,6 +464,9 @@ WebInspector.TimelineOverviewWindow.prototype = { _dragWindow: function(event) { + // Only drag upon left button. Right will likely cause a context menu. + if (event.button) + return; var node = event.target; while (node) { if (node.hasStyleClass("resources-dividers-label-bar")) { -- 2.7.4