From 0224a20ff6d0cf051cf818efb364048a2dcb716d Mon Sep 17 00:00:00 2001 From: Vadim Pisarevsky Date: Fri, 8 Aug 2014 22:33:40 +0400 Subject: [PATCH] ECC patch by the author (G. Evangelidis); fixed some OCL Farneback optical flow test failures on Mac --- modules/video/src/ecc.cpp | 7 ++++++- modules/video/src/optflowgf.cpp | 16 ++++++++++------ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/modules/video/src/ecc.cpp b/modules/video/src/ecc.cpp index f56e1f2..8c5fbee 100644 --- a/modules/video/src/ecc.cpp +++ b/modules/video/src/ecc.cpp @@ -297,7 +297,12 @@ static void update_warping_matrix_ECC (Mat& map_matrix, const Mat& update, const mapPtr[5] += updatePtr[7]; } if (motionType == MOTION_EUCLIDEAN) { - double new_theta = acos(mapPtr[0]) + updatePtr[0]; + double new_theta = updatePtr[0]; + if (mapPtr[3]>0) + new_theta += acos(mapPtr[0]); + + if (mapPtr[3]<0) + new_theta -= acos(mapPtr[0]); mapPtr[2] += updatePtr[1]; mapPtr[5] += updatePtr[2]; diff --git a/modules/video/src/optflowgf.cpp b/modules/video/src/optflowgf.cpp index 4225e3d..27abf73 100644 --- a/modules/video/src/optflowgf.cpp +++ b/modules/video/src/optflowgf.cpp @@ -43,6 +43,10 @@ #include "precomp.hpp" #include "opencl_kernels_video.hpp" +#if defined __APPLE__ || defined ANDROID +#define SMALL_LOCALSIZE +#endif + // // 2D dense optical flow algorithm from the following paper: // Gunnar Farneback. "Two-Frame Motion Estimation Based on Polynomial Expansion". @@ -836,7 +840,7 @@ private: bool gaussianBlurOcl(const UMat &src, int ksizeHalf, UMat &dst) { -#ifdef ANDROID +#ifdef SMALL_LOCALSIZE size_t localsize[2] = { 128, 1}; #else size_t localsize[2] = { 256, 1}; @@ -863,7 +867,7 @@ private: bool gaussianBlur5Ocl(const UMat &src, int ksizeHalf, UMat &dst) { int height = src.rows / 5; -#ifdef ANDROID +#ifdef SMALL_LOCALSIZE size_t localsize[2] = { 128, 1}; #else size_t localsize[2] = { 256, 1}; @@ -888,7 +892,7 @@ private: } bool polynomialExpansionOcl(const UMat &src, UMat &dst) { -#ifdef ANDROID +#ifdef SMALL_LOCALSIZE size_t localsize[2] = { 128, 1}; #else size_t localsize[2] = { 256, 1}; @@ -925,7 +929,7 @@ private: bool boxFilter5Ocl(const UMat &src, int ksizeHalf, UMat &dst) { int height = src.rows / 5; -#ifdef ANDROID +#ifdef SMALL_LOCALSIZE size_t localsize[2] = { 128, 1}; #else size_t localsize[2] = { 256, 1}; @@ -952,7 +956,7 @@ private: bool updateFlowOcl(const UMat &M, UMat &flowx, UMat &flowy) { -#ifdef ANDROID +#ifdef SMALL_LOCALSIZE size_t localsize[2] = { 32, 4}; #else size_t localsize[2] = { 32, 8}; @@ -976,7 +980,7 @@ private: } bool updateMatricesOcl(const UMat &flowx, const UMat &flowy, const UMat &R0, const UMat &R1, UMat &M) { -#ifdef ANDROID +#ifdef SMALL_LOCALSIZE size_t localsize[2] = { 32, 4}; #else size_t localsize[2] = { 32, 8}; -- 2.7.4