From 01a5f8a401a2a525b9546d65ddf69aaba37f288d Mon Sep 17 00:00:00 2001 From: Andrew Duggan Date: Fri, 11 Jul 2014 14:35:51 -0700 Subject: [PATCH] HID: rmi: change logging level of log messages related to unexpected reports Userspace tools may use hidraw to perform operations on the device from userspace while hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its ->raw_event() callback gets called as the reports pass through the HID stack. In this case receiving responses which were not initiated by hid-rmi is not actually an error so the resulting error messages are incorrect and misleading. This patch changes the log messages to debug so that the messages can be turned on in the event that there is a problem and there is not a userspace tool running. Signed-off-by: Andrew Duggan Reviewed-by: Benjamin Tissoires Signed-off-by: Jiri Kosina --- drivers/hid/hid-rmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 3221a95..2c3524b 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -377,7 +377,7 @@ static int rmi_input_event(struct hid_device *hdev, u8 *data, int size) irq_mask |= hdata->f30.irq_mask; if (data[1] & ~irq_mask) - hid_warn(hdev, "unknown intr source:%02lx %s:%d\n", + hid_dbg(hdev, "unknown intr source:%02lx %s:%d\n", data[1] & ~irq_mask, __FILE__, __LINE__); if (hdata->f11.interrupt_base < hdata->f30.interrupt_base) { @@ -400,7 +400,7 @@ static int rmi_read_data_event(struct hid_device *hdev, u8 *data, int size) struct rmi_data *hdata = hid_get_drvdata(hdev); if (!test_bit(RMI_READ_REQUEST_PENDING, &hdata->flags)) { - hid_err(hdev, "no read request pending\n"); + hid_dbg(hdev, "no read request pending\n"); return 0; } -- 2.7.4