From 0189ef82722894bc8c9361f90f18577977d58ef4 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Thu, 12 May 2022 13:50:00 +0100 Subject: [PATCH] media: iguanair: no superfluous usb_unlink_urb() Unlinking yourself while the completion handler is running is a NOP. Drop it. Signed-off-by: Oliver Neukum Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab --- drivers/media/rc/iguanair.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index c9cb827..276bf3c 100644 --- a/drivers/media/rc/iguanair.c +++ b/drivers/media/rc/iguanair.c @@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb) return; ir = urb->context; - if (!ir) { - usb_unlink_urb(urb); + if (!ir) return; - } switch (urb->status) { case 0: @@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb) case -ECONNRESET: case -ENOENT: case -ESHUTDOWN: - usb_unlink_urb(urb); return; case -EPIPE: default: -- 2.7.4