From 010a97974a158ebca0bdb58346a2b303ab8a401e Mon Sep 17 00:00:00 2001 From: Jakub Kuderski Date: Thu, 2 Mar 2023 11:23:49 -0500 Subject: [PATCH] [ADT] Drop append_range test that doesn't compile with EXPENSIVE_CHECKS The issue seems to be caused by the definition of `SafeIntIterator` and is otherwise unrelated to the implementation of `append_range`. We have a simialr test below, so this does not meaningfully decrease the test coverage of `append_range`. See the discussion in: https://reviews.llvm.org/D144420#4164373 Issue: https://github.com/llvm/llvm-project/issues/61122 --- llvm/unittests/ADT/STLExtrasTest.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/llvm/unittests/ADT/STLExtrasTest.cpp b/llvm/unittests/ADT/STLExtrasTest.cpp index fda4577..a02b1dc 100644 --- a/llvm/unittests/ADT/STLExtrasTest.cpp +++ b/llvm/unittests/ADT/STLExtrasTest.cpp @@ -7,7 +7,6 @@ //===----------------------------------------------------------------------===// #include "llvm/ADT/STLExtras.h" -#include "llvm/ADT/Sequence.h" #include "llvm/ADT/StringRef.h" #include "gmock/gmock.h" #include "gtest/gtest.h" @@ -405,9 +404,6 @@ TEST(STLExtrasTest, AppendRange) { append_range(V, AppendVals2); EXPECT_THAT(V, ElementsAre(1, 2, 3, 4, 5)); - append_range(V, llvm::seq(6, 8)); - EXPECT_THAT(V, ElementsAre(1, 2, 3, 4, 5, 6, 7)); - std::string Str; append_range(Str, "abc"); EXPECT_THAT(Str, ElementsAre('a', 'b', 'c', '\0')); -- 2.7.4