From 00ee5a5d34f105701f5caf75368326c8009fc020 Mon Sep 17 00:00:00 2001 From: Martin Jones Date: Thu, 6 Oct 2011 16:52:47 +1000 Subject: [PATCH] Ensure view delegates are object parented to the contentItem Caused a leak which resulted in persistent v8 handles not being disposed. Change-Id: I5c10ff619531976ab61d9ce1ff8327c4a40cfd5e Reviewed-on: http://codereview.qt-project.org/6112 Reviewed-by: Qt Sanity Bot Reviewed-by: Chris Adams --- src/declarative/items/qsgitemview.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/declarative/items/qsgitemview.cpp b/src/declarative/items/qsgitemview.cpp index 3224e32..b34ed82 100644 --- a/src/declarative/items/qsgitemview.cpp +++ b/src/declarative/items/qsgitemview.cpp @@ -1578,9 +1578,11 @@ FxViewItem *QSGItemViewPrivate::createItem(int modelIndex) if (model->completePending()) { // complete viewItem->item->setZ(1); + QDeclarative_setParent_noEvent(viewItem->item, q->contentItem()); viewItem->item->setParentItem(q->contentItem()); model->completeItem(); } else { + QDeclarative_setParent_noEvent(viewItem->item, q->contentItem()); viewItem->item->setParentItem(q->contentItem()); } // do other set up for the new item that should not happen -- 2.7.4