From 00cfa720852884cb235cbbf4c734e494fd8b3296 Mon Sep 17 00:00:00 2001 From: Edward Hervey Date: Thu, 23 Nov 2017 08:02:58 +0100 Subject: [PATCH] ipcpipeline: Check the proper value The code is meant to check the *peer* state change return value (and not the sink's one). CID #1416128 --- sys/ipcpipeline/gstipcpipelinesink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/ipcpipeline/gstipcpipelinesink.c b/sys/ipcpipeline/gstipcpipelinesink.c index 526a731..5940d97 100644 --- a/sys/ipcpipeline/gstipcpipelinesink.c +++ b/sys/ipcpipeline/gstipcpipelinesink.c @@ -651,7 +651,7 @@ gst_ipc_pipeline_sink_change_state (GstElement * element, GST_DEBUG_OBJECT (sink, "Calling peer with state change"); peer_ret = gst_ipc_pipeline_comm_write_state_change_to_fd (&sink->comm, transition); - if (ret == GST_STATE_CHANGE_FAILURE && down) { + if (peer_ret == GST_STATE_CHANGE_FAILURE && down) { GST_WARNING_OBJECT (sink, "Peer returned state change failure, " "but ignoring because we are going down"); peer_ret = GST_STATE_CHANGE_SUCCESS; -- 2.7.4