From 00700865648c2040c97608834076a700b2ee673f Mon Sep 17 00:00:00 2001 From: Roland McGrath Date: Thu, 25 Sep 2003 03:50:45 +0000 Subject: [PATCH] 2003-09-24 Roland McGrath * allocatestack.c (__make_stacks_executable): Don't ignore return value from _dl_make_stack_executable. --- nptl/allocatestack.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c index c82b36e..f9600cc 100644 --- a/nptl/allocatestack.c +++ b/nptl/allocatestack.c @@ -687,21 +687,22 @@ __make_stacks_executable (void) /* Also change the permission for the currently unused stacks. This might be wasted time but better spend it here than adding a check in the fast path. */ - list_for_each (runp, &stack_cache) - { - err = change_stack_perm (list_entry (runp, struct pthread, list) + if (err == 0) + list_for_each (runp, &stack_cache) + { + err = change_stack_perm (list_entry (runp, struct pthread, list) #ifdef NEED_SEPARATE_REGISTER_STACK - , pagemask + , pagemask #endif - ); - if (err != 0) - break; - } + ); + if (err != 0) + break; + } lll_unlock (stack_cache_lock); if (err == 0) - _dl_make_stack_executable (); + err = _dl_make_stack_executable (); return err; } -- 2.7.4