platform/upstream/elementary.git
10 years agotest, examples fileselector_entry: Changed the usage of deprecated APIs master
Daniel Juyung Seo [Tue, 21 Jan 2014 14:53:48 +0000 (23:53 +0900)]
test, examples fileselector_entry: Changed the usage of deprecated APIs
to recommended APIs.

10 years agofileselector_entry: Moved declarations of deprecated APIs to
Daniel Juyung Seo [Tue, 21 Jan 2014 14:50:31 +0000 (23:50 +0900)]
fileselector_entry: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.

10 years agotest, examples fileselector_button: Changed the usage of deprecated APIs to recommended
Daniel Juyung Seo [Tue, 21 Jan 2014 14:43:59 +0000 (23:43 +0900)]
test, examples fileselector_button: Changed the usage of deprecated APIs to recommended
APIs.

10 years agofileselector_button: Moved declarations of deprecated APIs to
Daniel Juyung Seo [Tue, 21 Jan 2014 14:42:56 +0000 (23:42 +0900)]
fileselector_button: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.

10 years agourl: Added underscore(_) to elm internal functions, elm_url_xxx.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:23:37 +0000 (23:23 +0900)]
url: Added underscore(_) to elm internal functions, elm_url_xxx.

- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.

10 years agoelm: Removed unnecessary null check for ecore_timer_del,
Daniel Juyung Seo [Tue, 21 Jan 2014 14:16:41 +0000 (23:16 +0900)]
elm: Removed unnecessary null check for ecore_timer_del,
 ecore_animator_del, and ecore_job_del.

As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.

10 years agoIntroduce fileselector interface and applied to elm_fileselector.
Ryuan Choi [Tue, 21 Jan 2014 13:50:35 +0000 (22:50 +0900)]
Introduce fileselector interface and applied to elm_fileselector.

Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().

Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.

This patch introduced fileselector interface and applied it to elm_fileselector.

Reviewers: seoz, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D475

10 years agospinner: Create an internal entry when it is really needed.
Daniel Juyung Seo [Tue, 21 Jan 2014 13:12:53 +0000 (22:12 +0900)]
spinner: Create an internal entry when it is really needed.

Do not create the internal entry on smart add. Create that when it is
needed with editable mode.

10 years agospinner: Toggle entry on Enter and space key.
Daniel Juyung Seo [Tue, 21 Jan 2014 12:59:41 +0000 (21:59 +0900)]
spinner: Toggle entry on Enter and space key.

10 years agoentry: NULL should be set to the correct position of tmpbuf.
WooHyun Jung [Tue, 21 Jan 2014 12:00:29 +0000 (21:00 +0900)]
entry: NULL should be set to the correct position of tmpbuf.

If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.

10 years agotoolbar: Do not check ev->string for Return key and react on space key.
Daniel Juyung Seo [Tue, 21 Jan 2014 10:57:22 +0000 (19:57 +0900)]
toolbar: Do not check ev->string for Return key and react on space key.

space key works as same as Return key.

10 years agoelm: Fixed formatting about EINA_LOG stuff.
Daniel Juyung Seo [Tue, 21 Jan 2014 03:08:20 +0000 (12:08 +0900)]
elm: Fixed formatting about EINA_LOG stuff.

10 years agotest_focus: Call window object show after its content creation.
Daniel Juyung Seo [Thu, 16 Jan 2014 00:34:16 +0000 (09:34 +0900)]
test_focus: Call window object show after its content creation.

This is a successor commit of 64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.

10 years agowidget: doxygen fix
Yakov Goldberg [Tue, 21 Jan 2014 09:29:57 +0000 (11:29 +0200)]
widget: doxygen fix

10 years agoall widgets: change Eo API for "elm_widget_theme()" to "theme_apply"
Yakov Goldberg [Tue, 21 Jan 2014 08:44:45 +0000 (10:44 +0200)]
all widgets: change Eo API for "elm_widget_theme()" to "theme_apply"

    There are elm_widget_theme/theme_set/theme_get functions.
    In Eolian these functions will be described as "theme" method and
    "theme" property. There is clash here.
    So add suffix "_apply" to Eo API for "elm_widget_theme".

10 years ago[Gengrid] Refactoring gengrid item show reigion calculation
SangHyeon Lee [Tue, 21 Jan 2014 07:54:59 +0000 (16:54 +0900)]
[Gengrid] Refactoring gengrid item show reigion calculation

Summary:
Gengrid _item_show_region function calculate gengrid x, y moving postion with scroll to type.
Belows are summaries of this refactoring works.

1. Refactoring recalculation of scroll type.

2. Bug fix :
   - when x or y is 0, y or x value is set as default value, it->position-1.
   - when x or y is less then 1, calculation is not correct.
   - make calculate correct position of y when even though scroll direction is horiziontal
     (when virtical, x is also calculation correct position).

3.  change smart data variable s_type to scroll_to_type to make unity on gen widget.
     (genlist smart data variable name is scroll_to_type);

Reviewers: seoz, Hermet, raster

Reviewed By: raster

CC: bluezery
Differential Revision: https://phab.enlightenment.org/D474

10 years agoPackageKit theme: pass make distcheck
davemds [Mon, 20 Jan 2014 19:22:41 +0000 (20:22 +0100)]
PackageKit theme: pass make distcheck

Also the image used by the edc need to be included in the tarball

10 years agoprefs init should probably clean up after itself when it fucks up
zmike [Mon, 20 Jan 2014 18:25:59 +0000 (13:25 -0500)]
prefs init should probably clean up after itself when it fucks up

10 years agoprefs should CRI on add/file_set if init has failed
zmike [Mon, 20 Jan 2014 18:25:37 +0000 (13:25 -0500)]
prefs should CRI on add/file_set if init has failed

10 years agotheme: Add packagekit edc to fix make distcheck
Stefan Schmidt [Mon, 20 Jan 2014 14:37:06 +0000 (15:37 +0100)]
theme: Add packagekit edc to fix make distcheck

Adding it to EXTRA_DIST makes ure it gets packaged in the tarball
and is available for a plain tarball build.

10 years agoconform: Fixed to get a geometry from *focus_region_get for show_region_job.
Youngbok Shin [Mon, 20 Jan 2014 09:54:20 +0000 (18:54 +0900)]
conform: Fixed to get a geometry from *focus_region_get for show_region_job.

Summary:
The geometry of elm_widget_show_region_get is only updated by elm_widget_show_region_set.
If the geometry of *show_region_get is not updated, the result of show_region_job would be incorrect.
So, we need to get a proper geometry using *focus_region_get for focused object.

Reviewers: seoz, woohyun, Hermet, raster, tasn

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D466

10 years agoentry: Add smart activate for accessbility.
Youngbok Shin [Mon, 20 Jan 2014 09:45:51 +0000 (18:45 +0900)]
entry: Add smart activate for accessbility.

Summary:
In TTS mode, when the entry is highlighten and double tap to the entry,
the entry will be focused. But "clicked" smart callback is not called, input panel is not shown.
So I we need to call the callback and show input panel in smart activate.

Reviewers: seoz, Hermet, woohyun, tasn, jaehwan, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D465

10 years agoentry: If the scrollable entry is set disable, send "*,disabled" signal to scr_edje...
Youngbok Shin [Mon, 20 Jan 2014 09:04:30 +0000 (18:04 +0900)]
entry: If the scrollable entry is set disable, send "*,disabled" signal to scr_edje too.

Summary:
Default theme of entry does not have any disabled state in "elm/scroller/entry/*" styles.
But EFL developer can make any custom style for entry and scroller and it can has disabled state.
So _elm_entry_smart_disable has to emit "*disabled" signal to scr_edje.

Reviewers: woohyun, tasn, seoz, Hermet, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D464

10 years agotheme for the packagekit module IN
davemds [Sun, 19 Jan 2014 10:37:00 +0000 (11:37 +0100)]
theme for the packagekit module IN

10 years agofileselector_button, fileselector_entry: Updated FOO_inwin_mode_set() documentation.
Ryuan Choi [Sun, 19 Jan 2014 06:31:20 +0000 (15:31 +0900)]
fileselector_button, fileselector_entry: Updated FOO_inwin_mode_set() documentation.

fileselector_button initialize inwin mode using the configuration.
Fixed wrong information about default value in API documentation.

In addition, fixed test_fileselector_button.cpp not to show wrong information at initial time.

10 years agotheme - ibar - emit show doen signal for ibar menu
Carsten Haitzler (Rasterman) [Sat, 18 Jan 2014 10:52:24 +0000 (19:52 +0900)]
theme - ibar - emit show doen signal for ibar menu

10 years agoSHUT UP ELM PREFS!!!!!!!!!!
zmike [Sat, 18 Jan 2014 06:56:12 +0000 (01:56 -0500)]
SHUT UP ELM PREFS!!!!!!!!!!

seriously, this is and has been bullshit since it was added. I don't need an error message every time I do ANYTHING just because some module has never been found.

10 years agotweak e menu shadow offsets
Mike Blumenkrantz [Thu, 16 Jan 2014 16:44:31 +0000 (11:44 -0500)]
tweak e menu shadow offsets

T793

10 years agoflipselector: Remove unused variable of Elm_Flipselector_Item
Ryuan Choi [Thu, 16 Jan 2014 15:19:49 +0000 (00:19 +0900)]
flipselector: Remove unused variable of Elm_Flipselector_Item

The data for callback is stored in Widget's data variable.
So, Elm_Flipselector_Item's data variable is not needed.

10 years agotest_flipselector: Fixed that buttons use wrong flipselector which is not intended.
Ryuan Choi [Thu, 16 Jan 2014 14:48:36 +0000 (23:48 +0900)]
test_flipselector: Fixed that buttons use wrong flipselector which is not intended.

Since e2db48abe, disabled flipselector was passed button callbacks.
So, buttons just print warnings instead of the intended behavior.

10 years agodatetime: Delay elm_layout_theme_set until memebers are initialized in _smart_add
Ryuan Choi [Thu, 16 Jan 2014 13:44:07 +0000 (22:44 +0900)]
datetime: Delay elm_layout_theme_set until memebers are initialized in _smart_add

There are some warnings in elm_object_disabled_set() because elm_layout_theme_set()
calls _elm_datetime_smart_disable() before creating file->item_obj.
This patch refactors _smart_add to initialize file->item_obj before calling
elm_layout_theme_set().

10 years agoFix unknown command warning in generating doxygen
Jihoon Kim [Wed, 15 Jan 2014 23:43:58 +0000 (08:43 +0900)]
Fix unknown command warning in generating doxygen

elementary/src/lib/elm_access.h:238: warning: Found unknown command `\type'
elementary/src/lib/elm_bg_legacy.h:98: warning: Found unknown command `\r'
elementary/src/lib/elm_bg_legacy.h:98: warning: Found unknown command `\g'
elementary/src/lib/elm_object.h:124: warning: Found unknown command `\content'
elementary/src/lib/elm_image_legacy.h:82: warning: Found unknown command `\group'
elementary/src/lib/elm_image_legacy.h:56: warning: Found unknown command `\group'

10 years agopanel: Guarantee the integrity of parameter
Ryuan Choi [Wed, 15 Jan 2014 19:27:47 +0000 (04:27 +0900)]
panel: Guarantee the integrity of parameter

- Check whether ret is NULL.
- Guarantee hidden variable is only EINA_TRUE or EINA_FALSE.

10 years agopanel: Check whether sd->content is NULL in _panel_toggle
Ryuan Choi [Wed, 15 Jan 2014 19:10:38 +0000 (04:10 +0900)]
panel: Check whether sd->content is NULL in _panel_toggle

sd->content can be NULL when elm_panel_hidden_set is called.

10 years agopanel: Delay elm_layout_theme_set until memebers are initialized in _smart_add
Ryuan Choi [Wed, 15 Jan 2014 19:02:11 +0000 (04:02 +0900)]
panel: Delay elm_layout_theme_set until memebers are initialized in _smart_add

elm_layout_theme_set can call some methods like _elm_panel_smart_theme and there are some warnings
when these methods manipulate some member variabls which are not initialized yet.
It's because elm_layout_theme_set is called too early in _smart_add.

Spotted while digging warnings after rELM4c3e23de9e46

10 years agoelm_widget_xxx.h: Adopt EINA_UNLIKELY and fix indentation in FOO_DATA_GET macros.
Ryuan Choi [Wed, 15 Jan 2014 18:33:40 +0000 (03:33 +0900)]
elm_widget_xxx.h: Adopt EINA_UNLIKELY and fix indentation in FOO_DATA_GET macros.

10 years agowin: Check null before calling elm_widget_highlight_in_theme_get(). It
Daniel Juyung Seo [Wed, 15 Jan 2014 17:33:46 +0000 (02:33 +0900)]
win: Check null before calling elm_widget_highlight_in_theme_get(). It
can be null.

'target' can be null when the focus in is just called.

10 years agotest: Cleaned up elementary_test internal code.
Daniel Juyung Seo [Wed, 15 Jan 2014 17:10:21 +0000 (02:10 +0900)]
test: Cleaned up elementary_test internal code.

- removed unnecessary/unused macro.
- fixed formatting.
- added prefix '_' for internal function.

10 years agofileselector_entry: Removed _mirrored_set(), one line local function
Ryuan Choi [Wed, 15 Jan 2014 12:58:07 +0000 (21:58 +0900)]
fileselector_entry: Removed _mirrored_set(), one line local function

Small refactoring.
It is unnecessary one line function which just calls elm_widget_mirrored_set.

10 years agofileselector_entry: Delay elm_layout_theme_set until memebers are initialized in...
Ryuan Choi [Wed, 15 Jan 2014 12:44:21 +0000 (21:44 +0900)]
fileselector_entry: Delay elm_layout_theme_set until memebers are initialized in _smart_add

Summary:
elm_layout_theme_set can call some methods like _smart_disable and there are some warnings
when these methods manipulate some member variabls which are not initialized yet.
It's because elm_layout_theme_set is called too early in _smart_add.

Spotted while digging warnings after rELM4c3e23de9e46

Reviewers: seoz, raster

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D459

10 years agopager16 - match same theme look for popup as pager orig
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2014 11:34:17 +0000 (20:34 +0900)]
pager16 - match same theme look for popup as pager orig

10 years agoe19 - deskmirror - use proper scaling for mini frames
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2014 11:13:13 +0000 (20:13 +0900)]
e19 - deskmirror - use proper scaling for mini frames

10 years agoChangeLog/NEWS: Removed unnecessary ChangeLog and NEWS entries.
Daniel Juyung Seo [Wed, 15 Jan 2014 08:30:12 +0000 (17:30 +0900)]
ChangeLog/NEWS: Removed unnecessary ChangeLog and NEWS entries.

We do not modify them at every commit after 1.8 release. These are
changed by stefan when it does release.

10 years agoelementary/ctxpopup - no need to use RESTACK callbacks anymore.
ChunEon Park [Wed, 15 Jan 2014 06:00:31 +0000 (15:00 +0900)]
elementary/ctxpopup - no need to use RESTACK callbacks anymore.

Now bg is smart member of the internal object.
let it have a behavior as the member of the smart object.
don't need to care it additionally.

10 years agotest_photocam: Support zoom in and out with more condition checks.
Daniel Juyung Seo [Wed, 15 Jan 2014 06:04:26 +0000 (15:04 +0900)]
test_photocam: Support zoom in and out with more condition checks.

Now zoom in and out work sanely.

10 years agoctxpopup: set smart member relationship for objects in ctxpopup
Bora Hwang [Wed, 15 Jan 2014 05:42:13 +0000 (14:42 +0900)]
ctxpopup: set smart member relationship for objects in ctxpopup

Summary:
to support mouse_down/up/move callbacks of ctxpopup,
all objects in ctxpopup should be in smart relationship with ctxpopup.
Also, with this patch, bg object and arrow object don't have to be called with
evas_object_show or evas_object_hide when ctxpopup is shown or hidden

Reviewers: Hermet, seoz, raster, thiepha

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D458

10 years agophotocam: Updated elm_photocam_zoom_set() API documentation.
Daniel Juyung Seo [Wed, 15 Jan 2014 05:39:11 +0000 (14:39 +0900)]
photocam: Updated elm_photocam_zoom_set() API documentation.

10 years agoelementary - don't use __UNUSED__ anymore
ChunEon Park [Wed, 15 Jan 2014 05:36:55 +0000 (14:36 +0900)]
elementary - don't use __UNUSED__ anymore

10 years ago[naviframe] Replace naviframe title visible APIs to naviframe title enabled APIs
Jaehyun Cho [Wed, 15 Jan 2014 05:29:05 +0000 (14:29 +0900)]
[naviframe] Replace naviframe title visible APIs to naviframe title enabled APIs

Summary:
To support naviframe title transition effect, naviframe title enabled APIs are applied.
         To remove the duplicate functionalities, naviframe title visible APIs are deprecated.

Reviewers: Hermet

Reviewed By: Hermet

CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D426

10 years agotest_glview: Refactor glview test layout.
Daniel Juyung Seo [Wed, 15 Jan 2014 03:02:26 +0000 (12:02 +0900)]
test_glview: Refactor glview test layout.

- Display button just vertically.
- Changed button text more descriptive.
- Create glview related buttons only when glview is created correctly.

10 years agotest_glview_simple: Close the window instead of exiting the program on
Daniel Juyung Seo [Wed, 15 Jan 2014 02:54:23 +0000 (11:54 +0900)]
test_glview_simple: Close the window instead of exiting the program on
close button.

10 years agoe menus now have their own shadows
Mike Blumenkrantz [Thu, 2 Jan 2014 16:24:22 +0000 (11:24 -0500)]
e menus now have their own shadows

10 years agofix comp theme fast popups to still have shadows
Mike Blumenkrantz [Wed, 1 Jan 2014 19:47:26 +0000 (14:47 -0500)]
fix comp theme fast popups to still have shadows

10 years agochange theme animation for window frame icon urgency to be more in line with other...
Mike Blumenkrantz [Wed, 1 Jan 2014 03:33:04 +0000 (22:33 -0500)]
change theme animation for window frame icon urgency to be more in line with other e animations

a number of e animations are "zoom" related. bouncing is clearly identified as being OSX, so let's stay away from that.

10 years agofeature: add PIN desklock theme
Mike Blumenkrantz [Fri, 20 Dec 2013 03:24:50 +0000 (22:24 -0500)]
feature: add PIN desklock theme

currently just reuses syscon buttons since they're identical in function

10 years agofeature: iconify/uniconify animations for windows
Mike Blumenkrantz [Fri, 20 Dec 2013 03:22:16 +0000 (22:22 -0500)]
feature: iconify/uniconify animations for windows

10 years agofeature: pager16 module theme
Mike Blumenkrantz [Fri, 20 Dec 2013 03:20:06 +0000 (22:20 -0500)]
feature: pager16 module theme

10 years agoreadd deskmirror
Mike Blumenkrantz [Sat, 21 Dec 2013 23:25:21 +0000 (18:25 -0500)]
readd deskmirror

this file seems to have been magically and mysteriously lost during the recent theme merge

10 years agoredo comp theme to match e19 signals
Mike Blumenkrantz [Fri, 20 Dec 2013 00:09:27 +0000 (19:09 -0500)]
redo comp theme to match e19 signals

* shadows should be uniformly moved to whatever thing they're supposed to be on (WIP)

* trans-clipper was a failure idea, this is now done in C

* signals renamed to be more consistent

* groups renamed to comp/frame/*

* comp/border/* groups preserved for compat

10 years agocnp - dont access null parent obj in getting xwin
Carsten Haitzler (Rasterman) [Wed, 15 Jan 2014 00:59:01 +0000 (09:59 +0900)]
cnp - dont access null parent obj in getting xwin

10 years agotest_ctxpopup: Internal refactoring of ctxpopup test codes.
Daniel Juyung Seo [Tue, 14 Jan 2014 17:32:36 +0000 (02:32 +0900)]
test_ctxpopup: Internal refactoring of ctxpopup test codes.

- Handled the deletion of image object correctly. Do not overuse/misuse
evas_object_data, it will make code less readable.
- Cleaned up button click callback. sharing one function for different
buttons is not a good idea in some cases. Just split the callbacks.
- Removed unnecessary evas_object_data_set().

10 years agowin: Added more description to elm_win_floating_mode_set() API.
Daniel Juyung Seo [Tue, 14 Jan 2014 14:29:15 +0000 (23:29 +0900)]
win: Added more description to elm_win_floating_mode_set() API.

10 years agoelm widget - skip null list entires in focus list
Carsten Haitzler (Rasterman) [Tue, 14 Jan 2014 13:47:54 +0000 (22:47 +0900)]
elm widget - skip null list entires in focus list

10 years agotoolbar: Check whether icon is null before sending signal
Ryuan Choi [Tue, 14 Jan 2014 12:32:28 +0000 (21:32 +0900)]
toolbar: Check whether icon is null before sending signal

There are warnings when icon is null since rELM4c3e23de9e46.

10 years agofileselector: Fix that folder only mode shows only files instead of only folders
Ryuan Choi [Tue, 14 Jan 2014 09:11:30 +0000 (18:11 +0900)]
fileselector: Fix that folder only mode shows only files instead of only folders

Issues: T756

It's regression of rELM4693736bb028

10 years agoelm: Build in an alphabetical order.
Daniel Juyung Seo [Tue, 14 Jan 2014 08:20:29 +0000 (17:20 +0900)]
elm: Build in an alphabetical order.

10 years agopo: Updated po files.
Daniel Juyung Seo [Tue, 14 Jan 2014 08:19:38 +0000 (17:19 +0900)]
po: Updated po files.

It's actually annoying that po is changed whenever I do clean build.

10 years agoscroller: Fixed wheel event callback
Hosang Kim [Tue, 14 Jan 2014 07:56:52 +0000 (16:56 +0900)]
scroller: Fixed wheel event callback

Summary:
scroller is moved page by page if scroller's paging is enable

1. default is move to vertical.
2. move to horizontal with Shift key

Reviewers: seoz, Hermet, jaehwan, woohyun, raster, cedric

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D453

10 years agodoxygen: fix 'icon' and 'check' widget examples
Jerome Pinot [Tue, 14 Jan 2014 05:44:15 +0000 (14:44 +0900)]
doxygen: fix 'icon' and 'check' widget examples

Due to code change, the snippets didn't show up in the tutorials of
elm_icon and elm_check. Also, add missing example pictures.

10 years ago[test access]: Minor change to make code simpler.
Chinmaya Panigrahi [Tue, 14 Jan 2014 04:39:33 +0000 (13:39 +0900)]
[test access]: Minor change to make code simpler.

Summary: Minor change to make code a little simpler.

Test Plan: elementary_test -to accessibility

Reviewers: seoz, singh.amitesh

Reviewed By: seoz

Differential Revision: https://phab.enlightenment.org/D456

10 years agoactionslider: Removed unnecessary line.
Daniel Juyung Seo [Tue, 14 Jan 2014 02:40:54 +0000 (11:40 +0900)]
actionslider: Removed unnecessary line.

10 years agoentry: remove duplicated checking variable
Jihoon Kim [Mon, 13 Jan 2014 23:07:22 +0000 (08:07 +0900)]
entry: remove duplicated checking variable

'top' variable was checked twice, so it's fixed.

10 years agoels_box: Used Eina_Bool instead of int for the parameters of _els_box_layout
Ryuan Choi [Mon, 13 Jan 2014 18:26:16 +0000 (03:26 +0900)]
els_box: Used Eina_Bool instead of int for the parameters of _els_box_layout

10 years agoatspi_bridge: Changed shadow variable names.
Daniel Juyung Seo [Mon, 13 Jan 2014 14:15:11 +0000 (23:15 +0900)]
atspi_bridge: Changed shadow variable names.

10 years agoctxpopup, entry: Check widget type by eo_isa not by evas_object_type
Daniel Juyung Seo [Mon, 13 Jan 2014 14:14:44 +0000 (23:14 +0900)]
ctxpopup, entry: Check widget type by eo_isa not by evas_object_type
string compare.

10 years agoinwin, layout: Check null before calling eo_isa.
Daniel Juyung Seo [Mon, 13 Jan 2014 14:09:25 +0000 (23:09 +0900)]
inwin, layout: Check null before calling eo_isa.

10 years agopanes: Fixed panes smart callbak calls by fixing default theme.
Daniel Juyung Seo [Mon, 13 Jan 2014 14:00:28 +0000 (23:00 +0900)]
panes: Fixed panes smart callbak calls by fixing default theme.

Panes smart callback depends on the signals from theme but it was broken
when dark theme was introduced.
"clicked" does not work yet, it should be fixed.

Thanks for the report, JackDanielZ.

10 years agocnp: Fixed indentation while reading the code.
Daniel Juyung Seo [Mon, 13 Jan 2014 12:03:12 +0000 (21:03 +0900)]
cnp: Fixed indentation while reading the code.

10 years agoWidget: Removed !obj checks from ELM_WIDGET_DATA_GET_OR_RETURN and ELM_WIDGET_CHECK
Ryuan Choi [Mon, 13 Jan 2014 12:11:04 +0000 (21:11 +0900)]
Widget: Removed !obj checks from ELM_WIDGET_DATA_GET_OR_RETURN and ELM_WIDGET_CHECK

eo_data_scope_get and eo_isa returns NULL with complaint when NULL is passed.
So, Removed unnecessary !obj check routine.

In addition, adopt EINA_UNLIKELY for these macros and fix indentation.

10 years agoentry: Add elm_entry_input_panel_show_on_demand_set/get API
Jihoon Kim [Mon, 13 Jan 2014 10:32:01 +0000 (19:32 +0900)]
entry: Add elm_entry_input_panel_show_on_demand_set/get API

This API sets the attribute to show the input panel in case of only an user's explicit Mouse Up event.
It doesn't request to show the input panel even though it has focus.

10 years agoelm_win: Removed EE_ENGINE_COMPARE macro to reduce redundant function calls.
Ryuan Choi [Wed, 8 Jan 2014 00:05:08 +0000 (09:05 +0900)]
elm_win: Removed EE_ENGINE_COMPARE macro to reduce redundant function calls.

EE_ENGINE_COMPARE reduces typing little bit, but it makes redundant function calls
because almost callers call it more than once.
And, there is no way to check whether ecore_evas_engine_name_get is null.

This patch removed EE_ENGINE_COMPARE with small refactoring.
In addition, removed unnecessary check routines from _elm_ee_xwin_get.

10 years agogenlist: Check return value out of the loop in _realized_items_get
Ryuan Choi [Fri, 10 Jan 2014 12:05:00 +0000 (21:05 +0900)]
genlist: Check return value out of the loop in _realized_items_get

10 years agofileselector: Fix that the enter key does not navigate directory
Ryuan Choi [Thu, 9 Jan 2014 23:24:22 +0000 (08:24 +0900)]
fileselector: Fix that the enter key does not navigate directory

Moved the navigation logic from callback of "clicked,double" to callback of "activated".

10 years agoels_box : Move horizontal condition out of some loop in _els_box_layout
Ryuan Choi [Mon, 13 Jan 2014 06:47:04 +0000 (15:47 +0900)]
els_box : Move horizontal condition out of some loop in _els_box_layout

Summary:
Almost logic of both horizontal and vertical are same except different axis in
_els_box_layout.
This patch reduced code size and improved speed little bit by moving condition
out of the loop using some extra pointer variables.

In addition, removed unnecessary check routines.
There are already similar logic for them before and after.

Reviewers: raster, seoz, cedric

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D423

10 years agoactionslider - fix unused macros to match current usage and build again
Carsten Haitzler (Rasterman) [Mon, 13 Jan 2014 06:46:31 +0000 (15:46 +0900)]
actionslider - fix unused macros to match current usage and build again

10 years ago[actionslider]:enable the mouse event
prashant [Mon, 13 Jan 2014 06:44:44 +0000 (15:44 +0900)]
[actionslider]:enable the mouse event

Summary: On mouse click move the knob on action slider

Test Plan: elementary_test -to actionslider

Reviewers: seoz, singh.amitesh, raster

Reviewed By: raster

CC: raster
Differential Revision: https://phab.enlightenment.org/D384

10 years agoatspi - fix warnhings and use %llu (unsigned long long) or obj handle
Carsten Haitzler (Rasterman) [Mon, 13 Jan 2014 06:35:48 +0000 (15:35 +0900)]
atspi - fix warnhings and use %llu (unsigned long long) or obj handle

10 years agoatspi: accessible and component interface implementation.
Lukasz Stanislawski [Mon, 13 Jan 2014 06:24:35 +0000 (15:24 +0900)]
atspi: accessible and component interface implementation.

Reviewers: raster, cedric, kimcinoo, seoz

Reviewed By: raster

CC: pkaczmarek-samsung, z.kosinski
Differential Revision: https://phab.enlightenment.org/D378

10 years agoAdding elm_tooltip_movement_lock_set() and elm_tooltip_movement_lock_get()
abhi [Mon, 13 Jan 2014 06:22:47 +0000 (15:22 +0900)]
Adding elm_tooltip_movement_lock_set() and elm_tooltip_movement_lock_get()

Summary: These APIs allow to enable/disable a tooltip to move with respect to mouse pointer

Test Plan: elm_tooltip_movement_lock_set(), elm_tooltip_movement_lock_get(), elementary_test -to tooltip

Reviewers: singh.amitesh, seoz, raster

Reviewed By: raster

CC: raster
Differential Revision: https://phab.enlightenment.org/D369

10 years agoelm cnp (dnd) - file:/ is the minimum, not file:// so work with other apps
Carsten Haitzler (Rasterman) [Mon, 13 Jan 2014 05:00:09 +0000 (14:00 +0900)]
elm cnp (dnd) - file:/ is the minimum, not file:// so work with other apps

10 years agotheme - make dark rounded square less transp. and add shadow to ibar menu
Carsten Haitzler (Rasterman) [Sun, 12 Jan 2014 20:07:52 +0000 (05:07 +0900)]
theme - make dark rounded square less transp. and add shadow to ibar menu

10 years agotest_genlist: Enable focus highlight and animation only for this window.
Daniel Juyung Seo [Sun, 12 Jan 2014 16:09:26 +0000 (01:09 +0900)]
test_genlist: Enable focus highlight and animation only for this window.

Do not affect other test windows.

10 years agotest_genlist: Renamed genlist20 test name to more descriptive test name,
Daniel Juyung Seo [Sun, 12 Jan 2014 16:06:17 +0000 (01:06 +0900)]
test_genlist: Renamed genlist20 test name to more descriptive test name,
 genlist_focus.

10 years agoglview test - fix if evas gl ins't found - leak of gld data
Carsten Haitzler (Rasterman) [Sat, 11 Jan 2014 07:44:04 +0000 (16:44 +0900)]
glview test - fix if evas gl ins't found - leak of gld data

10 years agoelm prefs cc - fix failed lseek handling on compile
Carsten Haitzler (Rasterman) [Sat, 11 Jan 2014 07:41:03 +0000 (16:41 +0900)]
elm prefs cc - fix failed lseek handling on compile

10 years agoglview test - dont leak gld
Carsten Haitzler (Rasterman) [Sat, 11 Jan 2014 07:35:29 +0000 (16:35 +0900)]
glview test - dont leak gld

10 years agofix sign/unsigned compare warn
Carsten Haitzler (Rasterman) [Sat, 11 Jan 2014 07:23:23 +0000 (16:23 +0900)]
fix sign/unsigned compare warn

10 years agouse long not unsigned long - ftell returns long.
Carsten Haitzler (Rasterman) [Sat, 11 Jan 2014 07:19:25 +0000 (16:19 +0900)]
use long not unsigned long - ftell returns long.

10 years agoelm glview - evas sync before rendering with always draw to sync right
Carsten Haitzler (Rasterman) [Fri, 10 Jan 2014 15:40:01 +0000 (00:40 +0900)]
elm glview - evas sync before rendering with always draw to sync right

async rendering clashes with the idle enterer glview uses to draw with
always render mode - sync first and there is no problem.

10 years agodbus menu - fix leak of reply creation for method events
Carsten Haitzler (Rasterman) [Fri, 10 Jan 2014 09:10:49 +0000 (18:10 +0900)]
dbus menu - fix leak of reply creation for method events

this fixes CID 1039975