Łukasz Stelmach [Tue, 4 Jun 2024 13:18:45 +0000 (15:18 +0200)]
MemoryLimit has been replaced by MemoryMax
The MemoryLimit option is marked as deprecated in systemd and needs to
be changed to MemoryMax in unit files.
Change-Id: I4945b57ecc8cf6fe23b5c4f270e1f7c7482954f4
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
JinWang An [Fri, 15 Mar 2024 05:59:11 +0000 (14:59 +0900)]
Add python3-setuptools dependency for python 3.12
Change-Id: I0ac82005d74dba0c109e75518abcdc48e05a9f15
Signed-off-by: JinWang An <jinwang.an@samsung.com>
Youngjae Cho [Thu, 7 Mar 2024 10:09:52 +0000 (19:09 +0900)]
Cherrypick the deprecated g_module_build_path() from upstream
As of the glib version 2.76, the g_module_build_path() has been
deprecated due to inconsistency of G_MODULE_SUFFIX.
(See https://github.com/GNOME/glib/commit/d941558)
However, we know that the G_MODULE_SUFFIX is clearly "so" on our
unix environment. Therefore, copy and reuse the deprecated function
internally, replacing G_MODULE_SUFFIX with string literal "so".
The g_module_open() has been improved as a compensation for the
deprecation, which takes care of all the possible G_MODULE_SUFFIX.
But we cannot use it instead, as we need full path before calling
g_module_open() to check several file attributes.
Change-Id: I7e939fc3fbe6697cacb3205adc8d453205449ae7
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Unsung Lee [Mon, 23 Oct 2023 02:51:06 +0000 (11:51 +0900)]
service: Set MemoryLimit to 20MB
Change-Id: Iccefd6650563326478866fd6211ca8ebdd867a2c
Signed-off-by: Unsung Lee <unsung.lee@samsung.com>
Youngjae Cho [Thu, 29 Jun 2023 04:17:27 +0000 (13:17 +0900)]
Fix coverity issue
When comparing operands that containing sizeof operator, both are taken
as unsigned. Therefore if an operand was -1, which might be a value of
error return, it is interpreted as unsigned value such as
4294967295
when it is compared with another operand, sizeof value. Make both
operands be signed by casting sizeof value into glong.
Change-Id: I116c507f50ad93f7b699c2524868e3c72979c376
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Karol Lewandowski [Thu, 24 Feb 2022 14:49:57 +0000 (15:49 +0100)]
Make gtkdocize optional in non-debug builds
Change-Id: I6682a3eba2dcb82ff582f7f581c374498978ba39
INSUN PYO [Fri, 23 Oct 2020 01:15:15 +0000 (10:15 +0900)]
Fix a bug that incorrectly uses putenv
Refer: https://stackoverflow.com/questions/5873029/questions-about-putenv-and-setenv
Change-Id: I26f1e7e6ce14f78f827a8440b97baf930b6d3102
INSUN PYO [Thu, 17 Sep 2020 04:58:47 +0000 (13:58 +0900)]
Change execute label to System to remove smack errors
Jan 01 09:08:55 localhost audit[2765]: AVC lsm=SMACK fn=smack_key_permission action=denied subject="User" object="System::Privileged" requested=r pid=2765 comm="tlm-sessiond" key_serial=
841328352 key_desc="_ses"
Jan 01 09:08:55 localhost audit[2765]: AVC lsm=SMACK fn=smack_inode_permission action=denied subject="User" object="System::Privileged" requested=r pid=2765 comm="tlm-sessiond" name="environ" dev="proc" ino=23193
Jan 01 09:08:55 localhost audit[2765]: AVC lsm=SMACK fn=smack_inode_permission action=denied subject="User" object="System::Privileged" requested=r pid=2765 comm="tlm-sessiond" name="sched" dev="proc" ino=23194
Jan 01 09:08:55 localhost audit[2765]: AVC lsm=SMACK fn=smack_key_permission action=denied subject="User" object="System::Privileged" requested=r pid=2765 comm="tlm-sessiond" key_serial=
185875009 key_desc="_uid.5001"
Jan 01 09:08:55 localhost audit[2765]: AVC lsm=SMACK fn=smack_file_open action=denied subject="User" object="System::Privileged" requested=r pid=2765 comm="tlm-sessiond" path="/opt/var/log/wtmp" dev="mmcblk0p3" ino=822
A tlm-sessiond only create the shell process in /etc/passwd directly, and this shell process does nothing.
So, changing tlm's smack from "User" to "System" does not change user systemd and its associated processes.
===========================================================================================================================
sh-3.2# pstree -p | grep tlm
|-tlm(551)-+-tlm-sessiond(567)-+-bash(622)
| | |-{tlm-sessiond}(569)
| | `-{tlm-sessiond}(572)
| |-{tlm}(565)
| `-{tlm}(566)
sh-3.2# ps -auxZ | grep tlm
User root 551 0.0 0.2 25912 2672 ? Ssl 11:23 0:00 /usr/bin/tlm
User root 567 0.0 0.3 26848 3104 ? Sl 11:23 0:00 /usr/bin/tlm-sessiond
sh-3.2# ps -auxZ | grep 622
User owner 622 0.0 0.1 4628 1068 tty7 Ss+ 11:23 0:00 /bin/bash <== shell process
Change-Id: I7376be55ea57ab187a79ab99721e05e1d8ea38a1
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Thu, 17 Sep 2020 11:07:42 +0000 (20:07 +0900)]
Remove logging to /var/run/tump and /var/run/wtmp
1. Tizen does not use this functionality.
2. Systemd also removed this functionality.
3. Resolving Smack error
- Jan 01 09:08:55 localhost audit[2765]: AVC lsm=SMACK fn=smack_file_open action=denied subject="User" object="System::Privileged" requested=r pid=2765 comm="tlm-sessiond" path="/opt/var/log/wtmp" dev="mmcblk0p3" ino=822
Change-Id: I7aa5f22fe509831afd19f629fd531119c2aac3e0
Adrian Szyndela [Mon, 3 Feb 2020 12:41:31 +0000 (13:41 +0100)]
rework deprecated g_type_class_add_private()
g_type_class_add_private() is deprecated in glib2 since 2.58.
Use G_ADD_PRIVATE() macro with the G_DEFINE_* family of macros instead.
Change-Id: I7884280aea752cc46a8df7a8440c4709b3a998d2
Signed-off-by: Adrian Szyndela <adrian.s@samsung.com>
Yunmi Ha [Mon, 30 Dec 2019 06:12:27 +0000 (15:12 +0900)]
Remove compile warning for GCC-9
- duplicate-decl-specifier
- stringop-overflow
Change-Id: I00d982265657becd05cb9bed068a167b9304d417
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Karol Lewandowski [Wed, 21 Nov 2018 14:37:49 +0000 (15:37 +0100)]
Revert "Revert "Depend on SmackProcessLabel= to set correct label instead of pam""
This reverts commit
31e9e250b73d3f9190a579b262af8bab1384727f.
The problem was in security-config package that removed the service
file during image creation stage. The removal was caused by change
(SmackProcessLabel=) that didn't match its own "saved" policy.
Change-Id: I4702acf22690e91759edc2da77a6ac46f32fd188
Hyotaek Shim [Mon, 19 Nov 2018 06:44:25 +0000 (06:44 +0000)]
Revert "Depend on SmackProcessLabel= to set correct label instead of pam"
This reverts commit
a48ee08ebb7de0d90d2c29a7d792b19654ee470a.
Change-Id: Iada206046ff4c0454223ae00aa9bfdc5bcfc5a32
Karol Lewandowski [Thu, 15 Nov 2018 12:53:55 +0000 (13:53 +0100)]
Depend on SmackProcessLabel= to set correct label instead of pam
pam_smack.so has been removed as for our use-case it is enough to set
appropriate label via systemd SmackProcessLabel.
Change-Id: Ia5f9a9f1e6f2809408b090b8e2805db7968a36a9
Karol Lewandowski [Thu, 13 Sep 2018 08:20:33 +0000 (10:20 +0200)]
Do not create owner user
Default system user ('owner') is also created in kickstart, where
it's adjusted for the platform requirements.
This commit removes the duplicate.
Change-Id: I3e2268ff961ad14e2194e857751846cd25bfe2a7
Hyotaek Shim [Tue, 3 Apr 2018 10:17:30 +0000 (19:17 +0900)]
Apply Full RELRO linker options ("-Wl,-z,relro,-z,now") to tlm-sessiond
In addition to Partial RELRO, Full RELRO makes GOT Table read-only.
Change-Id: I5a9abd9ca22295cc5c2874c91f4114cb78c7218f
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 3 Apr 2018 10:15:24 +0000 (19:15 +0900)]
Remove unused files (Makefile.in)
Change-Id: I7e4cafadd180d038c56cb1aaf00f3a8a547c01fb
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 3 Apr 2018 10:05:40 +0000 (19:05 +0900)]
Apply Full RELRO linker options ("-Wl,-z,relro,-z,now") to tlm daemon
In addition to Partial RELRO, Full RELRO makes GOT Table read-only.
Change-Id: Ic4045ee59e0ddb09954b7c21c7a8afb05b61e8de
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 3 Apr 2018 08:52:34 +0000 (17:52 +0900)]
Remove unused .in Autotools output files
Change-Id: I6e80c4e87c0735478b94afa502dc5e53706e119d
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Fri, 13 Oct 2017 08:44:42 +0000 (08:44 +0000)]
Coverity fixes.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I748823213a6b441144c8d4c192150b73cd60dcfc
INSUN PYO [Fri, 13 Oct 2017 08:00:24 +0000 (08:00 +0000)]
Coverity fixes.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I4c97fe67a8d4771b0e0fc8ca56e7b7d235f334aa
INSUN PYO [Fri, 13 Oct 2017 07:02:34 +0000 (07:02 +0000)]
Coverity fixes.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I25429182917b7911ec95a73f65f912e22091461c
INSUN PYO [Fri, 13 Oct 2017 03:56:40 +0000 (03:56 +0000)]
Coverity fixes.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I2027e8868d282f768053a671ecbdf27256ee502b
Yunmi Ha [Wed, 13 Sep 2017 08:39:01 +0000 (17:39 +0900)]
Change binary file mode
tlm-launcher binaries should be run as root.
Remove all permissions except root to prevent running as other users.
Change-Id: Ib69259f191f22702f40741c6d20e7dec81444e76
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
(cherry picked from commit
f090a1bb056d2d7ed3cc319cf67ff2fed52a469b)
Yunmi Ha [Fri, 8 Sep 2017 05:32:38 +0000 (14:32 +0900)]
Remove build warning
Change-Id: I9c95e3ef9a089bd3edf3a11bd200cc5b06c55dde
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 24 Aug 2017 08:09:34 +0000 (17:09 +0900)]
Modify error handling logic
1. Fix timer handle leak
2. If session error is occured during termination,
skip the logic related session object.
Change-Id: If2462e9d923e087648009608d91b5aa57819b4a0
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
INSUN PYO [Mon, 5 Jun 2017 01:01:13 +0000 (10:01 +0900)]
[DBUS] change user socket address from $XDG_RUNTIME_DIR/dbus/user_bus_socket to $XDG_RUNTIME_DIR/bus
Sync to upstream.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I016c9c0ba958c756451edb8fc52694f47f5fac0a
Yunmi Ha [Fri, 28 Apr 2017 00:27:49 +0000 (09:27 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: I4b800d53fd3baa51262d8f848917a5bd899f711f
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 13 Apr 2017 07:40:16 +0000 (16:40 +0900)]
Remove system function for security
system function makes security issue.
for that, replace it to more safe function.
Change-Id: I4a15dcf37726a4b29f9c38e71a0937ba98b823c2
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 4 Apr 2017 01:27:24 +0000 (10:27 +0900)]
Fix bug: memory leak
Add memory free code for several leaked memory.
Change-Id: I733762a26c279e4bae07ab134a5980ac83b5e95c
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 28 Mar 2017 07:33:57 +0000 (16:33 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: Iafc39f9c439e15bbc8ca9cee22b4cf80cc676a73
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 27 Mar 2017 07:56:40 +0000 (16:56 +0900)]
Install license file to /usr/share/licenses
Need to install license file per each rpm package.
Add this logic for config-file package.
Change-Id: I2d7832a19ee088a95cb0a1a9d46aef2a0395edc8
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Mon, 27 Mar 2017 06:58:44 +0000 (15:58 +0900)]
Fix memory leak issue
Change-Id: Ib2c6f239f055af390940e957a9a676f55ce16081
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 23 Feb 2017 09:29:08 +0000 (18:29 +0900)]
Fix incorrect requirement and service enable code
1. Replace requirement gumd to gum-utils.
(tlm uses gum-utils binary when add default user)
2. Move tlm service enable code to tlm package.
most of tizen system service is located %{_unitdir}.
And for tracking rpm package information of tlm.service,
move and add service link to tlm package.
Change-Id: I3ef9a8e517a200d674661be491599cfd3b26213e
MyungJoo Ham [Wed, 2 Nov 2016 05:17:42 +0000 (14:17 +0900)]
[4.0] Remove Profile Build Dependencies
1. This is for Tizen 4.0
2. Remove temporary ivi profile configuration
(This is preparence for supporting multi-seat environment.
When platform support multi-seat environment, should be reverted and devided this.)
Change-Id: I22647edbe268c7a092ff5540ea03145b27e516dc
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Yunmi Ha [Thu, 12 Jan 2017 06:11:04 +0000 (15:11 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: Icdd251ed111e66299123dcfb05ffa6088741ebc4
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 20 Dec 2016 07:34:41 +0000 (16:34 +0900)]
Change binary file mode
tlm and tlm-sessiond binaries should be run as root.
(For managing opened user session)
Remove all permissions except root to prevent running as other users.
Change-Id: If21befb41733370648d56b0bae85d8c7fb9f8cf7
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 13 Dec 2016 10:27:50 +0000 (19:27 +0900)]
Add error handling code
When fail to get system bus, TLM makes core dump.
Reason: tlm doesn't check any dbus connection.
Solution: Add connection checking logic.
tlm must be connected to dbus service.
So If tlm failed to connect dbus, it will be shut down.
Change-Id: If5b35fdc8e950c1ea3062df76c6eb16ae4c09b21
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 30 Nov 2016 08:29:19 +0000 (17:29 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: I972ba1de0dd4f47d21577a3b2de4483d1ee2d0d3
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 30 Nov 2016 07:37:57 +0000 (16:37 +0900)]
Fix some security holes
- Uninitialized data is read from local variable : Add initializing logic
- unreachable code : Add string length chekcing logic
Change-Id: I595494f01046b69b7afec6facd0cf1701e72f965
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Kunhoon Baik [Thu, 27 Oct 2016 00:12:07 +0000 (09:12 +0900)]
Ingore SIGPIPE default behavior
TLM session daemon uses several communication libraries like syslog, pam, and so on.
Thus, basically it should handle SIGPIPE.
Otherwise, the daemon will be exited unexpectedly, it will make user-session unstable.
Change-Id: Idd52ba703f3e732b6ccc6c9f1a35c18a952c0f9b
Kunhoon Baik [Thu, 27 Oct 2016 00:12:07 +0000 (09:12 +0900)]
Ingore SIGPIPE default behavior
TLM session daemon uses several communication libraries like syslog, pam, and so on.
Thus, basically it should handle SIGPIPE.
Otherwise, the daemon will be exited unexpectedly, it will make user-session unstable.
Change-Id: Idd52ba703f3e732b6ccc6c9f1a35c18a952c0f9b
Yunmi Ha [Fri, 7 Oct 2016 06:51:53 +0000 (15:51 +0900)]
Add delayed login logic
If "/run/systemd/users/%uid%" dir was existed,
it means that previous user session was not ended yet.
In this case, register delayed login and wait.
(check every 3 seconds.)
Change-Id: I9db36bb01e073c15755043d4be83ebac48a0f335
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunjin Lee [Wed, 20 Jul 2016 11:31:16 +0000 (20:31 +0900)]
Set SmackProcessLabel to System
Change-Id: If9d9c29392ec8dd9de5f382692fb07f00f792fc8
Signed-off-by: Yunjin Lee <yunjin-.lee@samsung.com>
Yunmi Ha [Thu, 30 Jun 2016 09:05:56 +0000 (18:05 +0900)]
Remove unused files
- these files include nfc authentication logic for guest user.
Change-Id: Ia044e362bf8947a4558c2337ee0db2720a4207e2
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Fri, 17 Jun 2016 04:35:20 +0000 (13:35 +0900)]
Add NULL check logig
After malloc, need to check return value.
Change-Id: Ifcf45e72ea6c27389ff40548a1632ed6574f868d
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 16 Jun 2016 05:36:57 +0000 (14:36 +0900)]
Remove samck capability
Need to remove smack capability from root daemon.
Change-Id: I7586b84a8d43fb72f91f12fa9e6345c7fb483273
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Thu, 16 Jun 2016 02:43:29 +0000 (11:43 +0900)]
Add negative number checking logic before ssprintf function.
When converting string to unsigned int,
it can be tainted with negative value.
So before converting, check the negative value.
Change-Id: Ib6cada03a25440599d3d093c4220c64b63782ab0
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 27 Apr 2016 00:38:42 +0000 (09:38 +0900)]
move default_user adding logic from kickstarter
Change-Id: Ifa4f6c1177f5fb8de2697f0f17208845df92255b
Yunmi Ha [Mon, 18 Apr 2016 05:39:36 +0000 (14:39 +0900)]
Fix warining message \n - format '%s' expects argument of type 'char *', but use type 'int'
Change-Id: I3b1d74e1b66bcccc7c1a6bcb0bbbcc3f247b488c
Woo Chang Kim [Thu, 31 Mar 2016 08:10:18 +0000 (01:10 -0700)]
Revert "Add elf_base_scale function for support multi-scale feature"
This reverts commit
08bbf6e1e69e2d3da85896b94820599d4d1832d1.
Change-Id: I06195aeecb7149c0501d6570da903e2af1922875
Yunmi Ha [Thu, 31 Mar 2016 04:23:12 +0000 (13:23 +0900)]
Add elf_base_scale function for support multi-scale feature
Change-Id: I4c61ebb91dfe0b5243a71a6ad47303cfbe66b99f
Yunmi Ha [Thu, 24 Mar 2016 08:21:02 +0000 (17:21 +0900)]
Fix svace issues for Tizen_3.0_TV_Prebeta
replace thread unsafe functions
- syserror
- ttyname
- getpwnam
Change-Id: Ie7b6f62507edf33ef777c2b05cb6877dcea46778
Suchang Woo [Thu, 18 Feb 2016 10:40:02 +0000 (19:40 +0900)]
Add config-common packages to all profile
Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: Ibc93de3d60c27e51465ac09702ad2603956788e9
Suchang Woo [Mon, 28 Dec 2015 02:12:25 +0000 (11:12 +0900)]
Add 'pam-module-extra' requires
tlm-login, tlm-system-login, and tlm-default-login use pam_smack.so
which is included in pam-module-extra package
Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: I9be423c0d6023a2920e76e07df35264625cadcfc
Suchang Woo [Thu, 10 Dec 2015 02:35:53 +0000 (11:35 +0900)]
Add PIE option for Address space layout randomization
Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: I63f265bd1968e91f4185667d1c58208754bbca0f
Youmin Ha [Wed, 25 Nov 2015 05:56:33 +0000 (14:56 +0900)]
Prevent abnormal abort of the tlm daemon on duplicated login
Changed ERR macro to WARN, to prevent abnormal abort of the tlm
daemon.
Change-Id: Id8284557396f84f53dea74c9609e8d529ce89379
Aleksander Mistewicz [Fri, 20 Nov 2015 10:38:14 +0000 (11:38 +0100)]
Add user 'owner' to configuration
It is required that user 'owner' appears on the screen as otherwise
all app_launches would fail and in effect native_tct too.
Change-Id: I6f6a970d490c783a96c0c5e5f4ae3d9531df6166
Signed-off-by: Aleksander Mistewicz <a.mistewicz@samsung.com>
Suchang Woo [Fri, 30 Oct 2015 12:45:09 +0000 (21:45 +0900)]
Fix segfault
seat can be NULL but it is used in _is_valid_switch_user_dbus_request()
without NULL check.
Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: I56ab152b49230f862d5d83e82ac6eef4863deafe
Suchang Woo [Tue, 13 Oct 2015 08:40:51 +0000 (17:40 +0900)]
Remove compile warning messages
* missing braces around initializer
* unused variable
Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: I368918fa2525afb0c0d23c969ca4506d328e566a
Youmin Ha [Tue, 13 Oct 2015 05:14:10 +0000 (14:14 +0900)]
Fix memory leak
The string got from tlm_seat_get_occupying_username() must be freed
after used. This commit fixes the memory leak.
Change-Id: If05dae74ad2027cd6c9bf81ce2d43e608d4982b9
Signed-off-by: Youmin Ha <youmin.ha@samsung.com>
Youmin Ha [Tue, 13 Oct 2015 04:59:44 +0000 (13:59 +0900)]
Fix wrong error handling
tlm_seat_*() functions return TRUE on success, but the error handling
routine works wrong. This commit fixes it.
Change-Id: I12d32bff7460398b73e5a1aa512188456f13a3da
Youmin Ha [Mon, 12 Oct 2015 13:04:39 +0000 (22:04 +0900)]
Fix prevent issues
This commit fixes following prevent CIDs:
* 458876: Avoid copying string which cannot be null-terminated
* 459717: NULL-check after memory allocation
* 461686: NULL-check tainted scalar(string read by fgets())
* 462630: NULL-check after memory allocation
* 466499: NULL-check after memory allocation
* 470326: NULL-check after memory allocation
* 471806: NULL-check after memory allocation
* 472387: NULL-check after memory allocation
* 475993: NULL-check after memory allocation
Change-Id: Ie33494a2055528ae1c8b8ffb296a2111c3468e95
Youmin Ha [Thu, 25 Jun 2015 06:31:54 +0000 (15:31 +0900)]
Fix infinite running of _process_request()
Previous code runs _process_request() continuously even when the queue
is empty. This commit fixes the bug.
A refactoring on tlm-dbus-observer module is added; The routine getting
active_request is separeated.
* Fixed a build break when DEBUG option is off.
Change-Id: If26e092f687ca2ec57f86182911c49a5ef27d227
Signed-off-by: Youmin Ha <youmin.ha@samsung.com>
Youmin Ha [Wed, 13 May 2015 06:54:51 +0000 (15:54 +0900)]
Block switching to same user as an user occupying current seat
Switching to same user as the current user raises a abnormal behavior,
failing on re-login process. This is due to the inconsistance between
the tlm-sessiond daemon lifecycle and the systemd-logind's logout
procedure.
The standard solution is to receive a sessionTerminated signal from the
systemd-logind and sync it to the re-login procedure of TLM, but it
will take many structure changes of tlm-sessiond.
This patch just blocks switching to same user, preventing the abnormal
case with just a small effort.
* src/daemon/tlm-seat.c|h: tlm_seat_get_occupying_username() is added.
* src/daemon/tlm-dbus-observer.c: _is_valid_switch_user_dbus_request()
is added and used in _process_request().
In addition, several comments and debug logs are given.
Change-Id: I9238098771bcce2b40aa89da47e9391ff7556922
Youmin Ha [Fri, 25 Sep 2015 02:31:04 +0000 (11:31 +0900)]
Fix invalid memory read bug
Fixed a bug that tries to memcpy(read) 4*4bytes(AF_INET6) even
when the ai_family is AF_INET(4bytes).
Change-Id: I7570b40396d62c3c508cf5a290c97ff8403ee396
Signed-off-by: Youmin Ha <youmin.ha@samsung.com>
Sangjung Woo [Wed, 29 Apr 2015 01:46:58 +0000 (10:46 +0900)]
tlm-client: make tlm-client utility running as normal user privilege.
This patch makes to run tlm-client utility as normal user instead of
ROOT privilege. That functionality is necessary to test for switching
users as application privilege. What if launching tlm daemon itself,
ROOT privilege is still necessary.
Change-Id: I705a7a92c090bf53106cd0d1ef1762d633884f50
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Jiyoung Yun [Mon, 13 Apr 2015 06:18:28 +0000 (15:18 +0900)]
Add common config for singleseat
The existing common config install tlm-default.conf file and
it will link in tlm.conf file when common-config is installed.
The common-singleseat will be included in mobile, tv and wearable profile.
Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
Change-Id: I30e02602ac1048c675d0d9097c9c5db10235ec54
Jussi Laako [Fri, 10 Apr 2015 10:17:44 +0000 (03:17 -0700)]
Merge "fix the closing session bug, even if next user authentication is failed." into tizen
Sangjung Woo [Wed, 25 Mar 2015 12:27:41 +0000 (21:27 +0900)]
fix the closing session bug, even if next user authentication is failed.
When switching user by calling switchUser method, current opened session
is closed without verifying the next user authentication (i.e. username
and password). Because of this reason, there could be no remains session
in case of failure of user authentication for next user.
This patch checks the next user authentication and immediately return
FALSE when failed so that current session is not terminated. PAM service
name is specified in /etc/tlm.conf to change easily. (Default system-auth)
Change-Id: I794243faa7ebaf47f53bdf9b9368e14dbf8c509a
Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
Imran Zaman [Thu, 2 Apr 2015 10:28:55 +0000 (03:28 -0700)]
Merge "Clear session pointer when creation is failed" into tizen
José Bollo [Mon, 30 Mar 2015 11:40:00 +0000 (13:40 +0200)]
Workaround systemd bug of user sessions
Systemd (up to at least 2.19) has a bug in stopping and
restarting user sessions. This patch fix it in a such way
the session is never closed.
Change-Id: I348fae16d43f3746627d2181b4d579fe5f77bd25
Signed-off-by: José Bollo <jose.bollo@open.eurogiciel.org>
Suchang Woo [Sat, 7 Mar 2015 04:55:47 +0000 (13:55 +0900)]
Clear session pointer when creation is failed
When a remote session creation is failed, a pointer pointed to remote session
object should be reset. A pointer pointed to destroyed object can make
segfault.
Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: I1c8f4e015d56e4a86c252d2188455636896665c8
Imran Zaman [Wed, 18 Feb 2015 14:54:10 +0000 (16:54 +0200)]
Move the tlm dbus interface under org.01
tlm-launcher is used to launch session scripts
Change-Id: If8c165b3d1a3e5b08288deb532cb6905325c33c0
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Fri, 23 Jan 2015 15:46:04 +0000 (17:46 +0200)]
session: fix terminal reset functionality
session: cleanup terminal handling code
Change-Id: I74f366af80d79219c522279ebfe67bcabece7f71
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Fri, 16 Jan 2015 15:21:53 +0000 (17:21 +0200)]
Guest user home directory is cleaned up on logout
Change-Id: I18e2d1e7117905b2e04b7644bbdbade339f2f3f5
Fixed Bug TC-2370
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Thu, 15 Jan 2015 14:26:46 +0000 (16:26 +0200)]
Added tlm-launcher
Reverted SIGINT patch
Change-Id: Ib1a55d4fce2ac48b19bbb1514410b85a2f6ed770
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Wed, 14 Jan 2015 14:56:32 +0000 (16:56 +0200)]
Fixed keyboard bug
keymap_layout=wkb was missing from weston-genivi*.ini
Change-Id: I57539b63b5d77c271b3a934550e35db129704d6b
Fixed Bug TC-2341
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Tue, 13 Jan 2015 15:25:26 +0000 (17:25 +0200)]
CTRL-C caused the weston process to exit
when Weston is active, any keyboard events should not go
to the console. Instead, Weston open the evdev device,
and get kbd input through that.
Change-Id: Ie82b9d9e681422956979e9446b9eb765151b6c2e
Fixed Bug TC-2318
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Mikko Ylinen [Mon, 12 Jan 2015 11:31:01 +0000 (13:31 +0200)]
weston-genivi-modello: Do not disable VGA output
It's not necessary to explicitly disable VGA output. This
breaks automated pre-release tests where only VGA monitors
are being used.
This configuration is better aligned with weston-genivi.ini
too.
Change-Id: If447cedd3f4d9a91cf2948dbd3ab0becebf67937
Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Imran Zaman [Fri, 9 Jan 2015 14:31:12 +0000 (16:31 +0200)]
Keep current-mode for configurations other than modello
Change-Id: I93bc908d7316a763e44d160e3474ba147fe3b30e
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Amarnath Valluri [Fri, 9 Jan 2015 13:51:52 +0000 (05:51 -0800)]
Merge "Updated modello script and configuration for weston" into tizen
Imran Zaman [Fri, 9 Jan 2015 13:45:39 +0000 (15:45 +0200)]
Updated modello script and configuration for weston
Change-Id: Ia0cae21028637c8cd88c343b4d557bed5adf34ac
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Wed, 31 Dec 2014 14:05:15 +0000 (16:05 +0200)]
Use weekeyboard for Tizen IVI user session
Change-Id: I4cd7d958437482abf6b7ffdbef67dd087ea94bd5
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Tue, 30 Dec 2014 13:18:06 +0000 (15:18 +0200)]
fullscreen shell does not support virtual keyboard
Change-Id: I1b60ff89be3e3de7a9ceb208c2f204d92d426a5b
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Mon, 29 Dec 2014 14:21:41 +0000 (16:21 +0200)]
Fixed dependency for modello configuration
Change-Id: Ia53ce598ea68c1b23af6398fb9d58a0e02116503
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Tue, 23 Dec 2014 16:44:16 +0000 (18:44 +0200)]
Added config packages for modello and ico homescreen
Change-Id: I53d63f3f5b9d0592f3b88bd1729a3dc732e7602c
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Fri, 19 Dec 2014 15:28:19 +0000 (17:28 +0200)]
Added session script for ICO homescreen
Moved tlm to multi-user target
Change-Id: I9f7693cd76b460132d9dcb756ff9e22c5fab4048
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Mon, 15 Dec 2014 15:50:56 +0000 (17:50 +0200)]
packaging: fix update installation
Change-Id: If0465177edd7e94ee98f6bbc4037e18581a3fa75
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Mon, 15 Dec 2014 13:40:47 +0000 (15:40 +0200)]
tizen: release 1.0.2
session script updated along with cleanup of
spec file
Change-Id: Ibece818e70a0c1273322385b29c38558c5fd50e2
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Ronan Le Martret [Wed, 10 Dec 2014 11:13:53 +0000 (12:13 +0100)]
clean spec file for yocto compliance
- remove full path for tool file
- /etc/xdg/weston is only packaging into ivi package profile.
Change-Id: I236497ab7b0faf810e3997965aa2743833bae9db
Signed-off-by: Ronan Le Martret <ronan@fridu.net>
Imran Zaman [Tue, 9 Dec 2014 17:34:32 +0000 (09:34 -0800)]
Merge "Enable tlm when installing tlm-config-common package" into tizen
Imran Zaman [Tue, 9 Dec 2014 17:27:06 +0000 (19:27 +0200)]
Enable tlm when installing tlm-config-common package
Change-Id: I903197dd2a70d470292fcfb25f8bd9e889285924
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Manuel Bachmann [Mon, 8 Dec 2014 16:45:13 +0000 (17:45 +0100)]
Little fix on session script for Tizen Common
Simplify the script.
Change-Id: I48bd5e899457eb7843a3982e7e3e753912dce7c2
Signed-off-by: Manuel Bachmann <manuel.bachmann@open.eurogiciel.org>
Imran Zaman [Fri, 5 Dec 2014 15:06:54 +0000 (17:06 +0200)]
Enable tlm by config package instead of main package
Change-Id: Ie941fc1ab289f96121ac40940a69ee7c70563a38
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Thu, 4 Dec 2014 14:32:23 +0000 (16:32 +0200)]
Fix session scripts and package update
Change-Id: Ia796872f3eec0b0e6698d9d1d5e626b75728342d
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Wed, 26 Nov 2014 16:26:08 +0000 (18:26 +0200)]
Updated config and session scripts for Tizen Common
Change-Id: Ie78149dd71cc83b3a2f8dae39856ac404ac6fc5a
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Mon, 24 Nov 2014 16:25:29 +0000 (18:25 +0200)]
Add multi-configuration for Tizen IVI and Tizen Common
Change-Id: Iabb0c6b66dc7adb083ccf29596df43fbac12c01d
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Mon, 17 Nov 2014 13:12:14 +0000 (15:12 +0200)]
Fixed spec file for tizen mobile
Change-Id: Ia38166d73a3ba053d53f00c765c0f7b9fac8c6b2
Signed-off-by: Imran Zaman <imran.zaman@intel.com>
Imran Zaman [Mon, 17 Nov 2014 12:52:11 +0000 (14:52 +0200)]
Build package with profile specific configuration
Change-Id: I8906155972d17fb860d15f839fdc6a0fef63c0b4
Signed-off-by: Imran Zaman <imran.zaman@intel.com>