Do not process the finalize in the nested call.

Change-Id: I056b5953cff53c6053412b56c6be4a31aa7c33ba

Sync with the latest tizen 2.4

Change-Id: I96e0793552eb298334ec6483a6e4c3a1f0d12cc1

Fix the memory alignment issus by padding.

Change-Id: If30e154b77f23b72588fbf4cf9be1082d0d6f4e6
Signed-off-by: Kyuho Jo <kyuho.jo@samsung.com>

Fix the 64 bits build error

Change-Id: I94cda4dc3b64a39dbb677334d1a0e5b0090c309b

BUFSIZ is replaced with payload_size

At least now, while I make a product using this code.
There is no such problem what I read from history in Tizen 3.0.
If the crash occurred when allocating heap more large size than BUFSIZ,
It mean somewhere else is broken.

It could be caller of this function.

The problem should be invetigated again.

If you really think that the problem is caused by this.
Please let me know it. contact to me.
We need discuss it.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I3b3c46b7c023a5805a4bb63081049e9a534e9ecc

Sync with the latest 2.3.1

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I46bb8c0de37684f42ce59511816a7149cc7ab9b5

Recover from unexpectedly overwritten code.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: Ia65375bffb1fd08968eec63cf79983fa71691f2f

Merge ssh://slp-info.sec.samsung.net:29418/magnolia/framework/appfw/com-core into tizen

Conflicts:
CMakeLists.txt
include/com-core.h
include/com-core_internal.h
include/com-core_packet-router.h
include/com-core_packet.h
include/com-core_thread.h
include/packet.h
include/secure_socket.h
packaging/libcom-core.changes
packaging/libcom-core.spec
src/com-core.c
src/com-core_packet.c
src/com-core_thread.c
src/packet.c
src/secure_socket.c

Sync with the latest private implementations

Change-Id: I8aec4d532b687226d29eb11c18332a2cabc4f5e3

Merge branch 'devel/home/master'

Change-Id: I4a31fe755296f79fa6f143f1f8b1a567c1ad087d

guint could not be below ZERO.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I0b30520819bc0ab0f5ffb0ac10765d8102312027

Add new attribute to packet

to share the fd with the other process.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: Icf5055120ecb0bc17d163164bd93f0c23a861c6e

Merge branch 'devel/home/master'

Add new API for compatibility instead of changing API signature.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I721703d1ba4271ffdb07865d151bb868e7cf7464

Use the system thread

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I1b4596df67ef59654bcb8b1eacee46fc3ad4d4fd

Add new method for sending/receving file descriptors

between local processes.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: Ifbcbae54f95c176bf585d3be2f6266460bd27434

allocate BUFSIZ size instead of payload_size when creating packet

Using notification API, it appears that allocating payload_size
when creating a packet could makes notification-service crash sometimes
when removing a notification.

Checking some packet sizes shows that allocates BUFSIZ is enough and
fix the problem.

Change-Id: I4b1d134fe43b235b586ba184053134299cc56cb0
Signed-off-by: Corentin Lecouvey <corentin.lecouvey@open.eurogiciel.org>

Revert "Keep address alignment to prevent from bus error."

This reverts commit 1ce8ea32c6b0943454823d642d961cd8b3e1c8f0.

This change is not compatible with 64 bits system.
In some cases, it generates a segfault in packet_create()
when allocating memory for packet->data struct with calloc.

Btw according to the reverted commit message, this commit was a consequence
of errors with GCC 4.6 that we do not use anymore.

Change-Id: I56a23552df1d84aefa83fac4d60121d2545213b7
Signed-off-by: Corentin Lecouvey <corentin.lecouvey@open.eurogiciel.org>

Merge branch 'devel/home/master'

Change-Id: I31cd3a2f762d8b2ca3757e75dfee893dad2800dc

Add new command processing method.

If a command string is started with 0x01,
it will be treated as an integer type.

It could be used as an index of the command table.
It will increase the command handler searching time.

[model] Redwood,Kiran,B3(Wearable)
[binary_type] AP
[customer] Docomo/Orange/ATT/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I6a6be27e01ac0e00b2124ac1132d6b6e466bf99d

Merge branch 'devel/home/master'

Change-Id: Iee8eef0fc00c5f820aba5e409c00266c337c5042

Update return vale - for exceptional case

Change-Id: I58823aa462ac6728773095448214fac58652214a

Merge branch 'devel/home/master'

Change-Id: Ic4f34a59fa2716d258f36aef6411878c6a53246f

Clean up all resource for non-threaded IPC.

Change-Id: I50c9f6f02580d8390307045278fdef0999a65cbb

Validate socket FD & optimize recv context.

From the recv ctx callback, the socket can be closed.
But the glib cannot detect the closed FD correctly.
(It doesn't toggles G_IO_HUP, G_IO_ERR, G_IO_NVAL bits even though I closed the FD)
So I checked the FD from the callback explicitly, before return from it.
However this patch will be available only for the Single-Thread loop. (com-core)

And the receive context is optimized.
Every single loop after done to prepare A receive context,
it will be destroyed. But this patch will reuse it instead of destroying it.
So there is no need to reallocate same memory again.
It will save few milli (or micro) seconds.

for the future-work.
I'll optimize the "packet" creating code.
It can be reused too after finish the processing of receive context.
Then we can save more few milli(micro) seconds (for reallocating time).

Each execution takes small time.
But this scenario occupies almost time for communicating with other processes.
it means, even though it can save few milli(micro) secs for each time.
The total saved time will be meaningful.

Change-Id: Ibb3adc715090b6d78a5cfeb48d28463f35b9a0f4

Merge branch 'devel/home/master'

Optimize the perf / validate FD.

Reduce the malloc for handling the receive context.
Validate socket FD.

Change-Id: Ia492e7d0a23dd233f6227676aa2beee94d106a6c

Validate context before destroy it.

dlist_remove_data always find the data before delete the item.
This patch will find the item first like dlist_remove_data.
but if there is no item in the list,
do not release it. just skip the destroy function call.

Change-Id: Ia15fa5c7dc3f283a19e7b5109c3c5796623b55d2

Merge "Keep address alignment to prevent from bus error." into tizen

Keep address alignment to prevent from bus error.

for the ugly GCC 4.6

Change-Id: I39d6d6666360f2c66896b14ce7e95c71b15c2496

Merge branch 'devel/home/master'

Keep alignment to prevent from bus error.

Change-Id: I29dc6393c1891d74efbd886ccf36dcb58eff42e0

Merge "Sync with the latest product code of phone profile" into tizen

Merge "Apply Rusty Lynch's systemd socket activation feature." into tizen

Merge branch 'devel/home/master'

Fix build warning

Change-Id: I9bcb9fa619807d972bda86d795e0e984c1091578

Update header (preparing doxygen)

Sync with tizen 3.0 - supporting systemd socket activation

Change-Id: I8fdbb2da60273a76c2493230eb41140105e6438b

Sync with the latest product code of phone profile

Disable O_NONBLOCK option for creating a "pipe".
It makes unpredictable busy waiting problem when it fails to write data to pipe.
In some cases, the consumer thread could not empty the pipe,
the producer thread failed to write with EAGAIN error if the pipe created with O_NONBLOCK.
then the producer thread fall into the busy waiting status.

This patch will keep the producer from busy waiting problem.

Change-Id: I34d1433b4c380deb2bc8f03d476943652de6c23f

Merge branch 'devel/home/master'

Remove NONBLOCK flag from pipes

Change-Id: Ic171862e4f09609d6a69c5c067907638d7ac40a6

Merge branch 'devel/home/master'

[side effect] Fix build error (remove unused variable)

Exit from the loop if it fails to write a char to the pipe

Change-Id: I7e984f9dd87d28200cf241e049a711ff0291b979

Discards the chunks when it fails to queue an event

Change-Id: If94ce60148eab509fc21f5696d046528a35a9aba

Update changelog

Change-Id: I48fea5c3dc6d146cc6118f77c61d89569d6058ea
Signed-off-by: Patrick McCarty <patrick.mccarty@linux.intel.com>

Merge branch 'devel/home/master'

Debug mode enabled

Change-Id: I5b6584acfce760139b8ffada4e469d150ec2723e

PTREL-399: fix build in x86_64
Set LIBDIR to ${LIB_INSTALL_DIR} in CMakeLists.txt

Change-Id: Ic551897588f7d6fc30c5081366a5bf8955204981
Signed-off-by: Stephane Desneux <stephane.desneux@eurogiciel.fr>

Sync with the tizen 3.0

Change-Id: I3a934684888ae00e66b9d374940ef7eb267a3582

PTREL-142: Restore use of %cmake macro

Restore use of %cmake in the spec file so that variables like
LIB_INSTALL_DIR are passed to cmake.

Change-Id: I3ed0b40417728ccbf4e171492ec9a7fc77743097
Signed-off-by: Rusty Lynch <rusty.lynch@intel.com>

Apply Rusty Lynch's systemd socket activation feature.

Add a new SCHEME for systemd's socket activation.
This patch already applied by Rusty Lynch, but before, I just discard it because of syncing with latest 2.2 code.
Now I apply his patch to secure-socket again with new SCHEME.

Please review this code and give me some better idea.

To use the socket-activation feature,
user should use "sdlocal://" scheme

practical example.

case #1. for secure-socket layer (the lowest layer)

int handle;
handle = secure_socket_create_server("sdlocal:///tmp/.sd.socket");

case #2. for com-core layer (the middle layer, which is merged with the g-main loop)
int handle;
handle = com_core_server_create("sdlocal:///tmp/.sd.socket", 0, service_cb, NULL);

case #3. for com-core_packet layer (the highest layer)
int handle;
handle = com_core_packet_server_init("sdlocal:///tmp/.sd.socket", method_table);

Change-Id: If62196bf0bea1855bf40f7fc71ea4b87e6d44dd5
Signed-off-by: Sung-jae Park <nicesj.park@samsung.com>

Merge branch 'tizen_2.2' of ssh://review.tizendev.org:29418/framework/appfw/com-core into work

Applying socket activation should be supported by new API or Schema.
The latest com-core supports the inet & ipc socket communication using schema.
To open/connect a socket, user can select inet or ipc using schema.

remote://IPADDR:port
local://SOCKET_FILE_PATH

practical example

remote://192.168.0.1:1234
local:///tmp/.my.socket

So I just discards the systemd socket activation code now.

I think, it should be supported by new socket URI.
such as

systemd://SOCKET_FILE

This new schema should be added to handle the socket activation mode.

Conflicts:
src/secure_socket.c

Change-Id: Ib2c0d1c7f2d6b0337cd408cba11164626ca87ff4

Merge branch 'devel/home/master'

Try to use the gettimeofday if clock_gettime is failed

Change-Id: Iceda877ff4fee12b3fe702aeb3c904b043258a96

If clock_gettime is failed, try to use gettimeofday again

Change-Id: Ie6ddcab7bcb369dca08b16e5a9b12d84979c1190

Replace gettimeofday with clock_gettime

Change-Id: Ie1e70c0576c9381833981080855cfb9972ae582d

Replace gettimeofday with clock_gettime

Change-Id: Ice0e00e2ffbba6f5a31012b56cf6df0f4884db95

Fix build error

Change-Id: I14c4d05d37c792834ce73aa6a3df2c972a488650

Add systemd socket activation support for secure sockets

Change-Id: I306d315b59a56feb2474bd9a460a50c821aaa50e
Signed-off-by: Rusty Lynch <rusty.lynch@intel.com>

Merge branch 'devel/home/master'

Fix build error

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I8b8cc17a189e72b0009ec40fbd3ef3adbe13314e

Update coding convention.

Even if a block has only one line, it should be begin with { and end with }

Change-Id: I99c7f6d43cd0b673d2d912dd1835d2b57ad1de66

Merge branch 'devel/home/master'

Update coding convention

Use the '{' '}' for local block(if, for, while, ...) even if it has A line.

Change-Id: I29a8d8ab2c6023db66312b2d2ca93b8c4440248a

Remote server/client connection is now supported.

Change-Id: Ic3701c4181f61016bd6375844087ecf9480ce746

Merge branch 'devel/home/master'

Supporting TCP/IP socket communication.

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem]
[cause]
[solution]
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I67f778a2006342b055290bc67c38a88d4ac7d6d2

Resize recv/send socket buffer, TCP_NODELAY enabled.

Change-Id: I959c74dc3c3ddc442176d22ff0df5a3d687b983d

Merge branch 'devel/home/master'

Enable TCP_NODELAY.

Change-Id: I847191cd99c1495b60f9c246a1d453c4ac00ac24

Call the pthread_yield

Change-Id: Ie31c8aea615f1f206fbcd1c5aea5a1d7da030af7

Change the recv/send socket buffer size.

Recv bufsz: 512KB (kernel will double this to 1MB)
Send bufsz: 256KB (kernel will double this to 512KB)
This change is only can be applied by selection of kernel.
So even if I change this, the kernel can change it what it can support.

Change-Id: Ic3119dd82bbaf3845ac34fcf39f2f099cb9a70eb

Merge branch 'devel/home/master'

While processing the ack callback, if user disconnect to server, it can be crashed.

Because the disconnected callback is called and it will delete the receive context.
but the ack callback uses resources in the receive context.
This patch will prevent from crash.

Change-Id: I9015d04b6695e86c532b399de46bdc1fa6f31317

Support the finalize the connection even if it is in the recv callback

While in the recv callback, if the client tries to disconnect from the server,
the recv callback called again. because of disconnected event callback.

This patch will prevent call the same recv callback if it is in process.

Change-Id: Ib9a14849e0ff60ee72770d540bce31ac2c0cc396

Merge branch 'devel/home/master'

Remove last trailing comma

Change-Id: I672c28932e275e6d28fe158c1c2c18ee18172cc1

Remove last trailing comma. To keep the compatibility with old standard.

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem] Some compiler (which keeps old standard) complains the last trailling comma.
[cause] It's a standard.
[solution] Remove the last trailling comma.
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: Id6f59d3caef17116c24a58a186f373c5e942ca01

resetting manifest requested domain to floor

Change-Id: I8bcae93851d6fff94c932363d12467ea7711092d

Merge branch 'devel/home/master'

Update Log Tag

Change-Id: Ic830d5000575d9cd14012589e040ecf2248d70d8

Remove unnecessary logs

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem] Reduce logs
[cause] Too many logs are printed.
[solution] Delete unnecessary logs.
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I84c4e3885d39d343bbd5f0ae11ee4e0b3ac9fa25

Merge branch 'devel/home/master'

Merge branch 'tizen_2.1' into tizen_2.2

Change-Id: Icdd49054d9092107b5a665156eab743603215e54

Update the terminating sequence.

[model] Tizen
[binary_type] AP
[customer] Tizen Developer
[issue#] N/A
[problem] Hangs while terminating thread base com-core.
[cause] When the socket descriptor is used in a thread via "select", main thread should not close it.
[solution] Use the event-pipe to escape from select.
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: Ied7a8eccb4fc7ccb1ea180c1c79bed73d800087e

Disconnected callback should be called even if connection closed by main thread.

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem] Disconnected callback is not invoked.
[cause] When a main thread tries to close the connection, disconnected callback is not invoked.
[solution] Guarantees call of registered disconnected callback even though the main thread explictly close a socket.
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: Ia90480aca9e558d6edeb7b5a9656f89fc0fa5cc4

Merge branch 'devel/home/master'

Thread termination code is updated.

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem] Thread is not terminated. so the process hangs while waiting thread termination.
[cause] If a main thread close the fd, service thread can not detect it.
[solution] Add ctrl-pipe to terminate the service thread. (to wakeup it from select)
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I9d253eefa1b5c3206046cfff1f16ae89798a94fa

Apply Secure Log

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem] Secure Log is not applied
[cause] N/A
[solution] Apply Secure Log
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I0db22ff0472937394d8b3d1183ec2aeaebf02b87

Merge branch 'devel/home/master'

Fix the invalid print code.

Crash occured while printing the integer value as string type.
This patch fixes it.

Change-Id: I064a4643a1586ab3f2f8a69c62e60324ce9331fa

Fix the invalid log print code.

[model] Redwood
[binary_type] AP
[customer] Docomo/Orange/Open
[issue#] N/A
[problem] Crash occured
[cause] print an integer as string type.
[solution] Fix it
[team] HomeTF
[request]
[horizontal_expansion]

Change-Id: I20c6fdc2b56841acb3bf32b5eecac804853474b6

Changes : Fix x86_64 build-install compliance

Change-Id: I51b980eaba16fe84d24e1a9a8494a7ad2e5ddc9f

Fix x86_64 build-install compliance

  - Fix hardcoded library path in CMakeLists.txt
  - Use %cmake macro to set default path
  - Change library path var in *.pc.in template file

Change-Id: Ifa4e287597670f30de0968f96010f087de0eebf9

Merge branch 'devel/home/master'

Resolve the prevent issue.

CID 52800

Change-Id: Ia5b6872874cdcb26cd810703bac7b343cb825145

Fix the accessing released memory bug.

Change-Id: I906f8e9a363f719d50c9204fd29363ca0a0a63ad

Various patches are applied.

Patch 3/3
Do not update chunk->size using return of recv.
Update logging message

Patch 2/3
Update com-core.
Remove pthread_cancel.

Patch 1/3
Put complains of the valgind to sleep calm.

Change-Id: I75503d691b09b70a891e12ed5342cb634ca814b6

Merge branch 'devel/home/master'

Do not update chunk->size using return of recv.

Update logging message

Change-Id: Ie877e765c80f66ac949d0c9826f4be10c69a1c18

Update com-core.

Remove pthread_cancel.

Change-Id: I3a0dcb10d33efda33cc4d311c2eedefed6787d1b

Put complains of the valgind to sleep calm.

Change-Id: I3c1fadce91bc2fed987a7b4c2f146b12bedc31df