Mike Schuchardt [Fri, 2 Sep 2022 00:00:47 +0000 (17:00 -0700)]
build: Update to header 1.3.226
- Update known-good
- Update sync_val_generator.py with renamed mesh shader enums
- Disable spv::CapabilityMeshShadingEXT in spirv_validation_generator.py
until shader toolchain is updated
- Bump vktestbinding extension buffer size as there are now more than
256 device extensions in this header
- Generate source
John Zulauf [Fri, 2 Sep 2022 17:46:33 +0000 (11:46 -0600)]
syncval: Fixes to Barrier Hazard logic
Clean and simplify the logic to allow CTS passage for submit subset.
John Zulauf [Thu, 1 Sep 2022 20:14:00 +0000 (14:14 -0600)]
syncval: Fix SYNC-HAZARD naming to be consistent
Consistent with each other and VUID style.
John Zulauf [Thu, 1 Sep 2022 19:58:39 +0000 (13:58 -0600)]
syncval: Hazard usage message cleanup
add missing and remove extra punctuation and spacing. Fix command
name capitization.
paul-lunarg [Fri, 2 Sep 2022 17:32:11 +0000 (19:32 +0200)]
tests: Change test VUIDs
Change 01584 to 07072
Remove 04739
paul-lunarg [Fri, 2 Sep 2022 17:30:08 +0000 (19:30 +0200)]
layers: Change VUIDs for VkImageViewCreateInfo
Change 01584 to 07072 and check for uncompressed format
Remove 04739
Brad Smith [Tue, 30 Aug 2022 22:48:43 +0000 (18:48 -0400)]
layers: Add support for OpenBSD
paul-lunarg [Fri, 2 Sep 2022 14:36:49 +0000 (16:36 +0200)]
tests: Add CopyImageRemainingLayers
This tests calls vkCmdCopyImage and vkCmdCopyBufferToImage
with region.subresource.layerCount = VK_REMAINING_ARRAY_LAYERS
which does not work as expected and results in a very large copy.
paul-lunarg [Fri, 2 Sep 2022 14:35:31 +0000 (16:35 +0200)]
layers: Add check for VK_REMAINING_ARRAY_LAYERS
VK_REMAINING_ARRAY_LAYERS is unsupported in VkImageSubresourceLayers
so I added an extra message that states this.
Mike Schuchardt [Thu, 1 Sep 2022 22:55:42 +0000 (15:55 -0700)]
tests: Fix layer/extension enumeration
adf933c0d3f1ff2cffaefb21093176c0bd0af40a broke extension enumeration by
returning {} for VK_INCOMPLETE. Found because header 1.3.226 pushed the
device extension count > 256.
sjfricke [Wed, 31 Aug 2022 05:45:42 +0000 (14:45 +0900)]
layers: Fix error message for kQueueErrorSummary
sjfricke [Mon, 29 Aug 2022 07:12:13 +0000 (16:12 +0900)]
layers: Improve objects reported in shader val messages
arno-lunarg [Thu, 1 Sep 2022 11:10:58 +0000 (13:10 +0200)]
scripts: Fix copy elision prevention
arno-lunarg [Thu, 1 Sep 2022 10:33:34 +0000 (12:33 +0200)]
layers: Fix copy elision prevention
Karl Schultz [Tue, 23 Aug 2022 20:25:30 +0000 (14:25 -0600)]
build: Improve GitHub Actions caching
- Extend update_deps.py to skip repos if install dir is present
- Cache only build/install directories from dependent repos in the
external directory
This change keeps update_deps from fetching a repo on top of a cached
repo and building an already built repo. (Previously, the entire
external directory was cached.)
It also significantly lowers the amount of data cached, allowing more
caches (related to versions of known_good.json) to be saved.
sjfricke [Thu, 1 Sep 2022 06:11:09 +0000 (15:11 +0900)]
tests: Fix tests failing on pixel 6
arno-lunarg [Mon, 29 Aug 2022 14:33:37 +0000 (16:33 +0200)]
build: Fix deprecated CMAKE_COMPILER_IS_GNUCC
CMAKE_COMPILER_IS_GNUCC usage is not recommended by official doc.
Besides, it may be true for clang, potentially leading to errors.
So use CMAKE_GNU_COMPILER_ID instead.
paul-lunarg [Wed, 31 Aug 2022 18:00:02 +0000 (20:00 +0200)]
layers: Compare with min instance/device api version
paul-lunarg [Wed, 31 Aug 2022 16:46:21 +0000 (18:46 +0200)]
layers: Fix ValidateDeprecatedExtensions
paul-lunarg [Tue, 30 Aug 2022 19:42:53 +0000 (21:42 +0200)]
layers: Fix deprecated device extension warning
Compare deprecated device extension target to device version instead
of api version, as device version <= api version and the extension
is necessary if the device doesn't support the version that the
extension was promoted to.
paul-lunarg [Tue, 30 Aug 2022 19:17:45 +0000 (21:17 +0200)]
tests: Fix LoadDeprecatedExtension
Allow for API-version-mismatch
paul-lunarg [Mon, 29 Aug 2022 19:30:11 +0000 (21:30 +0200)]
tests: Add test LoadDeprecatedExtension
Test should fail on CI with less than 1.3 devices
Tony-LunarG [Tue, 30 Aug 2022 20:58:40 +0000 (14:58 -0600)]
layers: Cache results from GetPhysicalDeviceImageFormatProps
Tony-LunarG [Wed, 24 Aug 2022 21:16:14 +0000 (15:16 -0600)]
tests: Add tests for 07009 and 07010
Tony-LunarG [Tue, 23 Aug 2022 16:32:16 +0000 (10:32 -0600)]
layers: Add validation for vuids 07009 and 07010
Tony-LunarG [Wed, 24 Aug 2022 20:55:28 +0000 (14:55 -0600)]
layers: Use results from RPLayoutAgainstFramebufferImageUsage
Tony-LunarG [Wed, 24 Aug 2022 18:23:01 +0000 (12:23 -0600)]
layers: Remove bad msrtss validation with imageless framebuffers
paul-lunarg [Wed, 31 Aug 2022 16:57:40 +0000 (18:57 +0200)]
tests: Fix unexpected errors not failing tests
John Zulauf [Mon, 29 Aug 2022 20:37:20 +0000 (14:37 -0600)]
syncval: Fix ILT hazard rules across queues
Add logic to correctly apply cross queue synchronization.
paul-lunarg [Tue, 30 Aug 2022 18:50:40 +0000 (20:50 +0200)]
tests: Fix SetupValidationSettings
paul-lunarg [Tue, 30 Aug 2022 17:34:56 +0000 (19:34 +0200)]
tests: Fix SetupValidationSettings
paul-lunarg [Mon, 29 Aug 2022 18:30:06 +0000 (20:30 +0200)]
tests: Add comments
paul-lunarg [Mon, 29 Aug 2022 17:04:12 +0000 (19:04 +0200)]
tests: Fix more leaks!
paul-lunarg [Mon, 29 Aug 2022 14:20:36 +0000 (16:20 +0200)]
tests: Fix SyncVal tests
Fixed:
SyncCmdDispatchDrawHazards
CheckSynchronization2SupportAndInitState
TestInvalidExternalSubpassDependency
SyncQSSubmit2
paul-lunarg [Mon, 29 Aug 2022 14:02:03 +0000 (16:02 +0200)]
tests: Fix RenderPassAsyncHazard
Removed VUID-vkCmdDraw-subpass-02685
paul-lunarg [Mon, 29 Aug 2022 13:24:21 +0000 (15:24 +0200)]
tests: Apply ncesario's fix
paul-lunarg [Mon, 29 Aug 2022 13:16:20 +0000 (15:16 +0200)]
tests: Fix SetupValidationSettings
paul-lunarg [Mon, 29 Aug 2022 12:44:21 +0000 (14:44 +0200)]
tests: Fixes
paul-lunarg [Fri, 26 Aug 2022 17:18:37 +0000 (19:18 +0200)]
tests: Fix SyncCmdDrawDepthStencil
Removed UnexpectedError but changed the formats to be the same.
paul-lunarg [Fri, 26 Aug 2022 16:59:48 +0000 (18:59 +0200)]
tests: Remove comment
paul-lunarg [Fri, 26 Aug 2022 16:56:18 +0000 (18:56 +0200)]
tests: Remove AllowedFailureMsg
UsageConcurentRT will not be run on single queue family devices
paul-lunarg [Wed, 24 Aug 2022 14:59:08 +0000 (16:59 +0200)]
tests: Fix SyncVal tests
Fixed:
SyncCopyOptimalImageHazards
SyncCopyBufferImageHazards
SyncCmdDrawDepthStencil
SyncLayoutTransition
SyncSubpassMultiDep
RenderPassAsyncHazard
TestInvalidExternalSubpassDependency
TestCopyingToCompressedImage
SyncQSSubmit2
paul-lunarg [Tue, 23 Aug 2022 20:28:23 +0000 (22:28 +0200)]
tests: Fix MeshTaskShadersPrintf
paul-lunarg [Tue, 23 Aug 2022 18:47:41 +0000 (20:47 +0200)]
tests: Fix GpuValidationArrayOOBRayTracingShaders
paul-lunarg [Mon, 22 Aug 2022 15:57:57 +0000 (17:57 +0200)]
tests: Fix AMD BP tests
Fixed:
NumberOfSubmissions
NumSyncPrimitives
SecondaryCmdBuffer
paul-lunarg [Mon, 22 Aug 2022 15:54:41 +0000 (17:54 +0200)]
tests: Fix double error messages
paul-lunarg [Mon, 22 Aug 2022 14:47:35 +0000 (16:47 +0200)]
tests: Fix SetupValidationSettings
paul-lunarg [Mon, 22 Aug 2022 11:21:21 +0000 (13:21 +0200)]
tests: Fix Amd BP tests
Fixed:
ClearImage
ImageToImageCopy
paul-lunarg [Mon, 22 Aug 2022 11:00:48 +0000 (13:00 +0200)]
tests: Fix CheckDisableCoreValidation
paul-lunarg [Wed, 10 Aug 2022 13:22:56 +0000 (15:22 +0200)]
tests: Fix vuid check crash
paul-lunarg [Wed, 10 Aug 2022 01:22:23 +0000 (03:22 +0200)]
tests: VK_LAYER_TESTS_VALIDATION_FEATURES env var
VK_LAYER_TESTS_VALIDATION_FEATURES=all
VK_LAYER_TESTS_VALIDATION_FEATURES=core
VK_LAYER_TESTS_VALIDATION_FEATURES=none
paul-lunarg [Tue, 9 Aug 2022 12:13:47 +0000 (14:13 +0200)]
tests: Fix CI
paul-lunarg [Tue, 9 Aug 2022 00:22:41 +0000 (02:22 +0200)]
tests: Fix compilation warnings
paul-lunarg [Sun, 7 Aug 2022 19:39:14 +0000 (21:39 +0200)]
tests: Fix Amd BP tests
Fixed:
UseMutableRT
UsageConcurentRT
KeepLayoutSmall
CopyingDescriptors
Barriers
paul-lunarg [Tue, 2 Aug 2022 20:07:52 +0000 (22:07 +0200)]
tests: Fix Arm BP tests
Fixed:
SamplerCreation
MultisampledBlending
ManySmallIndexedDrawcalls
SparseIndexBufferTest
SuboptimalDescriptorReuseTest
RobustBufferAccessTest
DepthPrePassUsage
RedundantRenderPassStore
RedundantRenderPassClear
InefficientRenderPassClear
DescriptorTracking
BlitImageLoadOpLoad
RedundantAttachment
paul-lunarg [Tue, 2 Aug 2022 19:20:29 +0000 (21:20 +0200)]
tests: Fix tests
Fixed:
TransitionFromUndefinedToReadOnly
SemaphoreSetWhenCountIsZero
OverAllocateFromDescriptorPool
paul-lunarg [Tue, 2 Aug 2022 16:04:24 +0000 (18:04 +0200)]
tests: Fix tests
Fixed:
ExpectedQueryDetails
MissingQueryDetails
DepthBiasNoAttachment
CreatePipelineWithoutRenderPass
paul-lunarg [Tue, 2 Aug 2022 15:55:24 +0000 (17:55 +0200)]
tests: Fix SwapchainCreationTest
paul-lunarg [Mon, 18 Jul 2022 21:57:57 +0000 (15:57 -0600)]
tests: Fix core errors in best practices
Fixed:
VkBestPracticesLayerTest.AttachmentShouldNotBeTransient
VkBestPracticesLayerTest.TooManyInstancedVertexBuffers
paul-lunarg [Mon, 1 Aug 2022 20:39:52 +0000 (22:39 +0200)]
tests: Fix IndirectDrawTests
paul-lunarg [Tue, 19 Jul 2022 22:53:08 +0000 (16:53 -0600)]
tests: Remove double unexpected messages
Rework expect success to take only one pathway for unexpected errors
As well as stop a double call to ExpectSuccess from filling
desired_message_strings_ with empty strings.
sjfricke [Thu, 14 Jul 2022 05:44:37 +0000 (14:44 +0900)]
layers: Fix VUID 01586 format check
sjfricke [Thu, 14 Jul 2022 05:44:05 +0000 (14:44 +0900)]
layers: Collapse redundant if statment
Tony-LunarG [Wed, 24 Aug 2022 22:20:40 +0000 (16:20 -0600)]
layers: Fix ms render to single sampled "enabled"
Previous interpretation of "If multisampled-render-to-single-sampled
is enabled" was that the extension was enabled. This changes the
interpretation to mean that it is enabled for the subpass.
sjfricke [Wed, 24 Aug 2022 05:26:33 +0000 (14:26 +0900)]
layers: Refactor StorageImageFormat tests
sjfricke [Thu, 25 Aug 2022 05:54:02 +0000 (14:54 +0900)]
tests: Add single entry for VkGpuAssistedLayerTest
sjfricke [Fri, 26 Aug 2022 08:32:46 +0000 (17:32 +0900)]
layers: Add format_feature_2 wrapper around buffer views
arno-lunarg [Fri, 26 Aug 2022 15:46:09 +0000 (17:46 +0200)]
tests: Fix VkRenderFramework::IsPlatform()
The return value of find can be invalid, thus must be checked before use.
arno-lunarg [Fri, 26 Aug 2022 15:09:02 +0000 (17:09 +0200)]
tests: Switch to GTEST_SKIP()
Switch to GTEST_SKIP() from printf in tests modified by prev commit
arno [Thu, 25 Aug 2022 17:34:15 +0000 (19:34 +0200)]
tests: Fix API version validation
Using DeviceValidationVersion() is the correct way
to get the supported API version.
SetTargetApiVersion() now returns void to prevent
further harm.
Bob Ellison [Thu, 25 Aug 2022 23:06:00 +0000 (17:06 -0600)]
docs: fix default value of report_flags
layers/vk_layer_config.cpp defaults "report_flags" to just "error":
value_map_["khronos_validation.report_flags"] = "error";
while "error,warn,perf" is listed as the default in both vk_layer_settings.txt:
khronos_validation.report_flags = error,warn,perf
and layers/json/VkLayer_khronos_validation.json.in:
"default": [
"error",
"warn",
"perf"
]
This change makes the latter two files match the current code by changing the
default to be just "error".
This affects shipped SDK files as well as vkconfig behavior and SDK documentation.
sjfricke [Thu, 25 Aug 2022 06:18:38 +0000 (15:18 +0900)]
layers: Rebuild static data with group decoration
arno-lunarg [Fri, 26 Aug 2022 08:31:40 +0000 (10:31 +0200)]
tests: Change physDevProps return type
Given how it is used, VkRenderFramework::physDevProps() should
return a const reference to avoid unnecessary copy.
sjfricke [Thu, 25 Aug 2022 07:38:15 +0000 (16:38 +0900)]
layers: Handle PhysicalStorageBuffer to itself
sjfricke [Thu, 25 Aug 2022 14:40:32 +0000 (23:40 +0900)]
layers: Generate SPIR-V storage class strings
Shahbaz Youssefi [Thu, 25 Aug 2022 04:05:37 +0000 (00:05 -0400)]
layers: Fix for VK_EXT_rasterization_order_attachment_access
VUs that enforced render pass being valid where not actually checking
that, incorrectly triggering when render pass was indeed valid.
Rodrigo Locatti [Wed, 24 Aug 2022 21:35:24 +0000 (18:35 -0300)]
tests: Add tests for VK_REMAINING_*
Add tests for using VK_REMAINING_ARRAY_LAYERS and
VK_REMAINING_MIP_LEVELS on vkCmdClearDepthStencilImage.
Rodrigo Locatti [Wed, 24 Aug 2022 21:33:07 +0000 (18:33 -0300)]
layers: Fix VK_REMAINING_* on Z-Cull tracking
Fix the usage of VK_REMAINING_ARRAY_LAYERS and VK_REMAINING_MIP_LEVELS
on NVIDIA Best Practices when tracking Z-Cull state.
This adds a generic function for iterating over all subresources while
having VK_REMAINING_* in mind.
ziga-lunarg [Sun, 21 Aug 2022 01:01:45 +0000 (03:01 +0200)]
tests: Test queries in a render pass with multiview
ziga-lunarg [Sun, 21 Aug 2022 01:01:29 +0000 (03:01 +0200)]
layers: Fix queries with multiview render pass
Mark Young [Tue, 23 Aug 2022 15:02:14 +0000 (09:02 -0600)]
tests: Update tests for renderpass VUIDs
Update the tests to expect the new VUIDs for renderpass/descriptor
layout validation.
Mark Young [Tue, 23 Aug 2022 15:00:54 +0000 (09:00 -0600)]
layers: Update renderpass layout VUIDs
Issue #4312 points out that several VUIDs changed based on spec
updates. This commit remedies the inconsistencies with the latest
spec and the validation layer.
paul-lunarg [Tue, 23 Aug 2022 16:52:51 +0000 (18:52 +0200)]
tests: Add test in OneTimeSubmit
Adding a positive test with OneTimeSubmit set
paul-lunarg [Tue, 23 Aug 2022 16:52:10 +0000 (18:52 +0200)]
layers: Fix one-time-submit
John Zulauf [Fri, 19 Aug 2022 20:18:00 +0000 (14:18 -0600)]
tests: Add Submit2 SyncVal ULT
Make sure the first synch scope affect is included.
John Zulauf [Thu, 18 Aug 2022 22:58:56 +0000 (16:58 -0600)]
tests: Refactor SyncQSBufferCopyHazards
Use the QSTestContext helper before adding additional tests
John Zulauf [Thu, 18 Aug 2022 22:22:08 +0000 (16:22 -0600)]
syncval: Add QueueSubmit2 support
Refactor the QueueSubmit support to cover all QueueSubmit variations by
conversion to the QueueSubmit2 style parameterization.
sjfricke [Sat, 20 Aug 2022 04:45:34 +0000 (13:45 +0900)]
layers: Refactor PreCallValidateCreateDescriptorSetLayout
Tony-LunarG [Mon, 22 Aug 2022 19:50:40 +0000 (13:50 -0600)]
tests: Fix ShaderModuleIdentifier
Finding that some drivers wont create a pipeline from a smid without
creating one with the shader module
sjfricke [Mon, 22 Aug 2022 23:31:29 +0000 (08:31 +0900)]
docs: Add new gpu_shader instructions
Tony-LunarG [Fri, 12 Aug 2022 17:46:35 +0000 (11:46 -0600)]
tests: Add tests for VK_EXT_attachment_feedback_loop_layout
Tony-LunarG [Fri, 12 Aug 2022 17:43:40 +0000 (11:43 -0600)]
layers: Add checks for VK_EXT_attachment_feedback_loop_layout
Tony-LunarG [Fri, 19 Aug 2022 19:44:36 +0000 (13:44 -0600)]
layers: Add compatibility for attachment_feedback_loop_layout
Yuly Novikov [Mon, 22 Aug 2022 16:22:27 +0000 (16:22 +0000)]
build: Fix BUILD.gn
Add missing include "layers/generated/gpu_pre_dispatch_comp.h"
Fixes #4398
Mark Young [Fri, 19 Aug 2022 20:13:50 +0000 (14:13 -0600)]
revert "tests: Fix ValidateImportMemoryHandleType test..."
This reverts commit
e79cd33a4b10e6f37468d142a3a17171a4e566cc.
This is because internal testing failed on both AMD and Nvidia even though
it works on Github and my machine. Will investigate more later.
Mark Young [Fri, 19 Aug 2022 17:35:53 +0000 (11:35 -0600)]
tests: Fix ValidateImportMemoryHandleType test on Nvidia laptop
Nvidia exposes multiple memory types that have 0 properties. This
causes a problem if one of those memory types is first for the
ValidateImportMemoryHandleType test because the test will still
select it and then the allocation for the buffer and image
memory import memory will fail with VK_OUT_OF_DEVICE_MEMORY.
Fix this by forcing device local memory flag to be used when querying
a proper memory allocation for this test.
Verified this still works for integrated Intel as well.
sjfricke [Thu, 18 Aug 2022 09:12:56 +0000 (18:12 +0900)]
layers: Handle OpTypeBool in structs
sjfricke [Thu, 18 Aug 2022 04:23:11 +0000 (13:23 +0900)]
tests: Better use of GetPhysicalDeviceFeatures2
Nathaniel Cesario [Wed, 17 Aug 2022 23:27:53 +0000 (17:27 -0600)]
tests: Fix AHB tests
Fix AHardwareBuffer tests related to import/export memory allocation
issues.
Nathaniel Cesario [Wed, 17 Aug 2022 23:26:18 +0000 (17:26 -0600)]
layers: Add zero-size alloc case
Adds an allowed zero-sized allocation case based on VUID 01874.