Christopher Michael [Mon, 29 Jun 2020 13:01:54 +0000 (09:01 -0400)]
ecore-evas-wayland: Fix minor typo in error message
Hosang Kim [Mon, 29 Jun 2020 06:01:15 +0000 (15:01 +0900)]
ecore_wl2_input: initializes code variable.
Change-Id: I99440ba38835c42829e8d50b736d0904c7d30adb
Carsten Haitzler (Rasterman) [Sun, 28 Jun 2020 21:52:17 +0000 (22:52 +0100)]
ecore evas wl - cnp - dont segv is data is null
this is probably wrong but crashing is not nice... bettr to NOP than
crash right now.
Lucas Cavalcante de Sousa [Fri, 26 Jun 2020 12:51:01 +0000 (12:51 +0000)]
Native Windows: Eina: Resolve bad comparison while using windows strerror_s
`strerror_s` is the windows alternative of `strerror_r` used by EFL.
`strerror_s` never return the error code with the message as
`strerror_r` does, because of that, while comparing the first 14
characters of `Unknown error ` to the message from unknown code 4096
(`Unknown error`) they were accusing being different - in UNIX this
works because the message returned is `Unknown error 4096`.
This error was noticeable at `eina_error_test_failures` test case.
This Diff adds the error code to the message in case of an `Unknown
error`, making the windows implementation compliant with UNIX.
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Reviewed-by: Wander Lairson Costa <wander.lairson@gmail.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12033
Vincent Torri [Thu, 25 Jun 2020 14:44:15 +0000 (14:44 +0000)]
Windows: fix eina_file_map_new()
the offset passed to MapViewOfFile() must be a multiple of the granularity.
https://docs.microsoft.com/en-us/windows/win32/memory/creating-a-view-within-a-file is taken as basis for this patch
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Wander Lairson Costa <wander.lairson@gmail.com>
Differential Revision: https://phab.enlightenment.org/D12031
Wander Lairson Costa [Wed, 24 Jun 2020 13:32:12 +0000 (13:32 +0000)]
Fix eina file thread test on Windows
On windows, we try to open the "cmd.exe" file, but without the full path
the test fails unless it runs from the system directory.
We now use the full path to test the eina_file_open function.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Vincent Torri <vincent.torri@gmail.com>
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D12021
Marcel Hollerbach [Wed, 10 Jun 2020 18:48:37 +0000 (20:48 +0200)]
eina_array: micro optimize eina_array_push
This commit does two things:
- Tell the compiler that it is unlikely that we need to grow, and that
it is unlikely that data is NULL. Sometimes the if check for data
would get dropped out by the compiler when it can be ensured that it is
!= NULL. However, if we for example efl_add something and eina_push
the result, the condition would not be removed, as there is no assertion
efl_add would be != NULL.
- Do not hide the array assignment in a branch, but make it the default
branch, this way instruction cache caches the correct instruction, as
branch prediction will now hopefully, due to the hinting, take the
correct branch.
While benchmarking this here (simply in elementary_perf), this reduced
pipeline faults in eina_array_push quite a bit. (Btw. it is hard to track
*which* exact calls to eina_array_push do cause that, as mostly this API
gets inlined, so it was easier optimizing that, instead of the method
arround)
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11997
Elyes HAOUAS [Sat, 20 Jun 2020 13:00:10 +0000 (13:00 +0000)]
Fix typos - (Part #5)
Fix some typos
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12019
Elyes HAOUAS [Mon, 22 Jun 2020 18:24:38 +0000 (18:24 +0000)]
Fix typos
Fix some typos
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12015
Myoungwoon Roy, Kim [Wed, 24 Jun 2020 05:40:20 +0000 (14:40 +0900)]
docs: Changes non public Tizen elementary APIs in API reference to internal
Change-Id: Ie6134546631a49acda3e52ee6ca7e2ceafaba17f
JunsuChoi [Thu, 25 Jun 2020 04:13:31 +0000 (13:13 +0900)]
Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic"
Summary:
This reverts commit
4f15bde706ec8cd78fa57845c8eee7bdb5515282.
It is the correct way to draw with arc_to.
And breaking compatibility for current_get.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D12030
Change-Id: Ia0f38eedeba95646e52d360eadc690997fe33e7d
Hosang Kim [Tue, 23 Jun 2020 06:26:15 +0000 (15:26 +0900)]
doxygen: remove broken example images
Change-Id: I8d9c2ecf11c2e46c3cc21259164fddacc52e6610
(cherry picked from commit
8ca44052f8c2957a1a1ffef7c933972df33f82f7)
Joao Antonio Cardoso [Mon, 15 Jun 2020 12:27:46 +0000 (12:27 +0000)]
efl_check.h: Replace stack allocated array by heap allocated
clang-cl doesn't support the syntax of dynamic stack allocated arrays.
ref: windows-native-port
Co-authored-by: Lucas <Coquinho@users.noreply.github.com>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11970
Carsten Haitzler (Rasterman) [Tue, 23 Jun 2020 13:00:48 +0000 (14:00 +0100)]
ecore-x vysnc - env var - fix typo
Carsten Haitzler (Rasterman) [Mon, 22 Jun 2020 12:12:23 +0000 (13:12 +0100)]
ecore wl - make comment note about allocating buffers
Wander Lairson Costa [Fri, 12 Jun 2020 20:27:51 +0000 (20:27 +0000)]
eina_test_file.c: Do not test errno if the function doesn't fail
errno only holds a valid value if the function returns an error.
ref: windows-native-port
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11971
Elyes HAOUAS [Sat, 20 Jun 2020 09:47:56 +0000 (09:47 +0000)]
Get rid of trailing whitespaces (14 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12006
Elyes HAOUAS [Sat, 20 Jun 2020 09:54:26 +0000 (09:54 +0000)]
Get rid of trailing whitespaces (13 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12012
Elyes HAOUAS [Sat, 20 Jun 2020 09:52:54 +0000 (09:52 +0000)]
Get rid of trailing whitespaces (12 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12011
Elyes HAOUAS [Sat, 20 Jun 2020 09:51:50 +0000 (09:51 +0000)]
Get rid of trailing whitespaces (11 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12010
Elyes HAOUAS [Sat, 20 Jun 2020 09:50:53 +0000 (09:50 +0000)]
Get rid of trailing whitespaces (10 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12009
Elyes HAOUAS [Sat, 20 Jun 2020 09:50:00 +0000 (09:50 +0000)]
Get rid of trailing whitespaces (9 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12008
Elyes HAOUAS [Sat, 20 Jun 2020 09:48:52 +0000 (09:48 +0000)]
Get rid of trailing whitespaces (8 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12007
Elyes HAOUAS [Sat, 20 Jun 2020 09:47:04 +0000 (09:47 +0000)]
Get rid of trailing whitespaces (7 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12005
Elyes HAOUAS [Sat, 20 Jun 2020 09:45:50 +0000 (09:45 +0000)]
Get rid of trailing whitespaces (6 / 14)
Remove whitespaces
Differential Revision: https://phab.enlightenment.org/D12004
Elyes HAOUAS [Sat, 20 Jun 2020 09:44:55 +0000 (09:44 +0000)]
Get rid of trailing whitespaces (5 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12003
Elyes HAOUAS [Sat, 20 Jun 2020 09:43:56 +0000 (09:43 +0000)]
Get rid of trailing whitespaces (4 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12002
Elyes HAOUAS [Sat, 20 Jun 2020 09:42:50 +0000 (09:42 +0000)]
Get rid of trailing whitespaces (3 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12001
Elyes HAOUAS [Sat, 20 Jun 2020 09:41:45 +0000 (09:41 +0000)]
Get rid of trailing whitespaces (2 / 14)
Remove trailing whitespaces
Differential Revision: https://phab.enlightenment.org/D12000
Elyes HAOUAS [Sat, 20 Jun 2020 09:40:20 +0000 (09:40 +0000)]
Get rid of trailing whitespace (1 / 14)
Remove trailing whitespace
Differential Revision: https://phab.enlightenment.org/D11999
JunsuChoi [Tue, 23 Jun 2020 04:46:43 +0000 (13:46 +0900)]
Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic
Summary:
The rounded rect is a very slightly different shape compared
to chrome's svg output. To solve this, modify to use a quadratic bezier
instead of arc when drawing a round.
Test Plan:
{
F3904500}
(Drawing rect with arc or quadratic)
Compare Image
{
F3904501}
{
F3904502}
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D12020
Ali Alzyod [Mon, 22 Jun 2020 08:31:54 +0000 (17:31 +0900)]
eina_strbuf: introduce change last occurrence function
Reviewers: cedric, woohyun, bowonryu
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8757
Differential Revision: https://phab.enlightenment.org/D11990
Ali Alzyod [Mon, 22 Jun 2020 08:27:42 +0000 (17:27 +0900)]
elementary_test: remove leaked style
Summary: remove created style after being set in textblock
Reviewers: woohyun, smohanty
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8742
Differential Revision: https://phab.enlightenment.org/D11944
Ali Alzyod [Mon, 22 Jun 2020 08:16:34 +0000 (17:16 +0900)]
eina_strbuf: if readonly strbuf is malloc, then it will stop being readonly
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8757
Differential Revision: https://phab.enlightenment.org/D11992
Ali Alzyod [Mon, 22 Jun 2020 08:16:02 +0000 (17:16 +0900)]
eina_strbuf_manage_new: update documentation
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8757
Differential Revision: https://phab.enlightenment.org/D11991
AbdullehGhujeh [Mon, 22 Jun 2020 08:02:05 +0000 (17:02 +0900)]
evas textblock : update font source when it set using font_source_set
Summary:
when we set font source, for example with efl_text_font_source_set, the font source will not be updated in the textblock.
this is have same results that has been done in D9548
Test Plan:
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include <Efl_Ui.h>
static void
_gui_quit_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)
{
efl_exit(0);
}
static Eo *
_create_label(Eo *win, Eo *bx)
{
Eo *en;
en = efl_add(EFL_UI_TEXTBOX_CLASS, win);
printf("Added Efl.Ui.Text object\n");
efl_text_interactive_editable_set(en, EINA_FALSE);
efl_pack(bx, en);
return en;
}
static void
_gui_setup()
{
char buf[512], f_buf[512];
Eo *win, *bx;
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get(),
efl_ui_win_type_set(efl_added, EFL_UI_WIN_TYPE_BASIC),
efl_text_set(efl_added, "Hello World"),
efl_ui_win_autodel_set(efl_added, EINA_TRUE));
// when the user clicks "close" on a window there is a request to delete
efl_event_callback_add(win, EFL_UI_WIN_EVENT_DELETE_REQUEST, _gui_quit_cb, NULL);
bx = efl_add(EFL_UI_BOX_CLASS, win,
efl_content_set(win, efl_added),
efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(360, 240)));
snprintf(buf, sizeof(buf), "./TestFontSource.eet");
Eo *en = _create_label(win, bx);
efl_text_set(en, "Hello, This Text Use The Font : Does_Not_Exists_Font_1 : Source + Font Name");
efl_text_font_source_set(en, buf);
efl_text_font_family_set(en, "Does_Not_Exists_Font_1");
efl_text_font_size_set(en, 35);
en = _create_label(win, bx);
efl_text_set(en, "Hello, This Text Use The Font : Does_Not_Exists_Font_1 : Font Name");
efl_text_font_family_set(en, "Does_Not_Exists_Font_1");
efl_text_font_size_set(en, 35);
en = _create_label(win, bx);
efl_text_set(en, "Hello, This Text Use The Font : Does_Not_Exists_Font_2 : Source + Font Name");
efl_text_font_source_set(en, buf);
efl_text_font_family_set(en, "Does_Not_Exists_Font_2");
efl_text_font_size_set(en, 35);
en = _create_label(win, bx);
efl_text_set(en, "Hello, This Text Use The Font : Does_Not_Exists_Font_2 : Font Name");
efl_text_font_family_set(en, "Does_Not_Exists_Font_2");
efl_text_font_size_set(en, 35);
}
EAPI_MAIN void
efl_main(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
{
_gui_setup();
}
EFL_MAIN()
Reviewers: ali.alzyod, woohyun, bowonryu, cedric
Reviewed By: ali.alzyod
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11757
Ali Alzyod [Mon, 22 Jun 2020 07:54:51 +0000 (16:54 +0900)]
eina_strbuf: resolve segfault when replace used with read_only buffer
Summary: when eina_strbuf_replace is used by read_only buffer, this will cause segfault (access invalid memory)
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8757
Differential Revision: https://phab.enlightenment.org/D11989
AbdullehGhujeh [Mon, 22 Jun 2020 07:31:53 +0000 (16:31 +0900)]
Textblock : Fix cursor cluster movement when emoji at the line start
Summary:
if we have emoji only or emoji at line start we can move cursor using mouse click to be inside the emoji.
{
F3868502}
this should fix T8664
Test Plan:
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("emoji-test", "emoji-test");
elm_win_autodel_set(win, EINA_TRUE);
/* and now just resize the window to a size you want. normally widgets
* will determine the initial size though */
evas_object_resize(win, 320, 320);
Evas_Object *box;
box = elm_box_add(win);
evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(box, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_win_resize_object_add(win, box);
Evas_Object *entry;
entry = elm_entry_add(box);
elm_entry_entry_set(entry, "☪️");
evas_object_size_hint_weight_set(entry, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(entry, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_box_pack_end(box, entry);
evas_object_show(entry);
evas_object_show(box);
/* and show the window */
evas_object_show(win);
elm_run(); /* and run the program now, starting to handle all
* events, etc. */
/* exit code */
return 0;
}
ELM_MAIN()
Reviewers: ali.alzyod, woohyun, bowonryu, zmike, bu5hm4n
Reviewed By: ali.alzyod
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8664
Differential Revision: https://phab.enlightenment.org/D11732
Myoungwoon Roy, Kim [Tue, 23 Jun 2020 08:29:35 +0000 (17:29 +0900)]
docs: Changes non public Tizen APIs in API reference to internal
Change-Id: I579e1af8a8006391bdb51fc63873ddb794cd7792
Shinwoo Kim [Tue, 23 Jun 2020 07:31:09 +0000 (16:31 +0900)]
ecore_wl2: update documentation
This patch is following doxygen rule.
*tizen_fix
Change-Id: I4d638465af923cad13de4d8110f286380c0efc51
Shinwoo Kim [Fri, 5 Jun 2020 02:48:59 +0000 (11:48 +0900)]
ecore_wl2: sync between UI and video
There is a requirement to sync of geometry changes such as move
and resize between UI and video. EFL could not take care of the
video geometry becasue it is handled by separated process.
This patch makes it possible by using a subsurface.
The video process will use the subsurface and surface commits
on this subsurface will be cached and only applied when the
parent surface's state is applied. In this case the parent
surface is working for UI.
*tizen_only
Change-Id: I287cb7bf7858ea5e3efc7f2bd32ce6279896586f
Shinwoo Kim [Fri, 19 Jun 2020 07:07:06 +0000 (16:07 +0900)]
elm_scroller: use region of proxy soruce for loop
Summary:
If size of elm_sclloer content is too big, then the proxy of
elm_scroller to show loop effect does not work. Because
evas_gl_common_image_surface_new does not allow
bigger size surface than max_texture_size.
Reviewers: Hermet, jsuya, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11996
Change-Id: I7c0e83e70f0ac11a413cc4ae0dd05fc35678ef80
Shinwoo Kim [Fri, 19 Jun 2020 05:08:23 +0000 (14:08 +0900)]
Revert "ui scroller: fix broken scroller loop"
This reverts commit
036423307c7eafec904d650a71ef64dac646151a.
The commit 76b89b8 "evas proxy: use part of source" was reverted.
So we need to revert "ui scroller: fix broken scroller loop" to
avoid build break.
New commit using evas_object_image_load_region_set will handle.
Change-Id: Ibed05025c028555dc490f7b0bdd707c104b17943
Shinwoo Kim [Fri, 19 Jun 2020 03:14:16 +0000 (12:14 +0900)]
Revert "evas proxy: use part of source"
This reverts commit
76b89b8e49f4b16ad490c04134a9bdddea27950f.
The commit was for fix an issue quickly.
Now we are able to rever the commit because
evas_object_image_load_region_set is available.
New commit using evas_object_image_load_region_set is comming.
Change-Id: I5f8cf04f92065db22342521b9102e6d26d5121d6
Boris Faure [Sat, 20 Jun 2020 10:37:56 +0000 (11:37 +0100)]
eina_unicode: have explicit type conversions
Summary:
Found by running terminology's tests with UBSAN:
include/eina-1/eina/eina_inline_unicode.x:
runtime error: implicit conversion from type 'char' of value
-62 (8-bit, signed) to type 'unsigned char' changed the value to 194
(8-bit, unsigned)
Reviewers: #reviewers, vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11972
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2020 23:56:08 +0000 (00:56 +0100)]
efreet caceh - fix coverity report
fix CID 1429935
Vincent Torri [Thu, 18 Jun 2020 13:35:46 +0000 (14:35 +0100)]
meson: add Solaris support
Summary: Add Solaris support for meson
Test Plan: test on OpenIndiana
Reviewers: raster, bu5hm4n, stefan_schmidt
Reviewed By: raster, stefan_schmidt
Subscribers: alarcher, stefan_schmidt, bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11973
Vincent Torri [Tue, 16 Jun 2020 21:47:43 +0000 (21:47 +0000)]
tests: eina: fix ENOMEM message on Windows and solaris
On Windows and solaris the string associated to ENOMEM is "Not enough space"
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11983
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2020 10:35:44 +0000 (11:35 +0100)]
efreet - mtime 0 fix build on windows
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2020 10:03:02 +0000 (11:03 +0100)]
efreetd - cache - add more statinfo work around 0 mtime distros
some distros 9notably in this case nixos) want to do reproducible
builds. to them this means going around setting mtime for all files to
0. this means efreetd not only thinks mtime is invalid/stupid (0 is
generally just that as midnight on jan 1 1970 is not exactly a
sensible dare for a modified timestamp of a file as no filesystem with
any sanity will have not been modified since that time), but it keeps
mtime at 0 even when things update. this totally breaks efreetd that
expects to find mtime increases over time as things change. it's
necessary because it has to perform a "are mu caches up to date" scan
of all file data it caches and it needs to know if it should rebuild
something based on this.
so this does a few things:
1. it makes mtime have to be an exact match to the cache, not cache
mtime >= file mtime. so any change forward or back is an inavlidation.
2. it now also uses ctime, mode, size, uid, gid, block count and if a
symlink, the sha1 of the symlink path in addition and any change to
these == invalid.
this adds a lot of code and changes how dirs get scanned a bit but it
means it can pick up changes on these 0 mtime distros.
interestingly the policy of mtime being 0 is to have a reprodcible fs
... but ctime still changes and is > 0, as does inode info, so it's
not actually possible to have it totally work... but they try still,
so this is a fix for that problem.
whilst i was doing thisi also noticed efreetd re-red dirs many times
due to icon theme inhritance. i also fixed that to do a LOT less
syscalls by only scanning a dir once as i was rejigging the scanning
code at the time anyway. this should optimize thr scan costs at
efreetd startup too.
@fix
@opt
Artur Świgoń [Mon, 23 Mar 2020 11:33:52 +0000 (12:33 +0100)]
Revert "Revert "eldbus: change to idle_enterer from idler""
This reverts commit
2bcc7b48bf2f34a19b0712b030ab143d09dc30fb.
Handling DBus messages during idle carries the risk of starving the DBus
communication (and making the UI unresponsive if screen reader is used). This
is well-explained in the original (reverted) upstream commit: "If an
application does not give idle time, then the eldbus cannot have chance to
work."
Change-Id: Iffde1be749f5dba1ac1e8642c4ce4e3436770b5a
Stefan Schmidt [Tue, 9 Jun 2020 12:22:19 +0000 (14:22 +0200)]
benchmarks: eina: make sure we do not divide by zero
Make sure we do not divide by i if it is zero here.
CID: 1400768
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11956
Stefan Schmidt [Wed, 10 Jun 2020 10:30:48 +0000 (12:30 +0200)]
tests: eio: make sure we check return value
Make sure we fail the test if the call does not succeed.
CID: 1412364
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11963
Carsten Haitzler (Rasterman) [Wed, 17 Jun 2020 11:30:23 +0000 (12:30 +0100)]
evas gl common - remove comment - not valid anymore
Carsten Haitzler (Rasterman) [Wed, 17 Jun 2020 11:17:13 +0000 (12:17 +0100)]
gl common - actually allow vertex limits
fix non-commented out return that should have been commented out
Marcel Hollerbach [Wed, 17 Jun 2020 07:13:05 +0000 (09:13 +0200)]
efl_ui_widget: addition to the previous commit
in the previous commit we started to only receive the parent_obj from
the evas object when its not a widget. However, we still need to ensure
that the parent is equal to the current one in order to remove it when a
widget.
While this is one more call, the call to get the parent is not as
heavy as the data_get call, as this directly addresses a struct, and
does not read from a hash table.
This also fixes a test case failure.
Subhransu Mohanty [Wed, 17 Jun 2020 06:28:44 +0000 (06:28 +0000)]
elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls.
in genlist testcase the number of calls reduced by 30000.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Hermet Park <<hermetpark@gmail.com>>
Reviewed-by: Youngbok Shin <youngb.shin@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11984
Subhransu Mohanty [Wed, 17 Jun 2020 06:36:02 +0000 (06:36 +0000)]
elementary/perf:remove unnecessary elm_widget_is() check
As we always make sure the parent is a widget class we don't have to check anymore.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Hermet Park <<hermetpark@gmail.com>>
Differential Revision: https://phab.enlightenment.org/D11985
Taehyub Kim [Wed, 17 Jun 2020 12:17:23 +0000 (21:17 +0900)]
elm_image: remove the spaces and keep the indentation for elm_image_file_set()
Summary: there are wrong indentation in the elm_image_file_set, so removed the tabs
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11988
Change-Id: I797d0861fff02a8b49aacc748cec9c7238926441
Taehyub Kim [Wed, 17 Jun 2020 12:04:08 +0000 (21:04 +0900)]
elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice
Summary:
when trying to set file using url path twice, the second api call's return value is EINA_FALSE
since image obj has already has same file path. After applying Efl.File interface, the behavior is changed compared to before.
both of the return values should be EINA_TRUE.
@fix
ex)
Eina_Bool ret1, ret2;
ret1 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret2 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret1 and ret2 should be EINA_TURE
Test Plan:
1. call elm_image_file_set api with same url path
2. see the return value
Reviewers: Hermet, kimcinoo, jsuya
Reviewed By: Hermet
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11979
Change-Id: If64d8d58424b559ea07dba14efb36996484c2fd5
Taehyub Kim [Tue, 16 Jun 2020 12:16:40 +0000 (21:16 +0900)]
efl.spec: enable WebP Animation Feature
libwebp-1.1.0 library is included in the binary after tizen_unified_20200528.2
WebP Animation can be enabeld now.
Change-Id: I20b17049f7caca332a1af7ceb5c4e32e252bdaa5
Stefan Schmidt [Tue, 16 Jun 2020 09:03:26 +0000 (11:03 +0200)]
modules: eina: chained_pool: check for NULL before passing it to deref
Make sure we check if pool->first_fill is NULL before passing it onwards
where it gets dereferenced. In case this happens return NULL instead of
garbage.
CID: 1293520
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11980
Stefan Schmidt [Tue, 16 Jun 2020 14:19:04 +0000 (16:19 +0200)]
Revert "ci: travis: disable the webp loader on CI builds for now"
This reverts commit
29c491b977543e9ef86147604ab3a297ece18327.
We went back to a much older version which should be available on all
our CI test systems. Safe to enable again.
Jaehyun Cho [Tue, 16 Jun 2020 11:40:59 +0000 (20:40 +0900)]
evas_object_table: fix not to use hint_fill on elm_table
Summary:
The hint_fill logic in evas_object_table was designed to be used for
Efl.Ui.Table not for elm_table.
Since Efl.Ui.Table does not use evas_object_table logic, hint_fill logic
in evas_object_table is removed.
Reviewers: YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11982
Change-Id: Ide4fe092d9eeee4120596bae3dc3cb2eab2a1da5
Woochanlee [Mon, 15 Jun 2020 09:55:45 +0000 (18:55 +0900)]
efl : Fix build warnings.
Change-Id: I0777c22ad7784beee94646cf17420e41b0e798e8
JunsuChoi [Tue, 16 Jun 2020 04:10:25 +0000 (13:10 +0900)]
Efl.Canvas.Vg.Object: Fix wrong render area
Summary:
When determining the size of the ector buffer,
it was used the smaller of the object's geometry or path_bounds.
However, because of that, path worked as absolute coordinates.
path_bounds should be relative to geometry of object.
Test Plan:
{
F3900444}
original
{
F3900445}
before
+ evas_object_geometry_set(vg, 100, 100, 200, 200);
{
F3900447}
after
+ evas_object_geometry_set(vg, 100, 100, 200, 200);
{
F3900448}
Reviewers: Hermet, kimcinoo, herb, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11974
Change-Id: Id190aeb88735be0b9cbb5f60879c6a8a63eb33e7
Hosang Kim [Mon, 15 Jun 2020 10:41:03 +0000 (19:41 +0900)]
doxygen: remove unsupported links to preview images
Change-Id: I936462469e6713268fb8a41e0d10f77b4c78a424
Stefan Schmidt [Mon, 15 Jun 2020 11:20:07 +0000 (13:20 +0200)]
tests: edje: check result of evas_engine_info_set()
Make sure we check the result of evas_engine_info_set and only continue
if it succeeds.
CID: 1401077
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11978
Stefan Schmidt [Mon, 15 Jun 2020 10:48:37 +0000 (12:48 +0200)]
modules: gl_x11: ensure we check the result of evas_eglMakeCurrent()
In case we fail make sure we error out to allow better debugging.
Also fix some surrounding indent.
CID: 1402693, 1402670
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11976
Kamil Konieczny [Fri, 12 Jun 2020 13:37:50 +0000 (15:37 +0200)]
elm_atspi_bridge: call _elm_win_atspi only once
Change-Id: I843c37646f60dfad985db66ee49838a68c239c25
Kamil Konieczny [Fri, 12 Jun 2020 13:18:54 +0000 (15:18 +0200)]
efl_ui_win_socket: fix socket_proxy release
socket_proxy was created with efl_add method, so use efl_del
instead of efl_unref for object release.
Change-Id: I81a470f1acc8d803aa1146dd0d6b8a1663c797ec
Kamil Konieczny [Fri, 12 Jun 2020 13:30:16 +0000 (15:30 +0200)]
elm_atspi_bridge: fix memory leak
Fix memory leak on error path.
Change-Id: I314f200ec20f2f0810d15ed1b6ae9fec1597e775
Carsten Haitzler (Rasterman) [Sun, 14 Jun 2020 00:09:04 +0000 (01:09 +0100)]
webp - 0.5.0 is actually new enough
webp anim apis came out in 0.5.0 not 1.1.0 :)
Daniel Kolesa [Fri, 12 Jun 2020 16:46:33 +0000 (18:46 +0200)]
evas/engines/gl_generic: fix byte order after glReadPixels on BE
This fixes the screenshot tool in Enlightenment on big endian
systems besides other things.
Stefan Schmidt [Fri, 12 Jun 2020 14:03:48 +0000 (16:03 +0200)]
meson_options: really fix the typo
Sigh, check your patch, even if it appears to be tiny.
Stefan Schmidt [Fri, 12 Jun 2020 14:02:43 +0000 (16:02 +0200)]
meson_options: fix typo in option description
Stefan Schmidt [Fri, 12 Jun 2020 11:25:01 +0000 (13:25 +0200)]
modules: vnc: allow building for FreeBSD with a different header path
Original patch provided by phyb user CeDeROM.
Fixes T8713
Stefan Schmidt [Fri, 12 Jun 2020 07:32:39 +0000 (09:32 +0200)]
build: decrease the minimal needed meson verion to 0.50
When we jumped from 0.47 to 0.52 to fix problems some users have been
seeing when building we might jumped a bit to far. We want a good
balance between stable and fast building but also mature enough to be in
distro releases and widely available.
We will try to settle for a middle-ground with 0.50 here. If that causes
problems for you building please let us know instantly.
WooHyun Jung [Fri, 12 Jun 2020 07:57:45 +0000 (16:57 +0900)]
efl_ui_win: reuse bg which was created for version check
Summary: This is just for not creating bg object twice.
Reviewers: bu5hm4n, zmike, YOhoho
Reviewed By: YOhoho
Subscribers: YOhoho, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11936
Change-Id: I548a3f12a728d90212d47c110b2d1904b3d472b7
Hermet Park [Fri, 12 Jun 2020 07:33:21 +0000 (16:33 +0900)]
ui image: fix a missing else case.
it sholud be turned on enabled status.
it's side issue by
0826b4916efb0bce20a353cece56e84d05fb406c
Change-Id: I84b06594fda8694f865c74db4bdabfda505665c3
Taehyub Kim [Fri, 12 Jun 2020 07:14:56 +0000 (16:14 +0900)]
efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set
Summary:
when elm_image_preload_disabled_set(img, EINA_TRUE) is called before file set.
The image preload is not canceled, because the function will be returned since the image is not loaded.
so preload disabled api is fixed to work even if it is called before file set.
@fix
Reviewers: Hermet, kimcinoo, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11969
Change-Id: I72e559314dbe494bbcf1dddf91f309ff8772780c
Stefan Schmidt [Thu, 11 Jun 2020 11:35:52 +0000 (13:35 +0200)]
tests: elm: check return of efl_config_bool_set
Make sure we fail the test, unless this settign succeed.
CID: 1403891
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11968
Daniel Kolesa [Thu, 11 Jun 2020 13:14:03 +0000 (15:14 +0200)]
modules: only build gl_drm evas engine when using es-egl
This module does not work with desktop opengl contexts,
and needs EGL to work.
Jaehyun Cho [Thu, 11 Jun 2020 09:57:30 +0000 (18:57 +0900)]
edje_cc_handlers: update documentation of "fixed" to be clearer
Summary:
Since "fixed" does not affect the group size by the part's min size, the
documentation is updated to be clearer.
Reviewers: woohyun, raster
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11934
Woochanlee [Thu, 11 Jun 2020 07:34:16 +0000 (16:34 +0900)]
elm_calendar: Do not pass NULL to function.
Summary:
T7076
legacy calendar inc/dec button has auto repeat feature.
for that if user click the button very quickly, we delete internal timer than it will pass to function.
to prevent this, need to check NULL pointer.
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11966
Daniel Kolesa [Thu, 11 Jun 2020 00:32:07 +0000 (02:32 +0200)]
ecore: use standard LC_ALL instead of __LC_ALL in systemd module
The former is a POSIX name, the latter is non-standard. I don't
know why the latter was used, considering glibc literally has
just #define LC_ALL __LC_ALL, but change it and unbreak build
on musl and other systems.
Daniel Kolesa [Thu, 11 Jun 2020 00:18:50 +0000 (02:18 +0200)]
eina: only enable EINA_LOG_BACKTRACE when backtrace API is present
This prevents build breakage on platforms that either don't have
backtrace() or don't have the appropriate library for it installed.
Hermet Park [Thu, 11 Jun 2020 07:10:36 +0000 (16:10 +0900)]
evas glengine: fix code sync after migration.
Introduced a wrong result after upstream migration,
since we have tizen only code diff....
Change-Id: Ia4bac99a244a63a1d54c63dd93aea80c5a0bfce0
Carsten Haitzler (Rasterman) [Wed, 10 Jun 2020 18:30:14 +0000 (19:30 +0100)]
efl - build again - test suite break in using undefined ERR macro
Stefan Schmidt [Tue, 9 Jun 2020 13:21:28 +0000 (15:21 +0200)]
tests: eina: make sure we always check on eina_matrixsparse_data_idx_get return
It has been checked in all other places, but has been forgotten in these
two.
CID: 1401081
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11960
Stefan Schmidt [Tue, 9 Jun 2020 13:09:08 +0000 (15:09 +0200)]
tests: eo: handle error return of eina_value_int_convert()
CID: 1400962
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11958
Stefan Schmidt [Tue, 9 Jun 2020 12:04:31 +0000 (14:04 +0200)]
tests: eina: also handle failure cases when cleaning up created files/folders
Somethign fishy is going on if we can not delete the files and folders
we created.
CID: 1400986
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11955
Stefan Schmidt [Wed, 10 Jun 2020 12:12:59 +0000 (14:12 +0200)]
ecore_drm: check return of drmModeSetCrtc()
Report if we fail to reset the Crtc during output free. Only print an
error and keep going with the rest of the output free.
CID: 1402668
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11965
Christopher Michael [Wed, 10 Jun 2020 12:38:02 +0000 (08:38 -0400)]
tests/ecore_wl2: Fix unchecked return value
Coverity reports that we do not check the return of eglInitialize
here.
Fixes Coverity CID1412362
Christopher Michael [Wed, 10 Jun 2020 12:32:40 +0000 (08:32 -0400)]
tests/ecore_wl2: Fix unchecked return value
Coverity reports eglChooseConfig is called without checking return
value here. This patch fixes the issue by checking the return value
and by also making _init_egl return a bool so that we can fail the
test if eglChooseConfig results in failure.
Fixes Coverity CID1412365
Christopher Michael [Wed, 10 Jun 2020 12:26:29 +0000 (08:26 -0400)]
ecore_wl2_tests: Fix formatting
Stefan Schmidt [Tue, 9 Jun 2020 13:17:36 +0000 (15:17 +0200)]
tests: eina: check return of eina_module_load and unload
These could fail as well. Check in testsuite.
CID: 1400961
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11959
Stefan Schmidt [Tue, 9 Jun 2020 12:29:35 +0000 (14:29 +0200)]
tests: evas: check fd being non -1 before using close()
eina_file_mkstemp would return -1 in an error case. Make sure we check
the return when clsoing here.
CID: 1400790
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11957
Vincent Torri [Wed, 10 Jun 2020 05:07:47 +0000 (05:07 +0000)]
Use extern after EAPI
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11961
Hermet Park [Wed, 10 Jun 2020 11:30:19 +0000 (20:30 +0900)]
evas stack: ++safe code.
null check to prevent any crashes (just in case)
Change-Id: Ic77a2c785feba9be32eb1460439f4c3315087e07