Jaechul Lee [Thu, 14 Apr 2022 06:00:24 +0000 (15:00 +0900)]
tizenaudio-sink/source: Fix crash when pulseaudio exit
* Fix pulseaudio crash (pactl exit)
* symbol mismatching(pa_processor_push_reference)
* aarch64 build warning
[Version] 15.0.13
[Issue Type] Bug
Change-Id: I0d7f0d44a95cd9667746529ed1f03151ec92e64a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 21 Apr 2022 08:15:38 +0000 (17:15 +0900)]
tizenaudio-echo-cancel: Fix UNINIT.LOCAL_VAR
This patch fixes the svace and convention issues
* Fix svace issue
* Relace echo with referece
[Version] 15.0.12
[Issue Type] SVACE
Change-Id: I8ebe7e724c090fc4ce8bfa120b0e596d95723a2d
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Thu, 21 Apr 2022 03:52:07 +0000 (12:52 +0900)]
sound-player: Fix INTEGER_OVERFLOW defect
[Version] 15.0.11
[Issue Type] Svace
Change-Id: I224d3ac72c27a1b184baf72933bbe5618a073d45
Jaechul Lee [Tue, 29 Mar 2022 08:06:43 +0000 (17:06 +0900)]
tizenaudio-echo-cancel: Support reference raw copy functionality
processing echo-cancellation in module-tizenaudio-echo-cancel moved to processor
modules for supporting reference copy.
* created reference copy
* removed delayq
[Version] 15.0.10
[Issue Type] New Feature
Change-Id: Id4529e7f6225b1c3f1d6e499bc915aaef1a940c5
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 28 Mar 2022 02:20:50 +0000 (11:20 +0900)]
tizenaudio-echo-cancel: Find reference sink by proplist
[Version] 15.0.9
[Issue Type] New Feature
Change-Id: I28c7c2cb5a569f7f1159ee1a6aa2a4ede54ed0cc
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 28 Mar 2022 05:00:35 +0000 (14:00 +0900)]
tones: Fix coverity issues
The issue of coverity(1286168) was fixed
[Version] 15.0.8
[Issue Type] Coverity
Change-Id: I5eaaa3e59050963ad207634bae5a68631b9b286e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 24 Mar 2022 07:57:45 +0000 (16:57 +0900)]
Add default_method to module parameters
Use default method that is configured at init function if
source-output's 'echo_cancel' property is set to 'default'
[Version] 15.0.7
[Issue Type] Improvement
Change-Id: I137282f954cd01b1eb5e08aedd3f2a5a075e74d6
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 28 Mar 2022 02:33:13 +0000 (11:33 +0900)]
Fix coverity issues
The issue of coverity(1286103) was fixed
[Version] 15.0.6
[Issue Type] Coverity
Change-Id: I3e4b5ca2e925642cc4574136b07a3c736b9a2e69
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 14 Mar 2022 06:29:30 +0000 (15:29 +0900)]
Support webrtc-audio-processsing echo-cancellation
[Version] 15.0.5
[Issue Type] New Feature
Change-Id: Ib3227c185779353747af7f930de13535988b467c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Tue, 15 Mar 2022 02:17:22 +0000 (11:17 +0900)]
Support stream-based echo-cancellation
* Added module-tizenaudio-echo-cancel (Supported adrian, speex)
* Added processor module that processes resampled pcm data
* Added a few messages in sink2/source2
[Version] 15.0.4
[Issue Type] New Feature
Change-Id: Ie6e8c3de0bf5fec20c3a087daf377fdcbd82303b
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
jungsup lee [Mon, 21 Feb 2022 04:17:50 +0000 (13:17 +0900)]
tizenaudio-sink: Reset pollfd's revents after use
revents should be cleared after handling POLLERR. mainloop send a lot of
async message to I/O thread that is stucking on writing pcm. After that,
I/O thread couldn't call poll api because of handling asyncq message.
[Version] 15.0.3
[Issue Type] Bug fix
Change-Id: Ib806cdd77a86fae648b08a5b5e1edc1ed60fbec5
Signed-off-by: jungsup lee <jungsup4.lee@samsung.com>
Sangchul Lee [Wed, 23 Feb 2022 05:40:50 +0000 (14:40 +0900)]
device-manager: Add null check in handle_device_connected()
When the last parameter of handle_device_connected() is NULL,
it gets the required structure again from the list referring to
device-map.json. The result is checked now to avoid unwanted
assertion by other functions.
[Version] 15.0.2
[Issue Type] Improvement
Change-Id: Id3c07d579b1d273386a6eab2e6618abf27baabf8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Tue, 22 Feb 2022 10:34:43 +0000 (19:34 +0900)]
device-manager: Fix svace issues (DEREF_OF_NULL.RET.STAT)
- Add null check for pulse_device_get_proplist()
- Use foreach macro for dynarray on handle_internal_pulse_device()
- Remove unnecessary braces
- Fix some invalid indents
- Revise some code format
[Version] 15.0.1
[Issue Type] Svace
Change-Id: I9ae16c35194f94633063b38b49ff133d9372538d
Seungbae Shin [Mon, 27 Dec 2021 05:56:49 +0000 (14:56 +0900)]
Fix for pulseaudio 15.0 upgrade
[Version] 15.0.0
[Issue Type] Core Upgrade
Change-Id: Ie55fa522a3d1e08c8e898ce626a1a199c0f994e6
Jeongmo Yang [Tue, 28 Dec 2021 05:36:01 +0000 (14:36 +0900)]
stream-manager: Deactivate ducking for audio HAL when stream ducking is removed
Previously, deactivation ducking for audio HAL could be missed.
[Version] 13.0.81
[Issue Type] Bug fix
Change-Id: Ide1206dc98f1dd354cb23e6c8cf06361a1d815e3
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Seungbae Shin [Wed, 27 Oct 2021 10:48:01 +0000 (19:48 +0900)]
device-manager: use container dedicated device-map json
[Version] 13.0.80
[Issue Type] Container
Change-Id: If81c7aed340369e451980142d7c677ff22053f98
Seungbae Shin [Thu, 21 Oct 2021 02:33:28 +0000 (11:33 +0900)]
Fix coverity issues (CHECKED_RETURN / PW.PARAMETER_HIDDEN)
+ Fix minor aarch64 build warning
[Version] 13.0.79
[Issue Type] Build
Change-Id: Ie7ed49cf73beb95ce5db332d6595aa6c6def27ab
jungsup lee [Thu, 14 Oct 2021 08:33:19 +0000 (17:33 +0900)]
tizenaudio-sink: Print log when snd_pcm_avail() return small value continuously
[Version] 13.0.78
[Issue Type] Debugging
Change-Id: I982d1ee7cf7a5d0546902aec9f7a498278b4014a
Jaechul Lee [Mon, 27 Sep 2021 05:58:18 +0000 (14:58 +0900)]
Fix DEREF_OF_NULL.RET.PROC.STAT
[Version] 13.0.77
[Issue Type] VD svace
DF210918-00186
Change-Id: I21b72e6fd96ab07521cb807bc26c44e148c00162
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Fri, 24 Sep 2021 12:27:12 +0000 (21:27 +0900)]
Fix aarch64 build warnings
Fixes following warnings:
- cast to pointer from integer of different size [-Wint-to-pointer-cast]
- format '%llu' expects argument of type 'long long unsigned int', but argument 9 has type 'pa_usec_t' {aka 'long unsigned int'} [-Wformat=]
- format '%d' expects argument of type 'int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
[Version] 13.0.76
[Issue Type] Build
Change-Id: I55a043c48107c3a3c6bf71cbb8b81f54c504180d
Seungbae Shin [Thu, 23 Sep 2021 12:25:03 +0000 (21:25 +0900)]
sound-player: fix memory leak in case of stopping playback
eos signal with the cause must be sent to client to make proper subscription release
[Version] 13.0.75
[Issue Type] Bug fix
Change-Id: Id318f1a4d18eafeea4e343eef6c02ee63ca2960f
Jaechul Lee [Wed, 8 Sep 2021 04:49:32 +0000 (13:49 +0900)]
tizenaudio-sink2/source2: Fix frames_to_write calculation
[Version] 13.0.74
[Issue Type] Bug fix
Change-Id: Ida9fcab0c380fc71125f64dc90d8a186840f40ae
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 13 Sep 2021 00:16:49 +0000 (09:16 +0900)]
device-manager: Fix svace defect (DEREF_OF_NULL.RET.PROC.STAT)
[Version] 13.0.73
[Issue Type] Svace
Change-Id: If07027bfc1f37a296aedf440e03fa04040c42ad1
jungsup lee [Wed, 8 Sep 2021 04:54:40 +0000 (13:54 +0900)]
device-manager-dbus: always place bt-sco device at first in device list
[Version] 13.0.72
[Issue Type] Improvement
Change-Id: I15efd7b12c48a3278ad64e9fdb7a2f409cf4183f
jaechul lee [Mon, 6 Sep 2021 06:33:40 +0000 (06:33 +0000)]
Merge "device-manager: Support to load sink2/source2" into tizen
Seungbae Shin [Mon, 15 Mar 2021 07:45:23 +0000 (16:45 +0900)]
support external bt-sco device for tv
[Version] 13.0.71
[Issue Type] Improvement
Change-Id: Ic9d3d00c5a48e319203468550efa5fb40f6f243d
Jaechul Lee [Thu, 12 Aug 2021 05:45:46 +0000 (14:45 +0900)]
device-manager: Support to load sink2/source2
pulseaudio tries to load tizenaudio-sink2/source2 instead of
tizenaudio-sink/source if 'tizen2' keyword is found in device-map file.
[Version] 13.0.71
[Issue Type] Improvement
Change-Id: Ie9c67f4888fb628961811d906e4d6c396700b14e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 9 Aug 2021 03:41:48 +0000 (12:41 +0900)]
tizenaudio-source2: Use hardware interrupt for capture
* Remove unused arguments
* Use fixed latency
* Use poll event
[Version] 13.0.70
[Issue Type] Improvement
Change-Id: I8be80005a1f8f5ec0e126c76fc54253e2510ea17
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 4 Aug 2021 01:01:56 +0000 (10:01 +0900)]
tizenaudio-sink2: Use hardware interrupt for playback
* Remove unused arguments (block_msec, max_request_msec)
* Use fixed latency
* Use poll event
[Version] 13.0.69
[Issue Type] Improvement
Change-Id: I404474e0da9837df6fc202cc793af0b5d2c6d799
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 30 Jul 2021 04:45:30 +0000 (13:45 +0900)]
device-manager: remove checking module arguments
The comparison of the mod args would be failed if unknown args in
device-manager are added like 'echo=1' and it doesn't need to check
module args validation because each module already checks it.
All arguments would be parsed in case of passing NULL.
[Version] 13.0.68
[Issue Type] Improvement
Change-Id: I2be900ef82ecdedc5c181bdc919cd439d0a4b67d
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 2 Aug 2021 05:47:18 +0000 (14:47 +0900)]
Add module-tizenaudio-sink2/source2
module-tizenaudio-sink2/source2 that are copies of
tizenaudio-sink/source without AEC parts were added for a experimental
functionality such as mmap, echo cancel, and non-interleave.
Change-Id: I09588a5d90737da6e2ee9c8b3fd574db012e71f5
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Mon, 31 May 2021 07:23:04 +0000 (16:23 +0900)]
stream-manager-dbus: Add rpi playback route method handler
[Version] 13.0.67
[Issue Type] Internal feature
Change-Id: Iff4048c39bb7601066f21b58a2176a50377c96b9
Seungbae Shin [Tue, 29 Jun 2021 12:35:46 +0000 (21:35 +0900)]
fixup! tizenaudio-sink/source: write or read by calculated period size instead of fixed time.
[Version] 13.0.66
[Issue Type] Bug
Change-Id: I59f0fe0901e6f07a9a071cd29f08e681162dc527
Seungbae Shin [Mon, 17 May 2021 08:57:49 +0000 (17:57 +0900)]
tizenaudio-sink/source: write or read by calculated period size instead of fixed time.
As this code is workaround code for supporting various hw model such as qualcomm board,
will be refactored soon by using parameters given at loading time.
In addition, use _hal_sysconfdir instead of _sysconfdir macro in spec
[Version] 13.0.65
[Issue Type] Bring-up
Change-Id: I96fef562cd7af2a67d3bed90b5db9f4def3edad4
Seungbae Shin [Thu, 10 Jun 2021 08:40:50 +0000 (17:40 +0900)]
Fix SVACE defect (MEMORY_LEAK.EX)
[Version] 13.0.64
[Issue Type] Svace
Change-Id: I1535c4d0f48d2be2e6c4fc54c2b30a6c668dd59e
Seungbae Shin [Tue, 1 Jun 2021 07:55:06 +0000 (16:55 +0900)]
stream/device-manager: use PA_DEFAULT_CONFIG_DIR instead of hardcoding for configuration path
[Version] 13.0.63
[Issue Type] New HAL
Change-Id: I9e5072c5db449a699b231275883608a55f77f288
Seungbae Shin [Tue, 27 Apr 2021 11:12:24 +0000 (20:12 +0900)]
device-manager: enhance some if-else cascaded statements
[Version] 13.0.62
[Issue Type] Revise
Change-Id: I9f8ac0a13e3ee0ed92530f466537e7290e4e16e0
Jaechul Lee [Mon, 29 Mar 2021 05:17:04 +0000 (14:17 +0900)]
aec-manager: Add audio AEC manager
added new feature
[Version] 13.0.61
[Issue Type] New feature
Change-Id: I401390836ee34ea4444180e9725febd1720ac4a4
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Tue, 6 Apr 2021 02:24:46 +0000 (11:24 +0900)]
tizenaudio-policy: Apply new loopback module management
Comparing with the previous logic, it is now possible to
load multiple loopback modules.
- Each loopback module can be loaded per parent id.
- Loading trigger point is moved from route_change_hook_cb()
to select_device_by_manual_routing()
It relates to VPR-402.
[Version] 13.0.60
[Issue Type] New feature
Change-Id: I516f541a1af0548b99c2f3c80e98e12756776117
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 18 Mar 2021 23:58:42 +0000 (08:58 +0900)]
tizenaudio-policy: Preparation for new loopback module management
[Version] 13.0.59
[Issue Type] Improvement
Change-Id: I1fa78fdc41913f0db7e8d08b0ebe4d4c33b21c62
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 Mar 2021 04:22:30 +0000 (13:22 +0900)]
stream-manager: Pass parent id when calling callback for selecting sink or source
It is also fixed to pass parent_id as unsigned integer to
STREAM CONNECTION CHANGED callback.
[Version] 13.0.58
[Issue Type] Improvement
Change-Id: I64d300df0c7cc3f68fa97d6bffb809e38421801f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 24 Mar 2021 07:08:00 +0000 (16:08 +0900)]
stream-manager: handle ramp finished task only at the main thread
Sometimes sd handle is accessed simultaneously in different thread, which may leads to memory corruption.
This patch makes to handle ramp finish task directly only if inside of main thread.
Otherwise, request a message to make it handle from the main thread.
To avoid possible deadlock, request by posting(async) instead of send(sync).
[Version] 13.0.57
[Issue Type] Bug fix
Change-Id: I178dbc5b29adccc6f74e41b7e105681c3fd570d0
Seungbae Shin [Tue, 23 Mar 2021 11:30:55 +0000 (20:30 +0900)]
Revert "stream-manager: handle ramp finished task at core mainloop"
[Version] 13.0.56
[Issue Type] Revert
This reverts commit
5e4cb76033a4a929c90b4dfb57e69c42ec3f58cc.
Change-Id: I04b5587085b31c29ed57dabac3c42ccc0b4f9869
Seungbae Shin [Fri, 19 Mar 2021 05:34:21 +0000 (14:34 +0900)]
stream-manager: handle ramp finished task at core mainloop
Sometimes sd handle is accessed simultaneously, which may leads to memory corruption.
[Version] 13.0.55
[Issue Type] Bug fix
Change-Id: I214c58c1ccde292c918033aaded695f6b59324ef
Sangchul Lee [Thu, 18 Mar 2021 12:19:13 +0000 (21:19 +0900)]
Add support for notifying stream connection information to the policy implementation
[Version] 13.0.54
[Issue Type] New feature
Change-Id: I63ebdd3e62a40d54b04e0ac83f1654015e6095cb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 18 Mar 2021 11:32:50 +0000 (20:32 +0900)]
stream-manager: Rename enum and function
Incorrect names are revised generically to embrace the actual doing
in the function.
[Version] 13.0.53
[Issue Type] Rename
Change-Id: I2860404667916d7487131fccc02de4fa141f7074
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 18 Mar 2021 11:23:31 +0000 (20:23 +0900)]
stream-manager: Apply designated initializers to arrays
[Version] 13.0.52
[Issue Type] Refactoring
Change-Id: If23ef59b2702618943f2029bd4bcaf35015bba3d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 17 Mar 2021 07:05:44 +0000 (16:05 +0900)]
stream-manager-dbus: remove unnessary dbus_launch_mdnsd()
mdnsd is changed to launch by socket activation
[Version] 13.0.51
[Issue Type] Dependancy
Change-Id: Id957b580d877c802d282fe746248564998552b20
Sangchul Lee [Tue, 16 Mar 2021 05:36:54 +0000 (14:36 +0900)]
stream-manager-dbus: Update mute vconf only after internal set is successful
[Version] 13.0.50
[Issue Type] Bug fix
Change-Id: Id58f2d54e5a88c583f87ab2ecaa56823b36fd8b3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Mon, 8 Mar 2021 08:47:34 +0000 (17:47 +0900)]
stream-manager-dbus: fix improper null handling on handle_get_current_volume_type()
[Version] 13.0.49
[Issue Type] Bug fix
Change-Id: I067eeadf9deabcc17676df254984437920765be4
Seungbae Shin [Thu, 4 Mar 2021 04:02:13 +0000 (13:02 +0900)]
stream-manager-dbus: update volume vconf only after internal set is successful
[Version] 13.0.48
[Issue Type] Bug fix
Change-Id: I9238bbe1602b43f1ac1c56ef0029d248ddb56a22
Jeongmo Yang [Tue, 9 Feb 2021 11:52:10 +0000 (20:52 +0900)]
stream-manager-dbus: Skip virtual stream for ducking streams
- The ducking state is never changed because of virtual stream.
[Version] 13.0.47
[Issue Type] Bug fix
Change-Id: I545f381f8868c40eaa8562bcdf4f6ae3afecfb63
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jaechul Lee [Mon, 25 Jan 2021 05:25:32 +0000 (14:25 +0900)]
hal-interface: Use hal audio api
+ remove minor build warning
[Version] 13.0.46
[Issue Type] Enhancement
Change-Id: Iac9337a9c6f654723eb956f7f7a6b2a85deef8d6
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
jungsup lee [Tue, 5 Jan 2021 06:01:46 +0000 (15:01 +0900)]
device-manager: handle rtsp device
handle rtsp device as network type device
[Version] 13.0.45
[Issue Type] Update
Change-Id: I90e4965c34db184f6177b19cf6e1874a13175723
Signed-off-by: jungsup lee <jungsup4.lee@samsung.com>
Seungbae Shin [Mon, 4 Jan 2021 15:52:21 +0000 (00:52 +0900)]
tizenaudio-policy: unload modules safely when daemon is on shutdown
[Version] 13.0.44
[Issue Type] Bug
Change-Id: Ib92c5cbff8bb48b40eef5685dc5549894a58cdd8
Sangchul Lee [Mon, 28 Dec 2020 08:56:16 +0000 (17:56 +0900)]
stream-manager: Revise conditions to invoke ducking state changed signal
In sink_input_ramp_finish_cb(), it is fixed to send the signal only if
the previous state of stream ducking is DUCKING or UNDUCKING.
Some logs are revised for easy debugging.
[Version] 13.0.43
[Issue Type] Improvement
Change-Id: Ib857d6146afe3279436fa155bf18b0d45e9d1909
Signed-off-by: Sangchul Lee <sangchul1011@gmail.com>
Sangchul Lee [Wed, 23 Dec 2020 05:21:38 +0000 (14:21 +0900)]
tizenaudio-policy: Set use_internal_codec value of combine sink
When a stream is finished, routing path should be updated for one
of remaining streams. If one of them is using internal audio codec
with a combine sink, it should also be updated for the stream.
This patch sets the use_internal_codec value of the combine sink to
true when loading the module if needed.
A function to load the combine module is added and applied.
[Version] 13.0.42
[Issue Type] Bug fix / Refactoring
Change-Id: I02950f4df59535039409b9c75c627dc770c66462
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Fri, 11 Dec 2020 08:50:16 +0000 (17:50 +0900)]
tone-player: Fix asan defect (stack-buffer-underflow)
==pulseaudio==799==ERROR: AddressSanitizer: stack-buffer-underflow on address 0xbdc65da0 at pc 0xb5c397ad bp 0xbdc60db0 sp 0xbdc60e00
READ of size 22 at 0xbdc65da0 thread T0
#0 0xb5c397aa in printf_common(void*, char const*, std::__va_list) (/usr/lib/libasan.so+0x757aa)
#1 0xb5c3b11c in vsnprintf (/usr/lib/libasan.so+0x7711c)
#2 0xb58ca3ba in pa_vsnprintf (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x4a3ba)
#3 0xb58ddcd8 in pa_log_levelv_meta (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x5dcd8)
#4 0xb58dd5c6 in pa_log_level_meta (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x5d5c6)
#5 0xb2e262d8 in module_tone_player_LTX_pa__init (/usr/lib/pulse-13.0/modules/module-tone-player.so+0x22d8)
#6 0xb5ab7072 in pa_module_load (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x56072)
#7 0xb5a9818e in pa_cli_command_load (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x3718e)
#8 0xb5aa06b2 in pa_cli_command_execute_line_stateful (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x3f6b2)
#9 0xb5aa11c4 in pa_cli_command_execute_file_stream (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x401c4)
#10 0x1810a in main (/usr/bin/pulseaudio+0x1810a)
#11 0xb5440c80 in __libc_start_main (/lib/libc.so.6+0x1ac80)
[Version] 13.0.41
[Issue Type] Bug
Change-Id: Ib0c1987d14ac42d47b7e6036b12c1313b275b151
Jaechul Lee [Wed, 9 Dec 2020 03:39:58 +0000 (12:39 +0900)]
tizenaudio-policy: Add max_latency_msec to 100ms
This patch improves the latency of null-src
[Version] 13.0.40
[Issue Type] Improvement
Change-Id: Idf6b2c985dd400a04f71ae5892ed6bd6517612fb
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Thu, 19 Nov 2020 06:37:20 +0000 (15:37 +0900)]
stream-manager: Invoke ramp finish hook when ducking stream is corked
If a user corks a stream that ducking is in progress, it can not get
a ramp finish callback from the pulseaudio core. It leads to invalid
state of the stream ducking handle, therefore it is fixed to trigger
the callback forcedly when this situation happens.
[Version] 13.0.39
[Issue Type] Bug fix
Change-Id: Icbe7d4ce2d70fcbfbba9afb2555a38308df18349
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Wed, 4 Nov 2020 05:20:36 +0000 (14:20 +0900)]
Add null-sink argument norewinds=1
null-sink takes almost 2 seconds when starting to play sound.
[Version] 13.0.38
[Issue Type] Improvement
Change-Id: If53a67c1f822f032f8f3590566b4eaa3b6265d7c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Thu, 29 Oct 2020 08:51:05 +0000 (17:51 +0900)]
Fix various improper memory handling bugs
- memory leaks due to missing message unref
- memory leaks due to missing dbus string array free.
- potential memory corruption due to passing different size of data type.
- use-after-free of string retrieved by dbus_message_iter_get_basic()
- use duplicated string for strtok_r()
[Version] 13.0.37
[Issue Type] Bug
Change-Id: I6dea62168cef2fd1387f1e1a3ffc37eb2fe47fa5
Seungbae Shin [Thu, 29 Oct 2020 07:34:37 +0000 (16:34 +0900)]
stream-manager-dbus: use pa dbus wrapper function if possible
[Version] 13.0.36
[Issue Type] Revise
Change-Id: Ib30dd5934fa4a2554652feb550937d15a2fa177f
Seungbae Shin [Wed, 28 Oct 2020 11:17:32 +0000 (20:17 +0900)]
device-manager-dbus: use pa dbus wrapper function if possible
[Version] 13.0.35
[Issue Type] Revise
Change-Id: I926a1860bc43b789ae5cf5490973f92b9ddd6cbd
Seungbae Shin [Tue, 27 Oct 2020 11:08:46 +0000 (20:08 +0900)]
device-manager-dbus: fix crash of getting empty supported samplerates/formats
[Version] 13.0.34
[Issue Type] Bug
Change-Id: I8faab3479f9bf2daa87d0f818b50f1a95e96caeb
Seungbae Shin [Wed, 2 Sep 2020 08:35:14 +0000 (17:35 +0900)]
Fix build warnings
[Version] 13.0.33
[Issue Type] Build
Change-Id: Idf96facb42ef0260e96ac1d1af4e9ec131c999a7
Seungbae Shin [Fri, 28 Aug 2020 08:54:19 +0000 (17:54 +0900)]
Fix SVACE defect(DEREF_OF_NULL.RET.STAT)
[Version] 13.0.32
[Issue Type] Vulnerability
Change-Id: Ideb267ce415c92c51702558cfdba9cb8cb0bc179
Seungbae Shin [Thu, 27 Aug 2020 10:28:52 +0000 (19:28 +0900)]
Fix Coverity defects
- Unchecked return value (CHECKED_RETURN)
- String not null terminated (STRING_NULL)
[Version] 13.0.31
[Issue Type] Vulnerability
Change-Id: I0e4b8c824c0d6dd9efe71d34d3576aa81453aa83
Seungbae Shin [Fri, 21 Aug 2020 07:31:03 +0000 (16:31 +0900)]
fixup! tizenaudio-publish: publish only built-in devices
adjust log level for ignoring publish
[Version] 13.0.30
[Issue Type] Update
Change-Id: I0476c340de9b4bffc13bf9734bd837fd5f169f92
Seungbae Shin [Thu, 20 Aug 2020 10:07:32 +0000 (19:07 +0900)]
fixup! tizenaudio-discover: ignore local services
skip discovered from localhost(127.0.0.1)
[Version] 13.0.29
[Issue Type] Update
Change-Id: I5faa7ae58b5ebfa8dae5a8c68ba64ff2309096f4
Seungbae Shin [Thu, 20 Aug 2020 06:17:38 +0000 (15:17 +0900)]
stream-manager-dbus: launch mdnsd when remote publish/discover
[Version] 13.0.28
[Issue Type] Update
Change-Id: I0a63ba5c5636e249f640337b25bfd698c18311d9
Jaechul Lee [Wed, 19 Aug 2020 02:48:15 +0000 (11:48 +0900)]
stream-manager: add publish/discover/set_permission interfaces
method name : SetRemotePermission
method argument : [in] string for type
[in] unsigned for index
[in] boolean for allowed
return value : None
method name : DiscoverRemoteDevice
method argument : [in] boolean for enable
return value : None
method name : PublishLocalDevice
method argument : [in] boolean for enable
return value : None
[Version] 13.0.27
[Issue Type] New feature
Change-Id: I6ab4a388410dcf4d9480bdc1aaaaa7202a199a9f
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Seungbae Shin [Tue, 18 Aug 2020 11:10:32 +0000 (20:10 +0900)]
stream-manager: add restriction for accessing denied remote device
includes minor code refactoring
[Version] 13.0.26
[Issue Type] Update
Change-Id: I1d77ff249192bde15b861c9a9d481e3564b791d6
Seungbae Shin [Tue, 18 Aug 2020 10:36:53 +0000 (19:36 +0900)]
device-manager: handle tunnel device
tunnel device will be registered(unregistered) when the remote access permission is allowed(denied).
tunnel device will be a network type device
[Version] 13.0.25
[Issue Type] Update
Change-Id: I897fcb5a74ee55c60112e5a9d956c909aae736d0
Seungbae Shin [Mon, 13 Jul 2020 02:13:47 +0000 (11:13 +0900)]
tizenaudio-publish: publish only built-in devices
[Version] 13.0.24
[Issue Type] Update
Change-Id: I69753da561c813c80c35df7690d4efc1efc48a43
Seungbae Shin [Tue, 14 Jul 2020 11:24:16 +0000 (20:24 +0900)]
tizenaudio-discover: use new tunnel module
[Version] 13.0.23
[Issue Type] Update
Change-Id: I42946234489dffb5e936d49ce7a6eb46aec5dcaa
Seungbae Shin [Mon, 13 Jul 2020 02:12:18 +0000 (11:12 +0900)]
tizenaudio-discover: ignore local services
[Version] 13.0.22
[Issue Type] Update
Change-Id: I6e8f334e6a16f5f4367c002ea5bd5809dc6b561b
Seungbae Shin [Mon, 23 Mar 2020 11:22:54 +0000 (20:22 +0900)]
Add module-tizenaudio-discover / module-tizenaudio-publish for remote audio feature
module-tizenaudio-discover : based on module-zeroconf-discover with mDNSResponder porting
module-tizenaudio-publish : based on module-bonjour-publish with minor changes
[Version] 13.0.21
[Issue Type] New feature
Change-Id: Id47dad038bfae487bbe57a09aaece674b30f9008
Sangchul Lee [Thu, 25 Jun 2020 07:05:26 +0000 (16:05 +0900)]
Exclude ringbacktone stream from changing call active routing logic
stream_is_call_family() is also renamed to
is_stream_related_call_active_routing()
[Version] 13.0.20
[Issue Type] Bug fix
Change-Id: Iedee8a5c2e655d4bf4c9f0275c0ed8c0c5450621
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Thu, 28 May 2020 01:53:46 +0000 (10:53 +0900)]
Add Tizen_HW_Touch.ogg at /usr/share/sound/mm-sound directory
This file is moved from libmm-sound because sound_server doesn't exist.
[Version] 13.0.19
[Issue Type] None
Change-Id: I14801824c87c4388addfbb465092d04b965e2bb9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 27 May 2020 01:41:01 +0000 (10:41 +0900)]
tone-player: Add sink_input_detach callback
sink_input_detach_cb function was added to synchronize I/O and main
thread. This commit fixes the unlink issue(
f8cde9099) completely.
In additional, handle_sound_stop returns invalid param error when it is
called with invalid handle.
[Version] 13.0.18
[Issue Type] Bug fix
Change-Id: I1f2ede6c0acc6728e1055317124815db3dbd859c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Tue, 19 May 2020 01:32:38 +0000 (10:32 +0900)]
stream-manager: Select new proper device even if sink or source of new data is set
In tizen policy, selecting device is performed in tizenaudio-policy
module. The previous codes skip selecting the device logic if sink or
source of new data is defined(probably aka default sink/source) in
somewhere before the codes. This patch set it regardless of this matter.
We need to be aware of this modification for possible issues regarding
it. If the skip logic is needed anyway later, we may put that in
another place.
[Version] 13.0.17
[Issue Type] Bug fix
Change-Id: I92df553b259d8ae1ff9de6c29723ccbb78bfaee6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Mon, 18 May 2020 06:44:24 +0000 (15:44 +0900)]
tone-player: Adds unlinked variable when a stream is stopped
Unlink messages is sent twice in a row in I/O thread. So, it make
sink_input_kill function call twice without a guard on TM1.
[Version] 13.0.16
[Issue Type] Bugs
Change-Id: Ibbe3041a64107ce4fdcf842658a472aad3c23d02
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Fri, 3 Apr 2020 00:32:53 +0000 (09:32 +0900)]
tone-player: Adds new tone playback APIs
These new APIs will be used by capi-media-tone-player.
server : org.pulseaudio.Server
object path : /org/pulseaudio/TonePlayer
interface : org.pulseaudio.TonePlayer
method name : TonePlay
method argument : [in] unsigned int for tone index
[in] signed int for duration
[in] signed int for client pid
[in] string for role
[in] signed int for parent id
[out] unsigned int for stream index
return value : None
method name : ToneStop
method argument : [in] unsigned int for stream index
return value : None
[Version] 13.0.15
[Issue Type] Improvement
Change-Id: I090e917e26697250bb187b0d2df8cd6042875354
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Mon, 4 May 2020 01:31:10 +0000 (10:31 +0900)]
Fix resource leaks when pulseaudio is terminated
This resource leak makes abort signal in core_free function and then
spends times to make unnecessary crash dump.
Change-Id: Iccc7cdce2e60985f73a819e83cf7f4887cfdaac9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Tue, 28 Apr 2020 01:27:38 +0000 (10:27 +0900)]
Changes PA_PCM_DUMP_PA_* to PA_PCM_DUMP_*
Change-Id: Ie02cdb0a276b0f440057bb6b1124e1d5076f3124
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 23 Apr 2020 08:12:13 +0000 (17:12 +0900)]
tizenaudio-policy: Removes unused pcm dump define
[Version] 13.0.14
[Issue Type] None
Change-Id: I83e01e8eeb120ad76f68d7f9070e1e40f0543be9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 22 Apr 2020 01:32:41 +0000 (10:32 +0900)]
sound-player: Fix memory leak in stop APIs
Every time stop APIs called, memory leak found. The reason why
sink_input's userdata that has wrapper structure such as
memblockq_stream, file_stream should be freed.
[Version] 13.0.13
[Issue Type] Bug
Change-Id: I221a6ace56b4c57f288c263c6e3b5fe5abf5e38a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Wed, 8 Apr 2020 06:06:48 +0000 (15:06 +0900)]
sound-player: Adds error return for not supported media type
added checking not support media type error and checking invalid handle
in sound_stop function. in this case, sound_server returns
org.tizen.multimedia.audio.InvalidState and it changes to INVALID_OPERATION
[Version] 13.0.12
[Issue Type] Add
Change-Id: I35db85891d6c54f6af09449668e09ea01c09ff7a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Wed, 1 Apr 2020 23:43:22 +0000 (08:43 +0900)]
stream-manager: Check role/route_type functions to skip process are revised
check_role_to_skip()/check_route_type_to_skip() are renamed to
is_invalid_role()/is_invalid_route_type() respectively.
Specific conditions inside of the previous functions are
moved out of the new renamed functions.
[Version] 13.0.10
[Issue Type] Refactoring
Change-Id: Ie6ec2e0a3b42078d1265e15ef35db240daad2111
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Tue, 31 Mar 2020 05:11:34 +0000 (14:11 +0900)]
Remove unused header files
symdef.h isn't used anymore.
backport mainline commit
d9624e038 for removing unused code
[Version] 13.0.10
[Issue Type] Refactoring
Change-Id: Id249e22d1cdf41a37b331d89bcdaefc1f5a4e67e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jaechul Lee [Thu, 26 Mar 2020 08:13:48 +0000 (17:13 +0900)]
sound-player: Adds new sound playback APIs
These new APIs will be used by capi-media-wav-player.
server : org.pulseaudio.Server
object path : /org/pulseaudio/SoundPlayer
interface : org.pulseaudio.SoundPlayer
method name : SoundPlay
method argument : [in] string for input filename
[in] signed int for loop count
[in] signed int for client pid
[in] string for role
[in] signed int for parent id
[out] signed int for stream index
return value : None
method name : SoundStop
method argument : [in] signed int for stream index
return value : None
signal aname : EOS
signal argument : [out] signed int for stream index
return value : None
[Version] 13.0.9
[Issue Type] Add
Change-Id: Ifff7fc327a8fdd47595c9411b983e97b9623b259
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Wed, 1 Apr 2020 00:02:46 +0000 (09:02 +0900)]
stream-manager: Add conditions not to notify stream connection/disconnection twice
This notification invokes HAL function for stream connection changed.
There were cases that this functions is invoked twice unintentionally
according to the scenario related to calling cork/uncork from client
side. For example, gstreamer pulsesink and playbacks from sound-server.
It is now fixed to trigger the notification one at a time properly.
[Version] 13.0.8
[Issue Type] Improvement
Change-Id: I1ef748ad514c87e01034e4f5bd8fc9b1083be34b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Seungbae Shin [Wed, 11 Mar 2020 07:36:57 +0000 (16:36 +0900)]
sound-player: add stop / stop_all operation for simple playbacks
[Version] 13.0.7
[Issue Type] Add
Change-Id: I9b9e1653496f77d24c0aab0d7b3e093b547e080f
Jaechul Lee [Thu, 19 Mar 2020 04:24:09 +0000 (13:24 +0900)]
poweroff: Changes the file permission to 644
removed unnecessary permissions.
Change-Id: I729f31ccdfa748c0dfc0a8b9484940962ead4b69
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Jeongmo Yang [Mon, 16 Mar 2020 11:15:09 +0000 (20:15 +0900)]
stream-manager-dbus: Send signal for ducking immediately when duration is 0
- sink_input_ramp_finish_cb is not called when duration is 0
[Version] 13.0.6
[Profile] Common
[Issue Type] Bug fix
Change-Id: I292d620472a57b13ecaa6b69d81206e289552a6b
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Seungbae Shin [Mon, 16 Mar 2020 05:58:32 +0000 (14:58 +0900)]
replace source SET_STATE handlers with callbacks
[Version] 13.0.5
[Issue Type] Bug / Upgrade
Change-Id: I46b2885d566b8ebcdc555d28260f4ce25f7fe7d2
Seungbae Shin [Thu, 12 Mar 2020 12:21:17 +0000 (21:21 +0900)]
replace sink SET_STATE handlers with callbacks
[Version] 13.0.4
[Issue Type] Bug / Upgrade
Change-Id: Ic762a7ea4262b4d661a6a85191a00e0e45f884a3
Seungbae Shin [Mon, 9 Mar 2020 03:01:40 +0000 (12:01 +0900)]
Fix coverty defects (CHECKED_RETURN)
[Version] 13.0.2
[Issue Type] Vulnerability
Change-Id: Ifc9ef1f508155b34c06a8b14b5cd27fde67ae35d
Seungbae Shin [Mon, 24 Feb 2020 11:49:58 +0000 (20:49 +0900)]
Remove module-hw-keysound which is no longer supported
[Version] 13.0.2
[Issue Type] Dependencies
Change-Id: I2eb24577bd68fe6ce6cadb84b90ba3c63c057e00