platform/core/multimedia/mmsvc-core.git
3 months agoUpdate the file descriptor valid checker 20/321020/3 accepted/tizen_9.0_unified tizen_9.0 accepted/tizen/9.0/unified/20250319.161943
YoungHun Kim [Thu, 13 Mar 2025 06:03:24 +0000 (15:03 +0900)]
Update the file descriptor valid checker

Change-Id: Id1b19cfc353135cb6da7cbdd38df02b8af03dbc9

4 months agoFix path activation issue 08/318508/1 accepted/tizen/9.0/unified/20250118.074102
YoungHun Kim [Thu, 16 Jan 2025 09:28:17 +0000 (18:28 +0900)]
Fix path activation issue

 - Issue : muse-server.service is launched even without the wm_ready file by unnecessary service
 - Solution : Removed unnecessary service files of multi-user.target.wants

Change-Id: I2b463d6e23f4541e67a2a84c5fafd55cb6c0ae28
(cherry picked from commit 4a08a10866d17e0f8a9db6506459f591cee11f19)

5 months agoUse timer instead of idle callback 41/316941/1 accepted/tizen/9.0/unified/20241224.150105
YoungHun Kim [Mon, 9 Dec 2024 04:21:57 +0000 (13:21 +0900)]
Use timer instead of idle callback

 - Add the log to debug muse server is not ready.
 - Terminate on ready file creation failure.
 - Update ms_deinit() and LOG_TAG also.

Change-Id: Id5f946f2b59efe41e561f79eb67b1b32728c722d
(cherry picked from commit ae6dc24b6c084e23fd21968d1e815a368e48d587)

6 months agoMerge branch 'tizen' into tizen_9.0 79/320679/1 accepted/tizen/9.0/unified/20241125.071439
YoungHun Kim [Thu, 21 Nov 2024 00:01:25 +0000 (09:01 +0900)]
Merge branch 'tizen' into tizen_9.0

Change-Id: I04a4bf330ef03a65156dff76bfc52788e806551b

6 months agoFix svace issue 49/320549/2 accepted/tizen/unified/20241119.153901 accepted/tizen/unified/x/20241218.032652 accepted/tizen/unified/x/asan/20241224.004419
YoungHun Kim [Mon, 18 Nov 2024 09:48:03 +0000 (18:48 +0900)]
Fix svace issue
 - SEC_DO_NOT_ASSIGN_SIZE_OF_INT
   SEC_DO_NOT_CAST_LONG_TO_DOUBLE
   DEREF_OF_NULL.RET.STAT

Change-Id: I37129d3463ca68d2d532b634a82911a6822b0b37

7 months agoArray-based socket variable optimization 16/319616/1 accepted/tizen/unified/20241114.153907
YoungHun Kim [Mon, 28 Oct 2024 11:52:50 +0000 (20:52 +0900)]
Array-based socket variable optimization

Change-Id: I93aba5e2fc658d4adbb32d5faf6a55d17ae9595b

7 months agoRegister connection_handler at idle callback 27/319527/4
YoungHun Kim [Fri, 25 Oct 2024 02:54:17 +0000 (11:54 +0900)]
Register connection_handler at idle callback

 - It is to ensure that the connection_handler is executed after the muse server is ready.
 - Remove CRLF and unnecessary variable.
 - Set check_cpu_memory false by default for performance.
 - Change the function name.

Change-Id: I23ff908dfb572c3034749c2a01b1140368360bb9

8 months agoChange the path of muse-server service to /run/.wm_ready 58/318458/1 accepted/tizen_unified_toolchain accepted/tizen/9.0/unified/20241030.233317 accepted/tizen/unified/20241004.041914 accepted/tizen/unified/toolchain/20241022.122449 accepted/tizen/unified/toolchain/20241022.122921 accepted/tizen/unified/x/20241006.082023 accepted/tizen/unified/x/asan/20241014.000028 tizen_9.0_m2_release
YoungHun Kim [Mon, 30 Sep 2024 05:37:21 +0000 (14:37 +0900)]
Change the path of muse-server service to /run/.wm_ready

Change-Id: Ifb81cc209d1610324a39783425b707420bb9a4f9

8 months agofixup! Add support for gcov by gcc version 59/318259/3 accepted/tizen/unified/20240928.111254 accepted/tizen/unified/20240928.221350 accepted/tizen/unified/toolchain/20241004.101709 accepted/tizen/unified/x/20240929.082812
YoungHun Kim [Thu, 26 Sep 2024 06:25:50 +0000 (15:25 +0900)]
fixup! Add support for gcov by gcc version

Change-Id: I42595acb0c462f7442bcccc6a8750df3b129da39

8 months agoAdd support for gcov by gcc version 31/318231/4
YoungHun Kim [Thu, 26 Sep 2024 00:34:26 +0000 (09:34 +0900)]
Add support for gcov by gcc version

Change-Id: Ib4bac23e229a54640efb3d273a6d99edec9a1d6e

9 months agofixup! Add the service to 'After' option because 'rscmgr-service.serivce' is essential 65/316565/1 accepted/tizen_unified_dev accepted/tizen/unified/20240828.164007 accepted/tizen/unified/dev/20240829.043828 accepted/tizen/unified/x/20240829.020346
YoungHun Kim [Fri, 23 Aug 2024 04:21:21 +0000 (13:21 +0900)]
fixup! Add the service to 'After' option because 'rscmgr-service.serivce' is essential

Change-Id: I0649ff1b9985f6d1e3fa16a1739ee381a3ebac5d

10 months agoAdd the service to 'After' option because 'rscmgr-service.serivce' is essential 76/315576/3 accepted/tizen/unified/20240806.010547 accepted/tizen/unified/dev/20240807.092905 accepted/tizen/unified/toolchain/20240812.132645 accepted/tizen/unified/x/20240806.104709 accepted/tizen/unified/x/asan/20240813.230934
YoungHun Kim [Mon, 5 Aug 2024 01:04:30 +0000 (10:04 +0900)]
Add the service to 'After' option because 'rscmgr-service.serivce' is essential

Change-Id: I712036f5a3b6334eeb966e5cf4f73f6c3a244371

10 months agoRemove mm-resource-manager dependency 93/315493/1
YoungHun Kim [Thu, 1 Aug 2024 22:20:58 +0000 (07:20 +0900)]
Remove mm-resource-manager dependency

Change-Id: I7b763b18b9d09293c16bbb7a5611ffc267aadd2f

10 months agoUpdate to log the cpu and memory information 71/314971/3 accepted/tizen/unified/20240726.010948 accepted/tizen/unified/dev/20240729.000827 accepted/tizen/unified/x/20240727.073543
YoungHun Kim [Wed, 24 Jul 2024 03:06:15 +0000 (12:06 +0900)]
Update to log the cpu and memory information

 - Disable it at TV product

Change-Id: I1ef953f9392f407e4d90f0aa79335a7167127f69

10 months agoSkip logging thread information by performance at licensing tv 72/314772/2 accepted/tizen/unified/20240722.104238 accepted/tizen/unified/dev/20240724.110035 accepted/tizen/unified/x/20240723.043603
YoungHun Kim [Thu, 18 Jul 2024 05:57:39 +0000 (14:57 +0900)]
Skip logging thread information by performance at licensing tv

Change-Id: I074c32e2a66b9cddbca6299e6d4fe9acb562430f

10 months agoMemoryLimit has been replaced by MemoryMax 24/312124/2 accepted/tizen/unified/20240716.112407 accepted/tizen/unified/20240716.140246 accepted/tizen/unified/dev/20240717.110324 accepted/tizen/unified/x/20240717.012449
Łukasz Stelmach [Tue, 4 Jun 2024 10:47:57 +0000 (12:47 +0200)]
MemoryLimit has been replaced by MemoryMax

The  MemoryLimit option is marked as deprecated in systemd and needs to
be changed to MemoryMax in unit files.

Change-Id: I870e58350c3b15ddc205f3622a02fb2755e5ee87
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
10 months agoFix SVACE defects (LIB.INSECURE_STRNCMP) 56/314556/1
YoungHun Kim [Mon, 15 Jul 2024 07:39:28 +0000 (16:39 +0900)]
Fix SVACE defects (LIB.INSECURE_STRNCMP)

Change-Id: Iab136fe7ea741765f89e5bf044ceaa14506058ee

13 months agoRevise environment variables path in VD product 24/310924/2 accepted/tizen/unified/20240513.053400 accepted/tizen/unified/dev/20240620.005532 accepted/tizen/unified/x/20240514.011848 accepted/tizen/unified/x/asan/20240625.092327
YoungHun Kim [Fri, 10 May 2024 00:06:03 +0000 (09:06 +0900)]
Revise environment variables path in VD product

[Background]
 A service which has a dependency on tizen-system-env.service gets delayed, so the path is updated as of Tizen 8.0
 with creating tizen-system-env in /opt/ ( only at first boot ) and a symlink in /run/.

Change-Id: Ica8a54013c488820d82b43080b96f2bae00579d9

13 months agoAdjusting CPU Scheduling Policy and Priority for Licensing TV performance optimization 23/310823/4
YoungHun Kim [Wed, 8 May 2024 22:37:14 +0000 (07:37 +0900)]
Adjusting CPU Scheduling Policy and Priority for Licensing TV performance optimization

Issue : VO analyze that performance issue is caused by a boost related CPU usage
Change :
 - Set CPUSchedulingPolicy to 'rr' for implementing the round robin, default is other.
 - Set CPUSchedulingPriority to 5, default is 0.

Change-Id: I6167e4804882c3d8020b9968a77c1a47bd9e60f7

15 months agoEnable path activation for vd touch interactive products 65/307065/2 accepted/tizen/unified/20240306.094017 accepted/tizen/unified/toolchain/20240311.065453 accepted/tizen/unified/x/20240307.010754
YoungHun Kim [Mon, 4 Mar 2024 09:52:37 +0000 (18:52 +0900)]
Enable path activation for vd touch interactive products

Change-Id: I94bdcab89ed4e9014582d4849bc59b50944cf625

16 months agoConfigure on-demand with socket activation on licensing TV 55/293355/15
YoungHun Kim [Thu, 25 May 2023 02:19:05 +0000 (11:19 +0900)]
Configure on-demand with socket activation on licensing TV

Change-Id: Ia70c2696231b58d52fd950addae28a8fbbcc7b14

17 months agofixup! Fix coverity issue of MISSING_LOCK 20/303820/4 accepted/tizen_unified_riscv accepted/tizen/unified/20240109.155327 accepted/tizen/unified/riscv/20240110.014504
YoungHun Kim [Fri, 5 Jan 2024 07:42:40 +0000 (16:42 +0900)]
fixup! Fix coverity issue of MISSING_LOCK

Change-Id: I2466ac59c344573de3d1f6fd8ea49e53cc73d43b

17 months agoFix coverity issue of MISSING_LOCK 27/303527/14 accepted/tizen/unified/20240104.012435 accepted/tizen/unified/riscv/20240105.060146
YoungHun Kim [Mon, 1 Jan 2024 22:43:38 +0000 (07:43 +0900)]
Fix coverity issue of MISSING_LOCK

Change-Id: I06dcf6d05fca477846327b00b0d99bf44b373354

17 months agoFix svace issue of PASSED_TO_PROC_AFTER_RELEASE 41/303141/1 accepted/tizen/unified/20231221.165329 accepted/tizen/unified/riscv/20231226.211318
YoungHun Kim [Wed, 20 Dec 2023 08:13:35 +0000 (17:13 +0900)]
Fix svace issue of PASSED_TO_PROC_AFTER_RELEASE

Change-Id: I24952080e6c800d393d257a06369bef528a671e5

18 months agoApply CPU inheritance boosting to improve connection performance 07/300307/20 accepted/tizen/unified/20231206.103833 accepted/tizen/unified/20231206.151800 accepted/tizen/unified/riscv/20231219.070908
YoungHun Kim [Fri, 20 Oct 2023 08:02:02 +0000 (17:02 +0900)]
Apply CPU inheritance boosting to improve connection performance

Change-Id: Ic5118202ffeb933f128c55985363425a3c6cc532

19 months agoImprove VD muse-server.service initialization 53/300753/2 accepted/tizen/unified/20231103.094551
YoungHun Kim [Thu, 2 Nov 2023 00:34:10 +0000 (09:34 +0900)]
Improve VD muse-server.service initialization

 - Remove standalone part
 - Set default dependency as 'no'
 - Execute after sysinit.target
 - Avoid cpu contention using boostshell

Change-Id: I1305541e365c38c8906fa2217bf340154a9533d5

19 months agoRemove unnecessary path file 72/300672/2 accepted/tizen/unified/20231101.174509
YoungHun Kim [Tue, 31 Oct 2023 06:23:59 +0000 (15:23 +0900)]
Remove unnecessary path file

 - There is currently no dependency on tvplus_ready at VD

Change-Id: I9e2be4e3e5c38c1f1e0edaba2b70c9435111ed61

19 months agoAdd to detect stdin close 01/300401/4 accepted/tizen/unified/20231030.034754
YoungHun Kim [Tue, 24 Oct 2023 01:19:04 +0000 (10:19 +0900)]
Add to detect stdin close

 - There is issue of accept() 0 after idle, which means stdin is already closed as below.
    muse_server_private.c: _ms_check_idle_state(523) > [#3] 2707s [period 900s] [0d 10h 8m 56s]
    ...
    _ms_connection_handler(376) > Critical Error : accept 0 is invalid

   So I add to check periodically the status during idle and after destroy() to debug issue.

Change-Id: I866e638c9a9a98b74fdad58f963c7cb39c14b7ed

19 months agoRevert "Disable system resource boost" 27/300327/4 accepted/tizen/unified/20231024.032152
YoungHun Kim [Mon, 23 Oct 2023 02:22:22 +0000 (11:22 +0900)]
Revert "Disable system resource boost"

This reverts commit 638fd25b1db57654921968a8fa6bca0248b856fb.

Change-Id: I6abc61876dfdbfa147095728eba341d358cf1b76

20 months agoDisable system resource boost 60/299260/2 accepted/tizen/8.0/unified/20231005.093513 accepted/tizen/unified/20230925.160809 tizen_8.0_m2_release
YoungHun Kim [Sun, 24 Sep 2023 22:22:09 +0000 (07:22 +0900)]
Disable system resource boost

 - Recently, we have applied a system resource boost for service launching performance
   despite the restrictions (client connection issue during cpu boost) by VD requirement
   but the restriction issue came up as expect. Since I disable it at first with keeping
   the relevant code rather than rollback a patch.

Change-Id: I866342f8d526b39b1ff49d8a46deaeb197e14d9e

21 months agoAdd system resource boosting API at VD 32/298232/14 accepted/tizen/unified/20230914.100348
YoungHun Kim [Mon, 4 Sep 2023 03:17:27 +0000 (12:17 +0900)]
Add system resource boosting API at VD

Change-Id: I328e47ebbd5c46e0a7cd67b8babf44387d603a72

21 months agoExclude storage dependency for VD 66/298566/4
YoungHun Kim [Mon, 11 Sep 2023 00:21:40 +0000 (09:21 +0900)]
Exclude storage dependency for VD

 - Remove unnecessary parts
 - Revise the same flag name of the cmake and source file

Change-Id: I1df397e258c932b1b8c3df16e26ec1999e3eb474

21 months agoAdd ISU package 91/298391/3 accepted/tizen/unified/20230912.013602
Mateusz Moscicki [Tue, 18 Jul 2023 13:12:44 +0000 (15:12 +0200)]
Add ISU package

This commit adds Individual Service Upgrade (ISU) feature to muse package.
When installed it will allow to upgrade this service using ISU mechanism,
without the need to perform full OS Upgrade.

This commits add necessary configuration to create upgrade packages of
needed format.  ISU framework itself is maintained and installed separately.

Change-Id: Ib30741bf33cb82d4d8565bae2b65520f3e9b430a
Signed-off-by: Mateusz Moscicki <m.moscicki2@samsung.com>
2 years agofixup! Set simple type at tv service 78/293478/1 accepted/tizen/unified/20230531.034439
YoungHun Kim [Tue, 30 May 2023 08:01:46 +0000 (17:01 +0900)]
fixup! Set simple type at tv service

Change-Id: I866524a6e61f224ea72487cec152c9285fec1016

2 years agoRemove unnecessary comment at README file 48/293348/1 accepted/tizen/unified/20230528.171048
YoungHun Kim [Thu, 25 May 2023 01:48:11 +0000 (10:48 +0900)]
Remove unnecessary comment at README file

Change-Id: I57377dbc627fe7c8a190b150875bb44d85b9676d

2 years agoChange name for threads 14/292814/4
Jeongmo Yang [Mon, 15 May 2023 07:16:46 +0000 (16:16 +0900)]
Change name for threads

[Version] 0.3.170
[Issue Type] Update

Change-Id: Ife951d0eac99f5c8c550df7a00eb704d38c35085
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agoRevert "Install the notstrip file to avoid be stripped at vd product" 29/292729/3
YoungHun Kim [Fri, 12 May 2023 03:08:39 +0000 (12:08 +0900)]
Revert "Install the notstrip file to avoid be stripped at vd product"

 - vd requirement which 'not stripped' is not need now.

Change-Id: Iad6d111a1803a88c92da534cc0f621a078534cbc

2 years agoExit process in forking error case to avoid systemd timeout 91/292491/2
YoungHun Kim [Tue, 9 May 2023 04:18:26 +0000 (13:18 +0900)]
Exit process in forking error case to avoid systemd timeout

Change-Id: Ib2d183daa28f48e12824f50ac78b989fac4627a2

2 years agoFix coverity issue of OVERRUN and UNUSED_VALUE 09/291309/2 accepted/tizen/unified/20230417.140301
YoungHun Kim [Thu, 13 Apr 2023 06:21:39 +0000 (15:21 +0900)]
Fix coverity issue of OVERRUN and UNUSED_VALUE

Change-Id: I62c2a7a4c46bd5fb77fef1b89dd7731ea2013c05

2 years agoSet simple type at tv service 49/289849/14
YoungHun Kim [Tue, 14 Mar 2023 16:20:57 +0000 (01:20 +0900)]
Set simple type at tv service

 - Avoid netlink event delay issue of parent or child process by daemonzing
 - UPdate dlog

Change-Id: I91a9d22eddd893d94d12cac3873d87f73da06e7b

2 years agoRevert "boost muse-server for PNP mode at tv profile" 62/290562/1
YoungHun Kim [Wed, 29 Mar 2023 01:51:04 +0000 (01:51 +0000)]
Revert "boost muse-server for PNP mode at tv profile"

This reverts commit 5630fb38335f5b2e32b292f1e7abba6f178a4baa.

Change-Id: I4f78a9e8f6dcd4684d8d16929ae9f44f19f7d3b6

2 years agoboost muse-server for PNP mode at tv profile 07/289607/2
YoungHun Kim [Fri, 10 Mar 2023 08:31:04 +0000 (17:31 +0900)]
boost muse-server for PNP mode at tv profile

 - update log level

Change-Id: I794beb57e84503287165fc426e24ed7053663f89

2 years agoFix svace issue 28/288728/3 accepted/tizen/unified/20230309.035202
YoungHun Kim [Wed, 22 Feb 2023 06:22:56 +0000 (15:22 +0900)]
Fix svace issue

Change-Id: If274f4d84044220e9543991f49f073291a893da7

2 years agoApply with GMutexLocker for code conciseness 90/288390/7 accepted/tizen/unified/20230220.174504
YoungHun Kim [Thu, 16 Feb 2023 05:24:00 +0000 (14:24 +0900)]
Apply with GMutexLocker for code conciseness

Change-Id: I76594247fc8bb59d8726c82cfd68487050ddc478

2 years agoCheck the stat file again to make sure it's cpu busy 33/287933/25
YoungHun Kim [Wed, 8 Feb 2023 02:12:24 +0000 (11:12 +0900)]
Check the stat file again to make sure it's cpu busy

 - CPU utilization, as some tools like pcup may not be actively maintained or may not be accurate on modern systems.
 - The top, mpstat, sar, and htop commands are commonly used to monitor CPU usage on Linux systems.
 - So I have updated to check again the /proc/stat periodically after new timer creation considering performance

Change-Id: If76612dec2ed201abe617bbf4c7fd192a979f2f0

2 years agofixup! Fix heap-use-after-free issue 34/285834/4 accepted/tizen/unified/20221222.055310
YoungHun Kim [Wed, 21 Dec 2022 04:42:53 +0000 (13:42 +0900)]
fixup! Fix heap-use-after-free issue

 - By thread scheduling, the data thread can be executed before setting the value of 'is_created'.
   where is set at _ms_ipc_dispatch_create().  So I remove to check value of 'is_created' which cause
   it not to run despite normal data thread execution. Instead we can use muse_server_module_is_valid().

Change-Id: I8bc4c0ac65d4ee98e477c0d5e475c2c60cff289e

2 years agoPrint socket fd value at dlog when send() failed 85/285385/3
YoungHun Kim [Fri, 9 Dec 2022 05:07:50 +0000 (14:07 +0900)]
Print socket fd value at dlog when send() failed

Change-Id: I5138e668331290b6b54ad0e13056decfd91138df

2 years agoFix heap-use-after-free issue 67/285067/1 accepted/tizen/unified/20221206.170602
YoungHun Kim [Mon, 5 Dec 2022 02:56:20 +0000 (11:56 +0900)]
Fix heap-use-after-free issue

 - After module's msg thread exit, the paired data thread could be accessed
 - Add to check if module is freed or not with module's memset variable

Change-Id: I26f18ed896420915f1cdab2b3f03f15d137a1436

2 years agoCheck module's idx value to avoid dlog crash 39/284839/3 accepted/tizen/unified/20221130.171036
YoungHun Kim [Mon, 28 Nov 2022 11:28:35 +0000 (20:28 +0900)]
Check module's idx value to avoid dlog crash

 - We have issue of dlog crash when the value of module's idx is -1.
   Unfortunately, there is no log file, so if module idx is abnormal,
   we do not take the log at first.

Change-Id: I051871c96c71aacd8d130b5b110ff72b19e2620e

2 years agoFix heap-use-after-free 03/284703/3
YoungHun Kim [Thu, 24 Nov 2022 02:37:34 +0000 (11:37 +0900)]
Fix heap-use-after-free

 - Module released by _ms_ipc_module_cleanup() could be used again in ms_ipc_create_msg_dispatch_worker
 - Put into protected critical section for ms_ipc_create_msg_dispatch_worker()

Change-Id: Id68e77b5da8db91f132429bed230be03895c6857

2 years agoFix Svace issue of SEC_DO_NOT_ASSIGN_SIZE_OF_INT 42/283242/1 accepted/tizen/unified/20221104.082248
YoungHun Kim [Thu, 20 Oct 2022 23:18:13 +0000 (08:18 +0900)]
Fix Svace issue of SEC_DO_NOT_ASSIGN_SIZE_OF_INT

Change-Id: I967f1b9c08818c86de2b5c225e5b65fb5a461386

2 years agoFix Svace issue of SIGNED_TO_BIGGER_UNSIGNED 45/283145/2
YoungHun Kim [Wed, 19 Oct 2022 03:41:44 +0000 (12:41 +0900)]
Fix Svace issue of SIGNED_TO_BIGGER_UNSIGNED

Change-Id: If3e347df3e06b554d719c7e9361f688ef0e5a314

2 years agofixup! Use PathExists instead of ConditionPathExists 42/282142/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.061357 accepted/tizen/7.0/unified/hotfix/20221116.105446 accepted/tizen/unified/20220928.144415 tizen_7.0_m2_release
YoungHun Kim [Tue, 27 Sep 2022 08:53:08 +0000 (17:53 +0900)]
fixup! Use PathExists instead of ConditionPathExists

Change-Id: I614d83c5dc61a1a128dc871379dd590bb165035a

2 years agoUse PathExists instead of ConditionPathExists 11/282111/2
YoungHun Kim [Tue, 27 Sep 2022 06:26:10 +0000 (15:26 +0900)]
Use PathExists instead of ConditionPathExists

 - ConditionPathExists does not guarantee service file execution sequence.

Change-Id: Ie29ee1954aed23eee2bc931ffdefaf3795a20b7b

2 years agoFix asan issue of heap-use-after-free 23/281423/6 accepted/tizen/unified/20220927.132341
YoungHun Kim [Mon, 19 Sep 2022 00:31:44 +0000 (09:31 +0900)]
Fix asan issue of heap-use-after-free

 - Module released by _ms_ipc_module_cleanup() could be used again in ms_ipc_create_data_dispatch_worker
 - Put into protected critical section for ms_ipc_create_data_dispatch_worker()
 - Update dlog for debugging module handle

Change-Id: Idcbb2efa5ab10a176128d0254613cac6cb85c2dc

2 years agoPut into protected critical section for ms_security_is_privilege_granted() deadlock... 02/280502/4 accepted/tizen/unified/20220902.020110 submit/tizen/20220901.025732
YoungHun Kim [Wed, 31 Aug 2022 04:28:11 +0000 (13:28 +0900)]
Put into protected critical section for ms_security_is_privilege_granted() deadlock issue

 - cynara_check() is not thread-safety
 - Change return type without checking return value

Change-Id: I4d1c650e2284ce35a860898a99c4ba473bfc2139

3 years agoFix coverity issue 44/275844/2 accepted/tizen/unified/20220608.140031 submit/tizen/20220607.004037
YoungHun Kim [Fri, 3 Jun 2022 00:43:45 +0000 (09:43 +0900)]
Fix coverity issue

 - FORWARD_NULL

Change-Id: I85c115161d608604c3b5679a7e9c0adc7c42c397

3 years agoDo not exit at dispatcher worker when destroy dispatcher is failed 00/275800/6 accepted/tizen/unified/20220603.141256 submit/tizen/20220602.062226
YoungHun Kim [Thu, 2 Jun 2022 02:50:59 +0000 (11:50 +0900)]
Do not exit at dispatcher worker when destroy dispatcher is failed

 - The dispatcher worker exits when socket is disconnected and then module_cleanup is called.

Change-Id: I4be7b552f44aac331c907e8fc21d121e310ee484

3 years agoAdd muse_core_set_close_on_exec for FD_CLOEXEC flag 31/275131/5 accepted/tizen/unified/20220525.010115 submit/tizen/20220524.050409
YoungHun Kim [Tue, 17 May 2022 05:52:34 +0000 (14:52 +0900)]
Add muse_core_set_close_on_exec for FD_CLOEXEC flag

Change-Id: I31b83574c2fbd4119334ff7124eef8321f803f05

3 years agoCheck for suspicious memory leaks on every dispatch 77/274577/10
YoungHun Kim [Tue, 3 May 2022 02:02:28 +0000 (11:02 +0900)]
Check for suspicious memory leaks on every dispatch

Change-Id: I60cb4b5bd0059a0e8375c71d03461ba7dfb51d6b

3 years agoFix svace issues 06/275106/7 submit/tizen/20220517.043050
YoungHun Kim [Tue, 17 May 2022 00:19:39 +0000 (09:19 +0900)]
Fix svace issues

 - Unchecked return value from library
 - Remove unnecessary header

Change-Id: I9a31cb772f6fdd7a64b006488091830b8502daf0

3 years agoUse ConditionPathExists to run the daemon only after the wayland service 72/274972/3 submit/tizen/20220516.030437
YoungHun Kim [Fri, 13 May 2022 02:20:12 +0000 (11:20 +0900)]
Use ConditionPathExists to run the daemon only after the wayland service

Change-Id: Ic24633f583067fcdfeac2f5e421e3c297331ed69

3 years agoSet whether to measure the memory through the configure file 37/274537/1 submit/tizen/20220502.073530
YoungHun Kim [Wed, 27 Apr 2022 05:58:37 +0000 (14:58 +0900)]
Set whether to measure the memory through the configure file

 - It can be disabled according to needs, such as performance issues

Change-Id: I937233f4cd3fb3d0bfdad23783c21beba972533d
(cherry picked from commit 6da42e63e253555cbf36322cd86804dbf791f04e)

3 years agoFix 64bit build error 97/273297/2 submit/tizen/20220404.055213
YoungHun Kim [Mon, 4 Apr 2022 00:18:19 +0000 (09:18 +0900)]
Fix 64bit build error

Change-Id: I33a3fbf3ebf8bded984f69655fce39cf71005867

3 years agoRemove void casting 22/273022/1 submit/tizen/20220330.043931
YoungHun Kim [Tue, 29 Mar 2022 23:16:07 +0000 (08:16 +0900)]
Remove void casting

Change-Id: Ia25b747f5cb6d2adffccb54028e2087ffa33da2a

3 years agoInitialize the buffer manager at server startup 53/272453/3 accepted/tizen/unified/20220321.141129 submit/tizen/20220318.073510
YoungHun Kim [Thu, 17 Mar 2022 04:37:36 +0000 (13:37 +0900)]
Initialize the buffer manager at server startup

 - Reduce tbm_bufmgr_init() execution time at client’s initial create()

Change-Id: I78dd1cdd9fec0af83cfad97f482ed969eea20a8b

3 years agoRemove the duplicate variable of server structure 13/270613/2 accepted/tizen/unified/20220208.011108 submit/tizen/20220207.085737
YoungHun Kim [Mon, 7 Feb 2022 04:50:41 +0000 (13:50 +0900)]
Remove the duplicate variable of server structure

Change-Id: I8d1259d42e5a4056dd7991d0ab6eed936d37c298

3 years agoSet the mmap and trim threshold of 64-bit 62/265962/6
YOUNGHUN KIM [Tue, 2 Nov 2021 10:54:58 +0000 (19:54 +0900)]
Set the mmap and trim threshold of 64-bit

Change-Id: I759acb585286257d3660dd69e9a67eb6d050e361

3 years agoAdd libtzplatform-config at dependents explicitly 78/264178/1 accepted/tizen/6.5/unified/20211028.120118 accepted/tizen/unified/20210915.100036 submit/tizen/20210914.064302 submit/tizen_6.5/20211028.162401 tizen_6.5.m2_release
YoungHun Kim [Tue, 14 Sep 2021 05:22:43 +0000 (14:22 +0900)]
Add libtzplatform-config at dependents explicitly

 - Build error occurs because libtzplatform-config is removed from system-info at VD

Change-Id: Ib8361fadd71e5c67854f6fe236bd7fe9d7600069

3 years agoRemove non async-signal-safe function from signal handler 13/263913/3 submit/tizen/20210914.034215
YoungHun Kim [Mon, 13 Sep 2021 09:11:22 +0000 (18:11 +0900)]
Remove non async-signal-safe function from signal handler

 - As Is : Set IDLE state with g_mutex_lock to avoid new client connection while signal handler executes
 - To Be : Remove g_mutex_lock and dlog which deadlock can occur by non async-signal-safe function

Change-Id: I665ebe5017669530912ce493fa5ed9cb378dc19b

4 years agoChange path of configuration file 58/259158/1 accepted/tizen/unified/20210608.131500 submit/tizen/20210604.030216
YoungHun Kim [Tue, 1 Jun 2021 22:53:29 +0000 (07:53 +0900)]
Change path of configuration file

Change-Id: I1ea1a26bf85cfc244ce7b74385293c07b446738b

4 years agoFix coverity issue 22/258522/4 accepted/tizen/unified/20210601.135347 submit/tizen/20210521.025641 submit/tizen/20210528.061611
YoungHun Kim [Thu, 20 May 2021 00:45:32 +0000 (09:45 +0900)]
Fix coverity issue

 - Improper use of negative value (NEGATIVE_RETURNS)
 - Logically dead code (DEADCODE)
 - Out-of-bounds access (OVERRUN)
 - Data race condition (MISSING_LOCK)
 - Update strncmp() part totally

Change-Id: Ie6b23fb1281563522183a90e81048d15cea5207f

4 years agoChange the return value to execute the dispatch only once when no instance 13/255413/2 submit/tizen/20210319.024010
YoungHun Kim [Thu, 18 Mar 2021 04:49:30 +0000 (13:49 +0900)]
Change the return value to execute the dispatch only once when no instance

 - It is to prevent unnecessary recv() after dispatch is normally completed.

Change-Id: I3875f65690a1faa4257ce7d2dd55c798f28adc03

4 years agoChange systemd-devel package name 81/252881/1 accepted/tizen/unified/20210222.114544 submit/tizen/20210219.031951
INSUN PYO [Wed, 3 Feb 2021 03:50:04 +0000 (12:50 +0900)]
Change systemd-devel package name

Change-Id: Ia602785781630caf42acd0c503e1c03ccdf2f425

4 years agoRemove the dying message feature of deadlock's reason 05/251505/2 accepted/tizen/unified/20210118.141052 submit/tizen/20210115.052157
YoungHun Kim [Thu, 14 Jan 2021 10:03:48 +0000 (19:03 +0900)]
Remove the dying message feature of deadlock's reason

 - backtrace_symbols calls internally malloc of async-signal-safe
   which is reason of deadlock when crashed

Change-Id: I47ed587be71cbf291b9c8df0a15cbe8d40767a7e

4 years agoFix build error of muse client 50/250450/5 accepted/tizen/unified/20201229.124649 submit/tizen/20201228.030937
YoungHun Kim [Mon, 28 Dec 2020 02:53:57 +0000 (11:53 +0900)]
Fix build error of muse client

Change-Id: Ib7d19124e29a50aea2aac6f40681213588a8a545

4 years agofixup! Create /run/mused for muse server related file 89/250389/1 submit/tizen/20201228.011732
YoungHun Kim [Thu, 24 Dec 2020 05:52:22 +0000 (14:52 +0900)]
fixup! Create /run/mused for muse server related file

Change-Id: I30d860fdbe394f1818d6dcf03317fc3e02f1dd91

4 years agoCreate /run/mused for muse server related file 53/250353/5 submit/tizen/20201224.052850
YoungHun Kim [Thu, 24 Dec 2020 01:47:59 +0000 (10:47 +0900)]
Create /run/mused for muse server related file

 - move file from /tmp to /run/mused
 - rename the hidden file

Change-Id: Id878b8590b2292e6fbdf17cb7661ca2858ab9287

4 years agoChange pidfile path from /tmp to /run 86/250286/2 accepted/tizen/unified/20201228.130128 submit/tizen/20201223.070656
YoungHun Kim [Wed, 23 Dec 2020 06:14:37 +0000 (15:14 +0900)]
Change pidfile path from /tmp to /run

 - The normal location for pidfiles is /run.

Change-Id: I147f8c09bcf6077305bbbd6fbd4e9e93f6380e9f

4 years agoDisable MUSE_USE_RM_READY to avoid deadlock issue 55/249555/4 accepted/tizen/unified/20201216.215918 submit/tizen/20201215.064128
YoungHun Kim [Tue, 15 Dec 2020 02:00:09 +0000 (11:00 +0900)]
Disable MUSE_USE_RM_READY to avoid deadlock issue

 - It is for avoiding the deadlock issue, which is MUSE_USE_RM_READY's _ms_resource_manager_owner_name_changed_cb()
   executing through dbus when dbus error (eg. GDBus.Error:net.stc.iptables.Error.Failed: OPERATION_FAILED) occurs.
   Thread 2 (LWP 2715):
   #0  __lll_lock_wait_private (futex=0xf7567584 <main_arena>) at ./lowlevellock.c:35
   #1  0xf74a0dc0 in __GI___libc_malloc (bytes=bytes@entry=6) at malloc.c:3064
   #2  0xf75d3c64 in g_malloc (n_bytes=6) at ../glib/gmem.c:99
   #3  0xf75fa978 in g_variant_format_string_scan_type (string=string@entry=0xf76e359c "(sss)", limit=limit@entry=0x0, endptr=endptr@entry=0xffdc7e60) at ../glib/gvariant.c:4597
   #4  0xf75faa06 in valid_format_string (format_string=format_string@entry=0xf76e359c "(sss)", single=single@entry=1, value=value@entry=0xf3eb42a0) at ../glib/gvariant.c:4617
   #5  0xf75fb040 in g_variant_get (value=value@entry=0xf3eb42a0, format_string=0xf76e359c "(sss)") at ../glib/gvariant.c:5499
   #6  0xf76ddf4a in _ms_resource_manager_owner_name_changed_cb (con=<optimized out>, sender_name=<optimized out>, object_path=0xf580ec60 "", interface_name=<optimized out>, signal_name=0xe3fef958 "", parameters=0xf3eb42a0, user_data=0x0) at /usr/src/debug/mused-0.3.131/server/src/muse_server_system.c:269
 - Remove unnecessary log

Change-Id: Iaf270a6a9867486f4ff16a5127d4b19e4b61a6af

4 years agoRemove meaningless log that can be printed frequently 72/249372/1 accepted/tizen/unified/20201214.124518 submit/tizen/20201211.050631 submit/tizen_6.0/20201211.050224
YoungHun Kim [Fri, 11 Dec 2020 00:28:21 +0000 (09:28 +0900)]
Remove meaningless log that can be printed frequently

Change-Id: Ib94156237af25edcc5a2e224f459d335f5948f98

4 years agoMerge branch 'tizen' into tizen_6.0 23/247423/1 accepted/tizen/6.0/unified/20201113.014550 submit/tizen_6.0/20201111.054633
YoungHun Kim [Tue, 10 Nov 2020 23:50:19 +0000 (08:50 +0900)]
Merge branch 'tizen' into tizen_6.0

Change-Id: Ie7ef3053526dc04d34a74dc1c32ef8c007ee954d

4 years agoUpdate client log for clear analysis 09/247309/1 accepted/tizen/unified/20201112.124135 submit/tizen/20201111.054717
YoungHun Kim [Mon, 9 Nov 2020 22:56:37 +0000 (07:56 +0900)]
Update client log for clear analysis

Change-Id: I61ad8f5bdf0ea003e24b0058c1476a320ca007da

4 years agoUpdate log to analyze issues not returned at ms_module_dispatch() 98/246998/1 accepted/tizen/6.0/unified/20201111.064831 submit/tizen_6.0/20201110.051721
YoungHun Kim [Thu, 5 Nov 2020 01:08:40 +0000 (10:08 +0900)]
Update log to analyze issues not returned at ms_module_dispatch()

Change-Id: I0feec619b6ce3888ee676ac653b773f5ccced105

4 years agoUpdate log to analyze issues not returned at ms_module_dispatch() 76/246876/1 accepted/tizen/unified/20201106.051629 submit/tizen/20201105.053617
YoungHun Kim [Thu, 5 Nov 2020 01:08:40 +0000 (10:08 +0900)]
Update log to analyze issues not returned at ms_module_dispatch()

Change-Id: I470bb918e164646074fcde7aab9e5972af8c6061

4 years agoUpdate to log in case of STDIN_FILENO 55/246055/2 accepted/tizen/unified/20201027.125323 submit/tizen/20201023.050718
YoungHun Kim [Thu, 22 Oct 2020 22:50:06 +0000 (07:50 +0900)]
Update to log in case of STDIN_FILENO

Change-Id: I527c7c75065a9807a66b6157f6172f87e2ffc0ba

4 years agoChange watchdog timeout based on g_dbus_connection_call_sync() timeout of runtime... 06/245806/4 submit/tizen/20201016.071425
YoungHun Kim [Fri, 16 Oct 2020 05:00:45 +0000 (14:00 +0900)]
Change watchdog timeout based on g_dbus_connection_call_sync() timeout of runtime-info

 - Currently, muse server watchdog is set to no response for 1 minute. If there is
   no response while executing the g_dbus_connection_call_sync() operation set to 2 minutes,
   the process is terminated by deadlock. Therefore, change the muse-server watchdog time to about 2 min 20 sec.
 - Add log at ms_connection_lock/unlock

Change-Id: I61a2082c51b1cf3fc24123318a221f4b67c3a4cb

4 years agoAdd log of _ms_resource_manager_owner_name_changed_cb() to check execution complete 28/245728/1 submit/tizen/20201015.033807
YoungHun Kim [Thu, 15 Oct 2020 01:16:36 +0000 (10:16 +0900)]
Add log of _ms_resource_manager_owner_name_changed_cb() to check execution complete

Change-Id: I05a004b37002b149aba696fda93af6f27cf89b08

4 years agoAdd log to check if runtime_info_get_process_memory_info() returns 65/245665/3 submit/tizen/20201014.053007
YoungHun Kim [Wed, 14 Oct 2020 02:45:30 +0000 (11:45 +0900)]
Add log to check if runtime_info_get_process_memory_info() returns

Change-Id: I90d6736c68bba998debe023871f85bb5cd72d1de

4 years agoExectue malloc_trim() to release free memory from the top of the heap 88/244188/6 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.114614 accepted/tizen/6.0/unified/hotfix/20201103.003528 accepted/tizen/unified/20200918.123705 submit/tizen/20200917.045119 submit/tizen_6.0/20201029.205104 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
YoungHun Kim [Tue, 15 Sep 2020 23:07:30 +0000 (08:07 +0900)]
Exectue malloc_trim() to release free memory from the top of the heap

Change-Id: I0750d569919faadc9675568a80063116acfa8e6f

4 years agoChanged the timeout of watchdog to maximum dispatcher timeout 85/243685/1 accepted/tizen/unified/20200914.131518 submit/tizen/20200909.064106
YoungHun Kim [Wed, 9 Sep 2020 06:31:55 +0000 (15:31 +0900)]
Changed the timeout of watchdog to maximum dispatcher timeout

Change-Id: I46d815cd1562448e2640f3d0a7c247663e445419

4 years agoUpdate service setting value for the restart failure issue 63/242063/3 accepted/tizen/unified/20200831.122534 submit/tizen/20200828.011226
YoungHun Kim [Mon, 24 Aug 2020 02:18:17 +0000 (11:18 +0900)]
Update service setting value for the restart failure issue

 - The issue is of 'start request repeated too quickly' and 'Failed with result 'start-limit-hit'
 - Set StartLimitIntervalSec to 0 to configure infinite loop until restart is succeeded

Change-Id: Idb931208a50dc598926831dd244f09b73140ac8e

4 years agoFix the duplicate state change while muse server terminating 47/241047/1 accepted/tizen/unified/20200825.033157 submit/tizen/20200821.023316
YoungHun Kim [Fri, 14 Aug 2020 05:53:44 +0000 (14:53 +0900)]
Fix the duplicate state change while muse server terminating

Change-Id: I729775aa5278bb9a538a22e09b4ac336128a2b93

4 years agoUpdate the dlog 69/240069/2 accepted/tizen/unified/20200805.122528 submit/tizen/20200804.040848
YoungHun Kim [Mon, 3 Aug 2020 04:53:20 +0000 (13:53 +0900)]
Update the dlog

 - Set log level for ms_init() to warning

Change-Id: I68d24f8841ebf44c7c500200f02b93c031efaae0

4 years agoRemove the unnecessary null check related with g_async_queue 01/239601/2
YoungHun Kim [Tue, 28 Jul 2020 05:28:33 +0000 (14:28 +0900)]
Remove the unnecessary null check related with g_async_queue

Change-Id: I95265493d0a55a63b7d9d459408266f4d0f59bcc

4 years agoRevise the time buffer array size 43/239343/1 accepted/tizen/unified/20200727.132111 submit/tizen/20200724.062205
YoungHun Kim [Fri, 24 Jul 2020 05:28:51 +0000 (14:28 +0900)]
Revise the time buffer array size

Change-Id: I75972a43b18c2322f3b4a834a72037b638bcee51

4 years agoChange fd dump format of a time structure to monotonic system clock at destroy 65/239265/6
YoungHun Kim [Thu, 23 Jul 2020 08:03:30 +0000 (17:03 +0900)]
Change fd dump format of a time structure to monotonic system clock at destroy

 - change log level

Change-Id: I06462498edbdc39342206188677e7a0f3a10859c

4 years agoUse ms_config_get_host_cnt() to fix DEREF_OF_NULL 20/239220/1 accepted/tizen/unified/20200724.124224 submit/tizen/20200723.014452 submit/tizen/20200723.081321
YoungHun Kim [Wed, 22 Jul 2020 23:16:01 +0000 (08:16 +0900)]
Use ms_config_get_host_cnt() to fix DEREF_OF_NULL

Change-Id: I3e977e5f9ff34de2c141887c9c708b2eaba1d70e

4 years agoUse clock_gettime() with CLOCK_MONOTONIC which is not affected by changing system... 67/238867/10 accepted/tizen/unified/20200722.144553 submit/tizen/20200722.020823
YoungHun Kim [Mon, 20 Jul 2020 02:48:06 +0000 (11:48 +0900)]
Use clock_gettime() with CLOCK_MONOTONIC which is not affected by changing system time

 - update muse_core_get_cur_time() and dlog

Change-Id: I3d194faf73d509d9f438f2cb328a61ba1cad821f

4 years agoAdd gio-2.0, mm-common and libtbm to muse-server.pc 77/238377/4 accepted/tizen/unified/20200717.124728 submit/tizen/20200713.225838 submit/tizen/20200716.054500
YoungHun Kim [Mon, 13 Jul 2020 06:45:29 +0000 (15:45 +0900)]
Add gio-2.0, mm-common and libtbm to muse-server.pc

Change-Id: Ic3dd68aa52f6665f28827e0a3aefc885078b7501