DoHyun Pyun [Wed, 9 Jun 2021 23:33:05 +0000 (08:33 +0900)]
Fix the coverity issue (Memory leak)
Change-Id: If1838213d7a242f8683d5bb166e389fd7edefc9a
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Thu, 13 Feb 2020 02:08:59 +0000 (11:08 +0900)]
Fix the coverity issue
Recursion in included headers
Change-Id: Id1e222a12c4392d83f7799477dcbade45e41e302
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Jihoon Jung [Mon, 2 Dec 2019 13:38:01 +0000 (22:38 +0900)]
Change for documentation link change
Change-Id: Ic7566150272b7414ad6c2bdd0091a0b60a818004
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jung Jihoon [Tue, 2 Jul 2019 10:13:58 +0000 (19:13 +0900)]
make a gcov package for measuring coverage easier
Change-Id: I095cb6423a4ecda5d2bdd00bf508f2e419c22f72
Signed-off-by: Jung Jihoon <jh8801.jung@samsung.com>
VBS [Thu, 9 May 2019 23:24:19 +0000 (08:24 +0900)]
Fixed a svace issue
- Removing potential risk of memory corruption due to
dangling pointer reference.
Change-Id: I9fd0749d42c14aa4bed830375b882525303172d5
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Thu, 14 Feb 2019 01:44:07 +0000 (10:44 +0900)]
Fixed svace 85247 resoure leak.
Change-Id: I484bc15588b3209c5e8fb588a6ae9f3dddd2c91e
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Fri, 1 Feb 2019 04:57:16 +0000 (13:57 +0900)]
Fixed coverity issue : 85247
Change-Id: I980a5009c5d7f4cc11d972c57a6a4e1b5b3cc513
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Fri, 21 Dec 2018 01:31:38 +0000 (10:31 +0900)]
Fixed coverity issue
- Unchecked return value
Change-Id: Id5ffd8bf28ce0184d29006b26bf2048626777d22
Signed-off-by: saerome kim <saerome.kim@samsung.com>
(cherry picked from commit
3b0521e65e6097a95980f9ac87abfd9938d11795)
saerome kim [Wed, 12 Dec 2018 01:47:08 +0000 (10:47 +0900)]
Fixed svace issue : 379816
Change-Id: I0b90921ddf3b2e355d93dbd7eaa935f031ef33da
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Mon, 10 Dec 2018 05:39:11 +0000 (14:39 +0900)]
Fix dlog format: errno
Change-Id: I7ac9dc996e2a1bdb9d9cdf8bf170949da18ccccc
Signed-off-by: Taesoo Jun <steve.jun@samsung.com>
saerome kim [Fri, 7 Dec 2018 04:10:52 +0000 (13:10 +0900)]
Fixed build errors
Changed the dlog input parameters to meet the warning as error policy of
the recently changed dlog.
Change-Id: I3510046759a320966e164bbe460fb6eb4cc82c45
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome.kim [Tue, 30 Oct 2018 00:00:27 +0000 (09:00 +0900)]
Fixed wrong doxygen rules
- @records -> @a records
- #assoc_dev_addr_list -> @a assoc_dev_addr_list
Change-Id: Icacf91567a923cca796214b157077e71ac73b457
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 1 Oct 2018 06:19:25 +0000 (15:19 +0900)]
Remove waring message when calling CHECK_PRIVILEGE
Even if g_dbus_proxy_call_sync() returns NULL, g_variant_unref() calles.
So, we checkout if returned variable is null or not.
Change-Id: Idef3bce2021b71c690ed8055acb8b3fdb8a6cf60
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Thu, 6 Sep 2018 12:03:09 +0000 (21:03 +0900)]
Increase SAM cc ratio
- Make code distributed around a single switch~case routine.
Change-Id: I1116fc8c2950b4e9a1c444e8d1ef5ac2504cf11d
Signed-off-by: Shinhui Kang <sinikang@samsung.com >
saerome.kim [Fri, 24 Aug 2018 11:30:30 +0000 (20:30 +0900)]
Fixed ACR issues
- Fixed typo
- The term ZigBee is unified into Zigbee.
- Delete links that indicate functions which do not exist.
- Remove un-documented descriptions in header files.
- Remove @sice tizen_5.0 at zigbee_doc.h
- Fix svace issues: 37822, 37818, 37817
Change-Id: If90d237a734b048a107d671f3a9d347685773af7
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 22 Aug 2018 11:40:28 +0000 (20:40 +0900)]
Change API name
The APIs below have a name that does not match the purpose,
so changes their name to suit the purpose.
- zb_end_dev_info_get_list -> zb_end_dev_get_end_dev_info_list
- zb_end_dev_get_endpoint_list -> zb_end_dev_get_ep_list
- zb_end_dev_info_get_cluster_list -> zb_end_dev_get_cluster_list
Change-Id: Ia0b4a30894f84dcf2c0295534b08eb1bece18b77
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 8 Aug 2018 02:51:35 +0000 (11:51 +0900)]
Fixed Coverity issue : 1013549, 1013553, 1013556, 1013557, 1013560,
1013562, 1013563, 1013566
Change-Id: Ib351e1fa147236c83d83a1bda484d6b072bf8d02
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Thu, 2 Aug 2018 01:02:55 +0000 (10:02 +0900)]
Made memory allocated at runtime to NULL explicetly.
Change-Id: I42bff55ef4cb677f85b849c623521e08c66fbf6a
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 27 Jul 2018 04:23:11 +0000 (13:23 +0900)]
Fixed coverity issues
(1013568,1013567,1013566,1013563,1013562,1013560,1013560,1013559,1013557,1013556,1013553,1013549)
- Fixed memory leak problem
- Fixed a bug that allocates memory for wrong structure.
- Fixed potential problems that may be handled as negative integer.
Change-Id: Ia124c20b9ddac8ae4cd70e30a783cd5b8c7175af
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 27 Jul 2018 02:25:59 +0000 (11:25 +0900)]
supplemented an insufficient description of the ZB_ZCL_FC_DEFAULT.
Change-Id: I7efe967d70fca2c04177d2235b279bc3da17fea3
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 27 Jul 2018 01:07:39 +0000 (10:07 +0900)]
Fixed ACR issues
- Added @since_tizen 5.0
Change-Id: I61bbacfba60eaf9c86735f922f6638fd91ff4258
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 23 Jul 2018 06:46:03 +0000 (15:46 +0900)]
Fixed ACR issue
- changed zb_device_id_e enumeration type to public.
- fixed broken link issue
- made internal functions and definifions hide.
- removed superfluousness '_attributes_e'.
Change-Id: I4a75afb6e7aa5ef0cd4fe8f8226d97f1a188b8cb
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 20 Jul 2018 00:06:58 +0000 (09:06 +0900)]
Fixed build error
- GBS system in TestHub seems not to recognize PATTERN matching in
CMakeFiles.txt so, removing filtering PATTERN.
Change-Id: I4a7c9786c32e5aebf4a75a8ca424a36fd139b937
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 18 Jul 2018 09:15:07 +0000 (18:15 +0900)]
Fixed ACR issue.
- Added zb_zcl_ias_zone_type_e enum.
- Fixed typos.
- Added 'the' in front of noun
- Fixed the problem that uses wrong pointer
Change-Id: Ie50c8c0a110870b5dc78b29007423084ff7f8ba5
saerome.kim [Tue, 26 Jun 2018 12:58:37 +0000 (21:58 +0900)]
Fixed ACR issue
- Change unused functions as private.
- Fixed API doxygen rule check errors.
- Changed libraray name from libzigbee.so to libcapi-network-zigbee.so
- Added getter functions to get received events in detail
- Enable feature check.
- Fixed many typo.
- Changed some API names.
Change-Id: Iadad7610091f4dd9a5847c9c9e1ad6ac0e914410
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 25 Jun 2018 01:07:26 +0000 (10:07 +0900)]
Modify by ACR header checker
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Change-Id: I9cc95cc98743cdaa72716ec230a7690ded89c6e9
saerome.kim [Wed, 11 Apr 2018 05:21:09 +0000 (14:21 +0900)]
add missing license comment.
Change-Id: Iae55520c4cb5d78ecafe5fd977c1386fd2b57d94
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 2 Apr 2018 09:47:12 +0000 (18:47 +0900)]
Delete unnecessary glib-dbus syntax in a spec file
Change-Id: I357dbf222f65818e2878a5888729eec48aaf9235
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 19 Mar 2018 10:29:25 +0000 (19:29 +0900)]
Fix svace issue
- WID 316204
- WID 316211
Change-Id: I84e92d3f8a03b424cfca48e3c8707adbef2e4095
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome kim [Wed, 25 Oct 2017 10:35:47 +0000 (19:35 +0900)]
Change the handling method of the offset length
Change-Id: I0581a9ca1c21d9f8ea9b44223cf998841bd2f943
Signed-off-by: saerome kim <saerome.kim@samsung.com>
jh8801.jung [Mon, 23 Oct 2017 06:33:39 +0000 (15:33 +0900)]
Fix Coverity issue
- CID : 39189, 38385, 38241, 35436, 28815, 25229, 23514, 23375
Signed-off-by: jh8801.jung <jh8801.jung@samsung.com>
Change-Id: I646fe714c4e6b2f62bc3405c1e724cfd61adff57
(cherry picked from commit
0efdbf0980d899eabdc33c01bfc005250629f401)
saerome kim [Wed, 27 Sep 2017 12:59:24 +0000 (21:59 +0900)]
Fix coverity issues
- Fix incorrect expression issues
- Fix integer handling issues
Change-Id: I58a5d186b683c6ad45133a251f00591c872cd20e
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Wed, 27 Sep 2017 12:34:36 +0000 (21:34 +0900)]
Fix coverity issue
- Fix resource leak issues
- Fix momory corruption issue
Change-Id: Ie5381307a7f87503649523179a527f99848eec88
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Thu, 21 Sep 2017 03:44:44 +0000 (12:44 +0900)]
[WGID-263709] fix duplicated if-else clouse problem
Change-Id: If57ff3a837b41731c93f7d592b7b88cd82e24443
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Wed, 16 Aug 2017 02:03:12 +0000 (11:03 +0900)]
[SVACE] Fix WGID:27020, 27021 and 27022
Change-Id: I5ed9e5b689f88df6450a570e03a5bb5392887246
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Wed, 17 May 2017 02:20:48 +0000 (11:20 +0900)]
Fix svace issues
- new issues are detected related with glib
Change-Id: I44d94654b30c9aa16124900c832a6e8414733812
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Tue, 16 May 2017 04:36:28 +0000 (13:36 +0900)]
Include test application into package
Change-Id: Ie49dab82d2b3ea2821e88821694d4ccaa583e03e
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Thu, 11 May 2017 06:53:25 +0000 (15:53 +0900)]
Fix for svace issues
Change-Id: I99a5e00505a907f5a421c3f00138d91f8cb3206a
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Wed, 10 May 2017 11:08:45 +0000 (20:08 +0900)]
Remove all warnings and fix to follow coding convention
Change-Id: Ie647972a057fd39214c97efe31056fe40ab2f7f7
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Wed, 10 May 2017 10:41:31 +0000 (19:41 +0900)]
Move 'ZB_SUPPORT_PRIORITY_5' APIs to internal level
Change-Id: I9ed30e3d48189fc5091f8a1d3c627b15b4b3bda5
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome.kim [Mon, 8 May 2017 11:28:21 +0000 (20:28 +0900)]
Added missing check-feature routine
Change-Id: I46a266a69d920719959dfb647506eb7d25dfea4c
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jiwan Kim [Tue, 2 May 2017 05:35:10 +0000 (14:35 +0900)]
Change API privilege level
- Change zb_zdo_set_compatible_startup_parameters to platform level.
Change-Id: I1472ec32367cd460fa4d693cc99be768e419fe82
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Tue, 2 May 2017 05:29:57 +0000 (14:29 +0900)]
Fix range check logic
Change-Id: Ic48f8c37a620fb422c9c1a7abdcaa54932ed9522
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Tue, 2 May 2017 01:37:27 +0000 (10:37 +0900)]
Fix for UTC test issue
- Fix typo on API name (zb_get_mac_capabiity -> zb_get_mac_capability)
- Add NULL check for some parameters
(handle, ieee_addr)
- Free device list when test app is terminated.
- Store coordinator mac address on startup of test app.
Change-Id: I3d22cdab54ba5f142ca6352e0a8b72edfca07647
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Fri, 28 Apr 2017 01:42:43 +0000 (10:42 +0900)]
Disable privilege & feature check functions temporally until ACR complete
Change-Id: I608fa19b9448bc5542d1753c9c58030db0b4ce75
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Thu, 27 Apr 2017 09:59:53 +0000 (18:59 +0900)]
Fix allocation logic for ieee_addr
- Fix invalid copy logic
Change-Id: I4ba72c92b9b3e3ca2c6a155d7d5931b0ec68dfee
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Wed, 26 Apr 2017 01:50:37 +0000 (10:50 +0900)]
Adjust output strings of test app
- Add error string for each API return value.
- Arrange some output string.
Change-Id: Ie1816ac4123d1711bc9af588c979afa7a07d9829
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Mon, 24 Apr 2017 10:00:18 +0000 (19:00 +0900)]
Add error string to test app.
This needs at least showing user-fiendly message about error.
Change-Id: I21df55a7117661f2ff47ad8ee16a8f38feee1de1
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Wed, 26 Apr 2017 01:25:50 +0000 (10:25 +0900)]
Fix DBus parameter
- Fix mismatched parameter on signal 'report_attr_handler_rsp'
[qyqaqayayi -> qyqaqa(y)a(y)i]
- Update test parameter for zb_zcl_group_get_group_membership()
to get valid response.
Change-Id: I816b75444aa9cb46ced1d9345da58dbb4552bb55
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome.kim [Tue, 25 Apr 2017 07:21:07 +0000 (16:21 +0900)]
Fix API description
- wrong API description is used. So, we fixed it.
Change-Id: Ic85452892c8373778ecc120dacbce2ce103b65f5
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jiwan Kim [Mon, 17 Apr 2017 10:22:05 +0000 (19:22 +0900)]
Rename internal test program
Change-Id: I8ca4bb9c23e870428fdff763bdbac2dbfd323a34
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Fri, 31 Mar 2017 08:09:22 +0000 (17:09 +0900)]
Change zigbee enabled notification
- previous : sets a callback with zb_enable()
changed : gets result of zb_enable with event (ZB_ZDP_ENABLE_EVENT)
- Currently it is a platform level API.
Change-Id: Id5b1a188d0f869015674867c28f4d3bf2c0f65fe
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Tue, 28 Mar 2017 00:02:57 +0000 (09:02 +0900)]
Fix ACR issue
- change base error code
Change-Id: I7b388fa5124985159d6c709d696a4242914f2cd7
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome.kim [Fri, 24 Mar 2017 10:13:03 +0000 (19:13 +0900)]
Fix ACR issue
- remove @remarks fileds in zigbee.h
- modifying the contents of the zigbee_doc.h
Change-Id: I961b72c7f5ad561d793f30d879b80a2d5fb20b6c
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome kim [Fri, 24 Mar 2017 08:25:43 +0000 (17:25 +0900)]
Fix ACR issue
- add ZCL/ZDO overview documentations
Change-Id: I2463c5c0a501cd7a4df945f80fe5a1c3a4608aab
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Fri, 24 Mar 2017 08:12:32 +0000 (17:12 +0900)]
Fix privilege level comment on doxygen
Change-Id: I4ec82df02c217ce113da0a0aa7e32eca10840ee6
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Fri, 24 Mar 2017 08:03:38 +0000 (17:03 +0900)]
Add missing internal doxygen tag
Change-Id: I22df94b2871c44b8522c0dc3476639b39337959d
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Fri, 24 Mar 2017 07:52:28 +0000 (16:52 +0900)]
Change void type functions
- Update functions to return int return value
Change-Id: I0bad4d1c178edcfeed8c0a66744aba024426a822
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Fri, 24 Mar 2017 04:29:16 +0000 (13:29 +0900)]
Fix unexpected crash on lib side.
- Fix null check sequence in order to prevent
unexpected crash on complicated allocation.
- Add missing API call (zb_zdo_user_desc_set)
- Displays error code on feature check logic
- Check memory allocation failure on test code.
Change-Id: Ifc8fe7ae22374efe26bc192c4c5d3a11ca7e4ece
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Thu, 23 Mar 2017 13:25:52 +0000 (22:25 +0900)]
Fix ACR issue
- Rearrange doxygen document category
- Change handle of structure type to void
Change-Id: I56fde902c1410c6a33828f63979eeeaf0f08324a
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jiwan Kim [Thu, 23 Mar 2017 10:18:08 +0000 (19:18 +0900)]
Add feature / privilege check logic
- Feature check : All APIs
- Privilege check : Required APIs
- Doxygen updation for type of return value
- Adjust Feature name string
Change-Id: I34bba8d6169a47771af39cc75474132813655743
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Thu, 23 Mar 2017 00:36:05 +0000 (09:36 +0900)]
Fix ACR issue - Add privilege description
- Add privilge information into doxygen
- To support platform privilege,
some APIs are separated into 'zigbee_internal.h'
- Remove old scripts on spec file
Change-Id: If2d2d50f30f4d8534c3d5d5fed0dd16be5ab978f
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome.kim [Wed, 22 Mar 2017 13:44:37 +0000 (22:44 +0900)]
Fix ACR issue
- Add feature check routines for feature dependent APIs
Change-Id: I07e84a869f9ce363887bf409b15db06ff512dd8c
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 22 Mar 2017 12:38:11 +0000 (21:38 +0900)]
Fix ACR issues
- Change parameters related Global Command from structure to void
Change-Id: I52b3bbf5bdd9d9bdc9ef6dfd3d5729f794a9bcda
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jiwan Kim [Wed, 22 Mar 2017 04:21:54 +0000 (13:21 +0900)]
Fix ACR issues
- @details : Change to use upper case
- @brief : Change to use upper case
- @enum : Change to use upper case
- Fix typos
Change-Id: I7f238f091ff721b8ac7820329de993aead640d31
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Tue, 21 Mar 2017 08:11:26 +0000 (17:11 +0900)]
Fix typos & ACR issues
- Fix typos on doxygen
- Change doxygen @param[out] -> [in] for callbacks
Change-Id: I7a538dfcd14e87819f9e5ec507120c158a0eaab5
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Mon, 27 Feb 2017 01:01:13 +0000 (10:01 +0900)]
Fixed ACR issues
- Fixed an issue where some enummerations and structures do not have comments
- Added zigbee_doc.h
- Version tags has been changed from 3.0 to 4.0
- Modified to meet Tizen API guideline
- Modified to use '_' in filename
- @brief section is changed to start with verb
Change-Id: I1964b7f40a1172b595c1af06ed94a9461b147e54
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Fri, 17 Feb 2017 02:02:15 +0000 (11:02 +0900)]
Add helper API to display ZDO error string
Change-Id: I24376c3921d26168b934c2d8fcce389e030b8448
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Thu, 16 Feb 2017 11:39:27 +0000 (20:39 +0900)]
Add helper API to display Zigbee profile id and device id
Change-Id: I43bb205041685ef26667138168535e24f8c1fa67
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Thu, 16 Feb 2017 04:19:03 +0000 (13:19 +0900)]
Change bus name with enable/disable method
- Currently, zb_create() registers dbus signal
but it makes daemon activated.
- Change only 'enable' method can execute daemon.
Change-Id: I23cd597407fc04141ab17b34ce575e041f08a84b
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Wed, 15 Feb 2017 11:22:38 +0000 (20:22 +0900)]
Change logic of zbl_disable
- Change to zbl_disable only sends 'disable' dbus method.
- Move its dbus deinitialize logic into zbl_dbus_stop()
Change-Id: I0650fc9917c755ea66e57d22942814c5aaa74b15
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
Jiwan Kim [Tue, 14 Feb 2017 08:35:46 +0000 (17:35 +0900)]
Change zb_enable to async function
- 'enable' method is used to execute zigbee daemon on demand.
- Its synchronous operation may cause unexpected gvariant crash,
change this function to act asynchronously.
Change-Id: I0bf03091ed7327d8127f4a6d4aa56ce51cba8d87
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome.kim [Tue, 14 Feb 2017 06:30:48 +0000 (15:30 +0900)]
Fix doxygen warning
- warning : argument not found
Change-Id: I8efc8cc03294faef10313b34d0818e23b990cc4f
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jiwan Kim [Mon, 13 Feb 2017 07:11:00 +0000 (16:11 +0900)]
Fix unexpected issue on get_group_membership
Change-Id: Ic4dd6dbb9578f0873936e3093a80be31ddc79716
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Fri, 10 Feb 2017 07:15:02 +0000 (16:15 +0900)]
Update test app
- change signal name from 'status_change_rsp' to 'status_change_rpt'
- change printing cluster name function
- change printing error code function
Change-Id: I4d1a177b22d01e201c474676a70914fe740e5127
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Fri, 10 Feb 2017 05:33:43 +0000 (14:33 +0900)]
Change signal / method name
- nwk_disc_req -> mgnt_nwk_disc_req
- nwk_disc_rsp -> mgmt_nwk_disc_rsp
- nwk_update_req -> mgmt_nwk_update_req
Change-Id: I4fd5fbb80a2ba697b16074abef2f768240f3d87d
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Thu, 9 Feb 2017 08:01:29 +0000 (17:01 +0900)]
Fix issues on zb_get_endpoint_list / zb_get_cluster_list
- Related below patchset, API parameter order and
size of structure was not matched.
http://165.213.149.170/gerrit/#/c/151713/
Change-Id: I480ca7de8f66501261d35e3a4cefddc2bc17a119
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome.kim [Thu, 9 Feb 2017 06:01:54 +0000 (15:01 +0900)]
Fix problems related to global commands
- discover_genereated / discover_received
- read attributes
Change-Id: Id885df5778d567f96f791df91a50238188b6113b
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jiwan Kim [Thu, 9 Feb 2017 05:16:03 +0000 (14:16 +0900)]
Add zb_get_endpoint_list / zb_get_cluster_list APIs
- These functions are intended to get endpoint list
and cluster list from specific device.
Change-Id: I819bafb43e99d6ceacc25b277c3adf97d373cfbf
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Wed, 8 Feb 2017 13:50:38 +0000 (22:50 +0900)]
Add debug log to verify segmentation fault due to calling g_variant_unref()
Change-Id: I060ab143c31ffdea65a8df4f21911ab9839cd79d
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Wed, 8 Feb 2017 13:45:37 +0000 (22:45 +0900)]
Add API to print Zigbee Cluster Library status code
Change-Id: I9e1ff35b91b5f733ef0180d4a1ecb8499ae4b43c
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Wed, 8 Feb 2017 10:51:24 +0000 (19:51 +0900)]
Fix warnings and erros generated by Tizen coding rule checker
Change-Id: I4df88dc7dacb16cdfa914915d8b6431fc947c487
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Wed, 8 Feb 2017 07:46:42 +0000 (16:46 +0900)]
Remove build warnings
Change-Id: Ibc5b59b2d54a47ea19484c0cc0343d2338a3d28e
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Wed, 8 Feb 2017 06:48:58 +0000 (15:48 +0900)]
Implement IAS-Zone, Basic cluster test-cases
Change-Id: Ia64069dd1282c3ed5bf8c4623e52f53a89842884
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Wed, 8 Feb 2017 05:56:00 +0000 (14:56 +0900)]
Fix crash with g_variant_unref
- With 'enable' method, g_dbus_proxy_call_sync() returns GVariant
and g_variant_get() deconstructs that GVariant instance.
- It causes below error and sometimes crashes.
[g_variant_unref: assertion 'value != NULL' failed]
- Testing with another method, issue was not found with g_variant_unref()
- Patch newly uploaded due to merge conflict.
(Previous patch : http://165.213.149.170/gerrit/#/c/151298/)
Change-Id: I4c8b7aadcd96a6e5b86f6136e85a1e7ed48588ae
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Wed, 8 Feb 2017 05:27:41 +0000 (14:27 +0900)]
Fix segmentation fault error when DBus errors happen
Change-Id: Iaac27c27dd6f78c8ead6571a75b98b092b6da208
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Tue, 7 Feb 2017 11:56:03 +0000 (20:56 +0900)]
Adjust dbus parameter with ZCL Global control
Change-Id: Ic368683ea66a7f0459a6e408bdb8960cc0ad537b
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Tue, 7 Feb 2017 07:30:23 +0000 (16:30 +0900)]
Change Dbus method as sync.
Change-Id: Idcac0e482bbccc6e1413b0725aedb46226e8043e
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Mon, 6 Feb 2017 06:17:03 +0000 (15:17 +0900)]
Adjust dbus parameter with ZDO dev control
Change-Id: Ic8ace2ecaaf987c03a6174c9ccb0022259e170a3
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome.kim [Mon, 6 Feb 2017 23:11:04 +0000 (08:11 +0900)]
Fix custom cluster to meet zigbee-daemon GDbus interface
Change-Id: Ic91dfbdb07e72f0638c965b739cbc54eb635cf0d
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome kim [Mon, 6 Feb 2017 00:21:26 +0000 (09:21 +0900)]
Change 'ay' to 'a(y)' to avoid null character problem at ZDO bind manager
- change timeout unit from milli second to second in zbl_dbus_get_timeout()
Change-Id: Ie44722d7e7092eadab16d5bab482ebb531927066
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Sat, 4 Feb 2017 07:15:58 +0000 (16:15 +0900)]
Change 'ay' to 'a(y)' to avoid null character problem at ZCL scene clsuter
Change-Id: I00fbdcfccb8dd620e59b7b98a08f226c5393fdaf
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Fri, 3 Feb 2017 06:12:43 +0000 (15:12 +0900)]
Chanage method when calling 'query' method as sync.
Change-Id: I87f78744910d0b16e49fa740566b9eef9975bb01
Signed-off-by: saerome kim <saerome.kim@samsung.com>
saerome kim [Thu, 2 Feb 2017 13:27:53 +0000 (22:27 +0900)]
Change parameters when creating GVariant
- change parameters from 'ay' to 'a(y)'
Change-Id: Ia68ad34f5a6db72b5af6cd7a095e763d7e5e46c0
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Wed, 1 Feb 2017 04:46:57 +0000 (13:46 +0900)]
Fix GVariant match on service method
- Fix unchanged 'ay' into 'a(y)'
- Update logic for zb_leave_device on test app
Change-Id: I69828faecd8fcdf4833a0b262df5dea01ad67134
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Tue, 31 Jan 2017 23:31:47 +0000 (08:31 +0900)]
Change D-bus object path '/org/tizen/zigbee/control'
Problem : zigbee-test2 app. can not receive signals from zigbee-daemon
Cause : signal path not match between app. and daemon
Solution : change D-bus object path name
Change-Id: Idf92c52b34de997013f6a36538c492ecc3e144dd
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jiwan Kim [Tue, 31 Jan 2017 10:55:17 +0000 (19:55 +0900)]
Fix for service methods
Change-Id: Ie246241aa7ffbb71731d8b01d6158125bc164cf0
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Tue, 31 Jan 2017 03:43:46 +0000 (12:43 +0900)]
Fix handling GVariant byte array
- GDbus XML codegen replaces 'ay' variant
(written XML introspection file)
into '^ay' variant.
- If there is '0x0' inside of byte array,
array would be broken. (it acts as a null terminator)
Change-Id: I13eb4e38733eb7ef1c610a11855eef950340b1cb
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Mon, 23 Jan 2017 13:35:52 +0000 (22:35 +0900)]
Restore GDBus API from async to sync.
- add result parameters to let app know the result of its calling
Change-Id: I78f9adbea3b6394a137263796954f06d84a4529d
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Signed-off-by: Jiwan Kim <ji-wan.kim@samsung.com>
saerome kim [Sun, 22 Jan 2017 23:59:37 +0000 (08:59 +0900)]
Change GDBus methods from sync to async
Change-Id: Ibb1f4ef39a5c9447a8166cb4f5aee149d9947405
Signed-off-by: saerome kim <saerome.kim@samsung.com>